Received: by 10.223.185.116 with SMTP id b49csp6341757wrg; Wed, 28 Feb 2018 07:53:00 -0800 (PST) X-Google-Smtp-Source: AH8x226Pl+7s5qI5vDR+Vz4GE85bDXDD66i2XMI0Ho5NzhnmDUXCXMUacc3l3AGH65a1CoCEMQO9 X-Received: by 10.99.66.135 with SMTP id p129mr14841451pga.220.1519833180678; Wed, 28 Feb 2018 07:53:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519833180; cv=none; d=google.com; s=arc-20160816; b=NPPEj1Dp0x9PISPx2Iz7nztP3peYB7C5/SDQ7+m47s3mt0LfZgMVblxcRYoOOO/FyD YqLQLTLwfkVTUuXeCDot5TiQqqzb459Z6BJXizvVpyQpQREmPgR8Tsp2wKnkB5ygRk6B AnLRDDLWErM7T4+fcMTcsG2WIqdRh+M8QMS2+Ea1Geqy/UH9yPk7NnDgBi9C3uajPAAw QF3bOGtA9aYLa2AA58Px6EWveMtW9TR2p1c6qblupXD55ioS2PONqYDtFJmMyuciZ4+/ O9zfRpACzvT3qjajJiwCV2FwJfkk6MV5Oe6TO0yIP780Rx1ywUFxOVRhGgM9MN3LKwWj 9Y9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=52xfxLlkMJDg0RFgJnOdPrv35hHBBv2htDLYDtH4CxU=; b=T1RujB2/qSxsrXVbeP2QKd6Xqx6cvluLQ8jow4jphcm5fASNRXZkkZyZ0BrcEuU0e8 ZTO6MiA1DX7Lhs/fndQc9sTZZy6NTVCf8+Dskl6TMb9u9McOGXTWw+BF3zKF2V3Njpae yykxJtwBA0M2EzOsG+vTAjXr4+0OF7sK/Wl1bMk+dfmi4a7TWV+rcs9zBOCcc5Y0jhCu zqFVZBCvHT6ke+2NBMJ/lELJdU9Nsmz1QMOXxFGuvuvIXyBvpVbODvhsB4GsFKeAxCHs k0EEP6thr27Aorf72CuxAFbXdPHcPL/lgzX8V0QTVXwu8tkGshaR+tXazze2rhSE2O+c u5AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d5si1163900pgf.616.2018.02.28.07.52.45; Wed, 28 Feb 2018 07:53:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933778AbeB1Pvx (ORCPT + 99 others); Wed, 28 Feb 2018 10:51:53 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:34352 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933736AbeB1Pvq (ORCPT ); Wed, 28 Feb 2018 10:51:46 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yg-0006Xf-Nz; Wed, 28 Feb 2018 15:22:19 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Yf-0008Sq-4G; Wed, 28 Feb 2018 15:22:17 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Martin Kelly" , "Marc Kleine-Budde" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 070/254] can: usb_8dev: cancel urb on -EPIPE and -EPROTO In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Martin Kelly commit 12147edc434c9e4c7c2f5fee2e5519b2e5ac34ce upstream. In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Signed-off-by: Marc Kleine-Budde Signed-off-by: Ben Hutchings --- drivers/net/can/usb/usb_8dev.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/can/usb/usb_8dev.c +++ b/drivers/net/can/usb/usb_8dev.c @@ -527,6 +527,8 @@ static void usb_8dev_read_bulk_callback( break; case -ENOENT: + case -EPIPE: + case -EPROTO: case -ESHUTDOWN: return;