Received: by 10.223.185.116 with SMTP id b49csp6345099wrg; Wed, 28 Feb 2018 07:56:42 -0800 (PST) X-Google-Smtp-Source: AH8x224x5c8ws2VpB7PbcFcEVElutS3vUNlF/CvFjx5DRPHxvwXvyyxbq+uNGAORwxhBPBKU48yn X-Received: by 10.101.70.65 with SMTP id k1mr14801337pgr.61.1519833402348; Wed, 28 Feb 2018 07:56:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519833402; cv=none; d=google.com; s=arc-20160816; b=BsHS/IN+8kL2rtCKTEChbRbsblYf0cIhLnMt+7/9LjDDp1XW0+t1yTvGCYBbea449N oyFozxX/B9yOL5A1UrdOjJ6i5LgOnlS/mL9R3pJf2lrkiOCkzOwBcN/D8t/pmO+FcFbk YwdA/QGnrrZijyRvEy6P52hs6imNJklMAvMg55CdvSJ2rmSuVXhweeKObstZ3cCTBB1M BAskoAF5//66C0ik8Tjy1pDF+72vt6qHbz1b9SP0PYy+/uyrsoqIvs6/VSJrCMhbShHm iG1tignYKpCtQDRvgIAdDY5xL2A3u4TCpz/x3IrFYDnWjkDXK5o4K7dB4PzdzetSd7+d dqEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=vlooNmcNMSg6jBSjKIT0FImsdsG1UO81o1kYVX7PLHc=; b=GfJtRWDAZbyoKLnfFZS2KxK0zm6nYnCiX+dGfVQbw1Cl9gOxVMEk80jL/q58yR+3QG 18OlIHM5HnfkNzwRNm/wg0HTz0bKq9UuoxhAejA6VCc0aXyATQHb2k+DMYxid68VrvNl WQJgPtaNWD6ahDLrv1lmXoBHP+HAHknRRXy+utlhYGgYBrmgJ2jlTNBrGRUuHMQXvntf n5mZGyPQA/BLPWpu6qxqyYCu5Kj36jbe+r53wmo3TDTKx5dOWG0drojFZHuAPjd043eN aAEKoLpNUfYQodLpxIgk4Ube5bvSlusT7wVSUTa0NKKt2RMF5VA4MsIKFm9npDt5YUxK SmAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l137si1060454pga.525.2018.02.28.07.56.26; Wed, 28 Feb 2018 07:56:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934000AbeB1PxV (ORCPT + 99 others); Wed, 28 Feb 2018 10:53:21 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:34442 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933722AbeB1PxT (ORCPT ); Wed, 28 Feb 2018 10:53:19 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yg-0006XU-PR; Wed, 28 Feb 2018 15:22:19 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Yf-0008Sl-3T; Wed, 28 Feb 2018 15:22:17 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Marc Kleine-Budde" , "Martin Kelly" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 069/254] can: kvaser_usb: cancel urb on -EPIPE and -EPROTO In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Martin Kelly commit 6aa8d5945502baf4687d80de59b7ac865e9e666b upstream. In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Signed-off-by: Marc Kleine-Budde Signed-off-by: Ben Hutchings --- drivers/net/can/usb/kvaser_usb.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/can/usb/kvaser_usb.c +++ b/drivers/net/can/usb/kvaser_usb.c @@ -975,6 +975,8 @@ static void kvaser_usb_read_bulk_callbac case 0: break; case -ENOENT: + case -EPIPE: + case -EPROTO: case -ESHUTDOWN: return; default: