Received: by 10.223.185.116 with SMTP id b49csp6367891wrg; Wed, 28 Feb 2018 08:15:54 -0800 (PST) X-Google-Smtp-Source: AG47ELsYaOCyRSRCEdvRBut5ghMVP+ZlFj/pLKST3MVFk8xjAHrVg+R8qjtfgn4WwnMnPArvJWFP X-Received: by 2002:a17:902:14e:: with SMTP id 72-v6mr520321plb.280.1519834553977; Wed, 28 Feb 2018 08:15:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519834553; cv=none; d=google.com; s=arc-20160816; b=FU83dMSnmbz8UcTAS8YGglvtaIQvJwZUNjSJeTkqdntf54cVMokGgm8JmKGVc+uxlX JqDgs9w5UtOBojhqavZ7/5YuWkyDAT2xBi+ZhdNOSEZabxBCQImj+kEYRK4JNBALKyrf AioMRQnNmaXYupD046JprKc0G7SeFSlB7Il4xYhDuRa1JbKa4N5IWc8K9oOHpIwoVrlh oB3N6KjCjcN4cBLnJZh/NaJQyIYBmNhxpVV9JE8JNA8kZWr3ZrznS75aAL3kYxklD0dW 3/tP8lsGI2ZXpZr5Cc4zKiO+RYV7jhCWRgcSl+Qgbe1jMwtAguyazg8FVeLLTLeEFvvC Mbqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=iFhWQosL7V8nRh3VZjplB/4jS/GbxoSDvQU2jtMEUg4=; b=RGdDtvTXQ7qEDUQ6+1lcXcnZeI1acUNGc1N75imHLYmeXZ3DfgFRCq+QSmaAAmzAUL opg8Q/t7z2EQZzRS4Ps/jVz/dFXkqr5m3dvKqx3ZPj7qB6Grx5lP9nlMEOlUkm8PBgR5 eoWJ27VOPrh1vxtNdODq+FShMQ3Ce6XIrk46H9iPgy5rMCPpCBsuVZwZZmfwNs1zw6hl 8xdI4L0YbjEoK8sUxIXMZCJG/eU0+vV9bnxDCIsn02qoo4qpAgscUjU1HGj9PtRjA7K9 9RHOECnooeBGk8J/fST577hsb/ThW36uPNADrViNScLh61TBJ2+RsuBTZy9VB1qJuSWD k23w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x14si1215113pgq.168.2018.02.28.08.15.39; Wed, 28 Feb 2018 08:15:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934595AbeB1QNh (ORCPT + 99 others); Wed, 28 Feb 2018 11:13:37 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:35058 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933070AbeB1QNf (ORCPT ); Wed, 28 Feb 2018 11:13:35 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yo-0006XP-7m; Wed, 28 Feb 2018 15:22:26 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Yk-0000Hh-Bn; Wed, 28 Feb 2018 15:22:22 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "David S. Miller" , "Johannes Berg" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 221/254] cfg80211: fix station info handling bugs In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Johannes Berg commit 5762d7d3eda25c03cc2d9d45227be3f5ab6bec9e upstream. Fix two places where the structure isn't initialized to zero, and thus can't be filled properly by the driver. Fixes: 4a4b8169501b ("cfg80211: Accept multiple RSSI thresholds for CQM") Fixes: 9930380f0bd8 ("cfg80211: implement IWRATE") Signed-off-by: Johannes Berg Signed-off-by: David S. Miller [bwh: Backported to 3.16: drop change in cfg80211_cqm_rssi_update()] Signed-off-by: Ben Hutchings --- --- a/net/wireless/wext-compat.c +++ b/net/wireless/wext-compat.c @@ -1273,8 +1273,7 @@ static int cfg80211_wext_giwrate(struct { struct wireless_dev *wdev = dev->ieee80211_ptr; struct cfg80211_registered_device *rdev = wiphy_to_rdev(wdev->wiphy); - /* we are under RTNL - globally locked - so can use a static struct */ - static struct station_info sinfo; + struct station_info sinfo = {}; u8 addr[ETH_ALEN]; int err;