Received: by 10.223.185.116 with SMTP id b49csp6378350wrg; Wed, 28 Feb 2018 08:26:05 -0800 (PST) X-Google-Smtp-Source: AG47ELuHiuRqMwOfVBFkH8RYcXbuKsGQGveJJNWxHX8Wlly8Or/7F5YKYjBaq879z/f8oE7QEaXn X-Received: by 2002:a17:902:8a89:: with SMTP id p9-v6mr11210137plo.379.1519835165094; Wed, 28 Feb 2018 08:26:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519835165; cv=none; d=google.com; s=arc-20160816; b=aZBgOhn5wrt4yMvNaWK5tZ0keGd4/8n8RNqlesi/qug3Adpjpuv3syoVq1OZ6xCCyV BYYpiUKZHAlRwZ7gcax8g9yvP186nbW4XmRuvXKrImxUcImLnb3hyeNUTRHDch9hSd22 lLnnOkcYlRNuEF2elTbKQG04mO/eKwSm44AET//D8u4sCFhhi9Hin3Z9+SGq7ZerKFWE qpF87Tq2HgJPzxNSjagNt+nqsZQt1r6gXTtaE6BJcQxRjBY7iRFUpbewj2sVSTn6bb2R CqVlY0hWW3bTor/NyZL1s/0LLhMA96sIOMjmu+gGWAIEcgd4JfS7TZ6kCyUzXrbz5pCi i7KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=85qzP2yd8fv+1uk/gC8YFpzQWJ9K0322Wl5vk86k6Dk=; b=W6uDJvbSP8BsEZQEUvqgG+i1GEL4OhYTdQ8sX0s7CmGH5b0FiukdXGLewztKxhuirW zs/gyj57c6SzpCoZK1XPiJDVqPH31xxirUdBSAppWnRAyXW9ws5oL+VkOh+1Ysnzt409 xxbiF+TWU3IcptavzRtHObopRtw6WvydBASP2zuE5XY5xsAcF/9VO0eQgUfcTLnlgN33 Gzd46miN2B5+Ij6Az/SLGsEUzvclTfCmKWecxKV32+dmkJwA2XbgQGec09iYCvr0VVTx yxqKPxkLRs/gFsNlG44FHZkPes68ra/24Nr4+6SHBpEPvl2B4dBI68jXvrQ3EEa8HVNQ wN6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l30-v6si1086800plg.346.2018.02.28.08.25.49; Wed, 28 Feb 2018 08:26:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935222AbeB1QYr (ORCPT + 99 others); Wed, 28 Feb 2018 11:24:47 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:35364 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935154AbeB1QUf (ORCPT ); Wed, 28 Feb 2018 11:20:35 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yg-0006Xj-PQ; Wed, 28 Feb 2018 15:22:19 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Yf-0008Sb-1a; Wed, 28 Feb 2018 15:22:17 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Martin Kelly" , "Marc Kleine-Budde" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 067/254] can: ems_usb: cancel urb on -EPIPE and -EPROTO In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Martin Kelly commit bd352e1adfe0d02d3ea7c8e3fb19183dc317e679 upstream. In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Signed-off-by: Marc Kleine-Budde Signed-off-by: Ben Hutchings --- drivers/net/can/usb/ems_usb.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/can/usb/ems_usb.c +++ b/drivers/net/can/usb/ems_usb.c @@ -290,6 +290,8 @@ static void ems_usb_read_interrupt_callb case -ECONNRESET: /* unlink */ case -ENOENT: + case -EPIPE: + case -EPROTO: case -ESHUTDOWN: return;