Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1519835851.30349.7.camel@perches.com>
Subject: Re: [PATCH] checkpatch: avoid error report caused by syzbot
From:   Joe Perches <joe@perches.com>
To:     Yisheng Xie <xieyisheng1@huawei.com>, apw@canonical.com,
        akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org
Date:   Wed, 28 Feb 2018 08:37:31 -0800
In-Reply-To: <1519809018-1736-1-git-send-email-xieyisheng1@huawei.com>
References: <1519809018-1736-1-git-send-email-xieyisheng1@huawei.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-02-28 at 17:10 +0800, Yisheng Xie wrote:
> syzbot request to add his reported-by when fix the bug find by syzbot.
> However, it will trigger a error when use checkpatch:
> 
>   ERROR: Unrecognized email address: 'syzbot+d7a918a7a8e1c952bc36@syzkaller.appspotmail.com'
> 
> For it include '+' in email and make regular expression works abnomal. Fix
> it by adding check for syzbot.
> 
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>

Nack.

There's a proper patch already in -next

commit 14e45b3ecdb03211ab32656cd84e66fd6a28343e
Author: Joe Perches <joe@perches.com>
Date:   Thu Feb 22 09:59:45 2018 +1100

    checkpatch: improve parse_email signature checking
    
    Bare email addresses with non alphanumeric characters require escape
    quoting before being substituted in the parse_email routine.
    
    e.g. Reported-by: syzbot+bbd8e9a06452cc48059b@syzkaller.appspotmail.com
    
    Do so.
    
    Link: http://lkml.kernel.org/r/1518631805.3678.12.camel@perches.com