Received: by 10.223.185.116 with SMTP id b49csp6396643wrg; Wed, 28 Feb 2018 08:43:52 -0800 (PST) X-Google-Smtp-Source: AH8x2267708LfE9EjhNwJRA0vi+/kZmas4Op7F+Khpv39K3WuYgD6/QPTV11qoXiZ0wFTpkpdDVg X-Received: by 10.98.166.85 with SMTP id t82mr18209573pfe.237.1519836232113; Wed, 28 Feb 2018 08:43:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519836232; cv=none; d=google.com; s=arc-20160816; b=OEZ76itt5K4MiRmEJKgBjUEBcuvSzdlPXmDDPr2I3FOjLg8TpPkXMUtPiDKMGpEgW3 see7NT84Y7NJwf2XQYFDzWwLxb0xkryupGOAo8He4uFW3LfhGcDG6wpdnnPE7LokHJvN Zp7rD6GMxbGuOUgI4HmupPu7+hZzG8AfU6PG1gWmyNOeOXEQhg1d7fyH0gwr7xCsmX1z mM95oY27FxLa01q0/2njjHzdJV78Ga2kqGxDJjQiefzkw0E7Q+OzEIKRyNAAfaSp6EX4 lHQgQkjA1v5asBG3q09U1P0zg+z9zacA1QbY6UsXlMj1zkNMXGEcFoOcX3HNPOi5eodk 2s5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=u1mMwSb418BpzB9hoIYObfE3sZSfkNKeLzeKjYNpOsU=; b=OVAqhCTWb0GL449AikVQSeJhMrVju2aajwaPIJ/+oDp7rdVDmz+UaO0fTOI51MiO2S 2Wt3AoK57aavPZ5pRNcWN0gfGoGzC7cEbzbBdEWPYyhvIqbcu5LHNdE2Iz2d3NpyMPGX DjUQcKetkrLeqnWdXQru2F2selb5t+vKlkHMLZdGIvY1KsQS6gtec9c28hf2CXMCowL7 +KyAz3jQWLqMkLcQBKQ/YBZzWDLz28Rk/gnjxP2+ZzJ2IMxzWg2ulpRpK6/uZtEhcS4Z bcCpO9mKGlurG+audiMRjpkQ5gM0o4HnJedifmzo7vIfXG6peOFMygN6jjfJw+2bXEUB 7H+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3si1213893pgb.419.2018.02.28.08.43.37; Wed, 28 Feb 2018 08:43:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932884AbeB1QDW (ORCPT + 99 others); Wed, 28 Feb 2018 11:03:22 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:34755 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932754AbeB1QDR (ORCPT ); Wed, 28 Feb 2018 11:03:17 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yg-0006XR-OE; Wed, 28 Feb 2018 15:22:19 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Yf-0008Sg-2U; Wed, 28 Feb 2018 15:22:17 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Marc Kleine-Budde" , "Martin Kelly" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 068/254] can: esd_usb2: cancel urb on -EPIPE and -EPROTO In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Martin Kelly commit 7a31ced3de06e9878e4f9c3abe8f87d9344d8144 upstream. In mcba_usb, we have observed that when you unplug the device, the driver will endlessly resubmit failing URBs, which can cause CPU stalls. This issue is fixed in mcba_usb by catching the codes seen on device disconnect (-EPIPE and -EPROTO). This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it in the same way. Signed-off-by: Martin Kelly Signed-off-by: Marc Kleine-Budde Signed-off-by: Ben Hutchings --- drivers/net/can/usb/esd_usb2.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/net/can/usb/esd_usb2.c +++ b/drivers/net/can/usb/esd_usb2.c @@ -395,6 +395,8 @@ static void esd_usb2_read_bulk_callback( break; case -ENOENT: + case -EPIPE: + case -EPROTO: case -ESHUTDOWN: return;