Received: by 10.223.185.116 with SMTP id b49csp6406041wrg; Wed, 28 Feb 2018 08:54:02 -0800 (PST) X-Google-Smtp-Source: AG47ELtVx5Me0ZJfaRCjsWzHvcXUTlgz5uFbzcBW7Ywry7ozta/lqdK387zt7niG/ESKPTNq5JFy X-Received: by 2002:a17:902:bc3:: with SMTP id 61-v6mr3799440plr.398.1519836842695; Wed, 28 Feb 2018 08:54:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519836842; cv=none; d=google.com; s=arc-20160816; b=rz5hT2QZKffsc76xdCoQFpT0VhIRIGCf0SxUMor/vZ7JyzvF2p6GXEnbBHwvruwiCq EhuTacMwmaeD/Vpi/+zcbDADTjRqlfG0SOrlhSZ68kQQw0W/Dy1ey606TL9CfigNXoow 9Wu3fEubhFp3+WI0e5v67SFInxMMNeGJxkXOFxwQ6YLDVVitj+QogcvkS0KF01viiady UWyOtFel7DJOORcFt9S/ccyFc1mwnNkCQ8QBmRLU1gpF3/NhJVIz5WoINca4fM6I3kBh TflMcx98NLKI3nh3setlQHbhNpysz5iWhfShSOm95W66ryRaFla0fhfgcLppfqEuYrcM t2Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=SmfHUqHirySy5Er1Zf/s4X3OQbs6O/cEYv7kMTme39M=; b=gwLvEb+XcqTlUfwNA55wgZCmq5+kfSZin/H08p3/QOwuIo0Gzfv+r+fDBspf8815uD F9m+wGa79vDSTcXZ0Z6FJQAfAaOkBu1YotrlLsjTvgfy5Y4DG9o8Dz4Xi8+h8bRHXQql 7GOByia9ptuJAax0NVYk7hWuDAdbfs8mOrnY3hqRDq6YQUSePYmAsV7h0DUUP1j/V3PP LYF5lmp9PzzCuYDyVXihuCQo5kKSLTpyAAM4wjCngp3k5zYL8ee9md/zzCKwGGG2nRy/ Q+dZTqv7aNZMexaBsfvroHrVu8VFPiQiW0gFwaYpdWE2xcJMWbVXnnMPytZSl1+8hic9 UgtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si1489679pfa.162.2018.02.28.08.53.47; Wed, 28 Feb 2018 08:54:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbeB1P6F (ORCPT + 99 others); Wed, 28 Feb 2018 10:58:05 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:34543 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933979AbeB1P6C (ORCPT ); Wed, 28 Feb 2018 10:58:02 -0500 Received: from [2a02:8011:400e:2:6f00:88c8:c921:d332] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1er3Yi-0006XU-IZ; Wed, 28 Feb 2018 15:22:20 +0000 Received: from ben by deadeye with local (Exim 4.90_1) (envelope-from ) id 1er3Yh-00007H-2j; Wed, 28 Feb 2018 15:22:19 +0000 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Greg Kroah-Hartman" , "Shuah Khan" Date: Wed, 28 Feb 2018 15:20:18 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 128/254] usbip: stub: stop printing kernel pointer addresses in messages In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.55-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Shuah Khan commit 248a22044366f588d46754c54dfe29ffe4f8b4df upstream. Remove and/or change debug, info. and error messages to not print kernel pointer addresses. Signed-off-by: Shuah Khan Signed-off-by: Greg Kroah-Hartman [bwh: Backported to 3.16: - Drop change in stub_complete() - Adjust filenames] Signed-off-by: Ben Hutchings --- drivers/staging/usbip/stub_main.c | 5 +++-- drivers/staging/usbip/stub_rx.c | 7 ++----- drivers/staging/usbip/stub_tx.c | 6 +++--- 3 files changed, 8 insertions(+), 10 deletions(-) --- a/drivers/staging/usbip/stub_main.c +++ b/drivers/staging/usbip/stub_main.c @@ -256,11 +256,12 @@ void stub_device_cleanup_urbs(struct stu struct stub_priv *priv; struct urb *urb; - dev_dbg(&sdev->udev->dev, "free sdev %p\n", sdev); + dev_dbg(&sdev->udev->dev, "Stub device cleaning up urbs\n"); while ((priv = stub_priv_pop(sdev))) { urb = priv->urb; - dev_dbg(&sdev->udev->dev, "free urb %p\n", urb); + dev_dbg(&sdev->udev->dev, "free urb seqnum %lu\n", + priv->seqnum); usb_kill_urb(urb); kmem_cache_free(stub_priv_cache, priv); --- a/drivers/staging/usbip/stub_rx.c +++ b/drivers/staging/usbip/stub_rx.c @@ -225,9 +225,6 @@ static int stub_recv_cmd_unlink(struct s if (priv->seqnum != pdu->u.cmd_unlink.seqnum) continue; - dev_info(&priv->urb->dev->dev, "unlink urb %p\n", - priv->urb); - /* * This matched urb is not completed yet (i.e., be in * flight in usb hcd hardware/driver). Now we are @@ -266,8 +263,8 @@ static int stub_recv_cmd_unlink(struct s ret = usb_unlink_urb(priv->urb); if (ret != -EINPROGRESS) dev_err(&priv->urb->dev->dev, - "failed to unlink a urb %p, ret %d\n", - priv->urb, ret); + "failed to unlink a urb # %lu, ret %d\n", + priv->seqnum, ret); return 0; } --- a/drivers/staging/usbip/stub_tx.c +++ b/drivers/staging/usbip/stub_tx.c @@ -201,8 +201,8 @@ static int stub_send_ret_submit(struct s /* 1. setup usbip_header */ setup_ret_submit_pdu(&pdu_header, urb); - usbip_dbg_stub_tx("setup txdata seqnum: %d urb: %p\n", - pdu_header.base.seqnum, urb); + usbip_dbg_stub_tx("setup txdata seqnum: %d\n", + pdu_header.base.seqnum); usbip_header_correct_endian(&pdu_header, 1); iov[iovnum].iov_base = &pdu_header;