Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 28 Feb 2018 19:16:35 +0200
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sergio Lopez Pascual <slp@redhat.com>,
        Baoquan He <bhe@redhat.com>, "Somlo, Gabriel" <somlo@cmu.edu>,
        xiaolong.ye@intel.com
Subject: Re: [PATCH v15 11/11] RFC: fw_cfg: do DMA read operation
Message-ID: <20180228191553-mutt-send-email-mst@kernel.org>
References: <20180215213312.29234-1-marcandre.lureau@redhat.com>
 <20180215213312.29234-12-marcandre.lureau@redhat.com>
 <20180227020104-mutt-send-email-mst@kernel.org>
 <CAMxuvay=4qSLZBVHoPPX+6ZNEmyS2G-69hHqW3HVdxFoS90h1g@mail.gmail.com>
 <20180228173444-mutt-send-email-mst@kernel.org>
 <CAMxuvax37dKhY0jTqbOqjOxQORA=hdDZc3S33b8RFiAbcOLWTg@mail.gmail.com>
 <20180228174635-mutt-send-email-mst@kernel.org>
 <CAMxuvaw-v3BagJ6-50sxW24X3c=S-4Xfd5e1Unq8ScNbxKvkSQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMxuvaw-v3BagJ6-50sxW24X3c=S-4Xfd5e1Unq8ScNbxKvkSQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 28, 2018 at 05:00:58PM +0100, Marc-Andr? Lureau wrote:
> Hi
> 
> On Wed, Feb 28, 2018 at 4:48 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Wed, Feb 28, 2018 at 04:41:51PM +0100, Marc-Andr? Lureau wrote:
> >> I don't know if it's always safe to enable dma in read_raw(), how
> >> could we know? Is there a check we could use to choose one or ther
> >> other (and thus avoiding explicit dma/readfn argument)?
> >
> > I'm not sure - but does it really matter? Is anyone reading large files
> > like this in production where speed matters?
> > Why even bother with DMA?
> 
> The difference is quite significante for not so small files, as shown above.
> 
> And if they access the fw_cfg entries at boot time, or when starting
> things etc, this may speed things up.

Question would be whether anyone at all does this.

-- 
MST