Received: by 10.223.185.116 with SMTP id b49csp6497790wrg; Wed, 28 Feb 2018 10:22:51 -0800 (PST) X-Google-Smtp-Source: AH8x226RkwIHO6alvJ1owmz+47S3Lc2oUde5s4QVv3y+2ijC7vA0sZ7QPBBgWkhFsmDZB3zpToMR X-Received: by 2002:a17:902:8608:: with SMTP id f8-v6mr19244836plo.366.1519842171830; Wed, 28 Feb 2018 10:22:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519842171; cv=none; d=google.com; s=arc-20160816; b=CGlblY0csvChWLzPY4B1vx1V3xQPl/C3/72I8HwpCvvm2rUR3r2mLhd/kJUEu3r3Uw mOawRuXZaRTIQGoPcoWH6o6PY5oMJLK6NmmoOwx380hSwSwHIwYto7WNJMRi6K8i/59T ovWHKSgX3gBMHDwQYeF9C7ZEJbbYbX6JHznh8wbzBv7OZ63HQvZZLR6q/hiZDQH9Boer P+zr6WkUzFtUT3xWrDXCMR/KXstKBTooAVDVUFzpB4+++44igKZ75iwNOyx/SGTyn/w6 KwV1D/d40J7svrl9DM4I4ZaGn8Q9hNCZqEkeGdGAicesfHt/eZqsiexYLpmC7vyJq9q5 /Xyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:cc:to:subject:from :arc-authentication-results; bh=KsujM0699a/ITIdm3xPdrB1zG/ArLDa6M8U2dm6lYwg=; b=kWkZsnirwOreXJc9HBTaLIfWjLX4KJOj19vTz+pLOtz0y+bn1aj2R+LckpdAGN+UzW ePyjn+Kns+II7Z4hcyJdEQMMX7F5MoouEASNReRBabfjZ6Rnz3fA+Gco4kBqi2KrFUbS mXHO5H+LCpOFszhqvpVBTMxOemIdYNEsjhWc4iQ7gNanNhZq3eAYC+T21TQyazv7z342 yPg40w2ePeHUS9X6SjQaUjCxXZASWivhEDoIG9XT3KG18y026A1dE1oYjdGT4oatnyo5 s3a3KAmLxkbL0fpigEqGNJ2FEOcHPSgLBZp3lwEbYovYN4S+wdHBR9t1QzvDy+JIcG1r NNkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x10-v6si1649407pln.30.2018.02.28.10.22.36; Wed, 28 Feb 2018 10:22:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410AbeB1SVu (ORCPT + 99 others); Wed, 28 Feb 2018 13:21:50 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:2322 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932126AbeB1SVr (ORCPT ); Wed, 28 Feb 2018 13:21:47 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 3zs3mb1MtKz9tvRv; Wed, 28 Feb 2018 19:21:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id wB85clY8Fb74; Wed, 28 Feb 2018 19:21:35 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 3zs3mb0tsxz9tvRj; Wed, 28 Feb 2018 19:21:35 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 297E18BB63; Wed, 28 Feb 2018 19:21:46 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id TvuFilmmq1Ks; Wed, 28 Feb 2018 19:21:46 +0100 (CET) Received: from po15720vm.idsi0.si.c-s.fr (unknown [192.168.232.3]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 03F2C8BB56; Wed, 28 Feb 2018 19:21:46 +0100 (CET) Received: by po15720vm.idsi0.si.c-s.fr (Postfix, from userid 0) id AD1C76F114; Wed, 28 Feb 2018 19:21:45 +0100 (CET) From: Christophe Leroy Subject: [PATCH] powerpc/dma: remove unnecessary BUG() To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Scott Wood Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Message-Id: <20180228182145.AD1C76F114@po15720vm.idsi0.si.c-s.fr> Date: Wed, 28 Feb 2018 19:21:45 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Direction is already checked in all calling functions in include/linux/dma-mapping.h and also in called function __dma_sync() So really no need to check it once more here. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/dma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/kernel/dma.c b/arch/powerpc/kernel/dma.c index da20569de9d4..e1cd6e979348 100644 --- a/arch/powerpc/kernel/dma.c +++ b/arch/powerpc/kernel/dma.c @@ -235,8 +235,6 @@ static inline dma_addr_t dma_nommu_map_page(struct device *dev, enum dma_data_direction dir, unsigned long attrs) { - BUG_ON(dir == DMA_NONE); - if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC)) __dma_sync_page(page, offset, size, dir); -- 2.13.3