Received: by 10.223.185.116 with SMTP id b49csp6525801wrg; Wed, 28 Feb 2018 10:54:09 -0800 (PST) X-Google-Smtp-Source: AH8x225CDVspL+KJmeAQ+IAiTs5MIYOF01Ii0Ivs5sCXhGN6kuj/eWXk2TMZJjfvPrHeiQ/hve9N X-Received: by 2002:a17:902:47c2:: with SMTP id d2-v6mr18373467plh.253.1519844049044; Wed, 28 Feb 2018 10:54:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519844049; cv=none; d=google.com; s=arc-20160816; b=izc2xo2LYKRxqVctew1XL2573kdn5MQPfxa4lbGOZuafpy5vkovmBTW4pVeSuHKUma l4dhPQ8IO8A56zFlkcQ5PWDv7QhcI2XZbkHrKvQi5KtTkB3eJ1TrecCXm987hU3S2d7p tzMIqIwjgwxjigrtvqiLCVhO++Fk93jJqx3if+bUpPoUlYDKSx7A08sGFxarzyEaDAR8 Mhey6kOvtTUrqK2gFJhfowNHlVFTD8nL/hjhPCJr9Ucpzl8A73QHwOD7Dhq45JZVR6X3 9cJNYY0tbMsFFxTv/2s/b2IR80NTToy+lozRogz8Mmx2LiuChnMg0B2Tl0kzq3raMK4u bBFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=IvNwfGpROo8bc+ZdOfXaJB5JjL/dq+kDx0sJTY5WMaE=; b=QEu2lE7ogecTsPCdSj0pVkQYW7gOjhGJ/cw8ux+SqaNwt92/DrMpqtlDcCF8RfK7by uW4nXF3rGprxWZvSopo26rfraC+Xouo9kz1eCvAwgY6dZz3Pdlc16tqSYB3O10zwvepl 6YOqqwqSV6gB0DNrqABQW9ye6xKC/buwG4Mh5A0/E8fD/TEUAKysuiT4Kfzfv2VOWcQG cuXQbZA56THdfoSxVRQNL0JrvCerVwW0+bto2MO0tvv0wysqYapNSHo1osQP+Phauort oMWeDkOsX7TGzvm/pZD93E8hyooqR+uzVSKHiAs3B3y+ii/5ugvWZvHlGxwOIZsmnRV2 3z1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@lunn.ch header.s=20171124 header.b=eKiD6Z5N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si1626072pfw.112.2018.02.28.10.53.54; Wed, 28 Feb 2018 10:54:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@lunn.ch header.s=20171124 header.b=eKiD6Z5N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbeB1SxO (ORCPT + 99 others); Wed, 28 Feb 2018 13:53:14 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40757 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735AbeB1SxM (ORCPT ); Wed, 28 Feb 2018 13:53:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=kGmWSnW4x4q+3un2zkKFWoVS4QZcsQQttd1tiHL4Pio=; b=eKiD6Z5N0E5RxhHS5AkJFyZxU/briIogRmr904wflS1aqapIK5OkaRPilYhOTJVp6h5XYEr7MVZdHXSpq9m1IWZ2Hu2qsZ6OuiAqYyHkV5wQWWIrg6+LY6LdNJN+XLhM21SHIvSoAPkbLcj+eM5HaOFZ86GqzrFbN3FzsI/uh8Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1er6qc-00016i-GU; Wed, 28 Feb 2018 19:53:02 +0100 Date: Wed, 28 Feb 2018 19:53:02 +0100 From: Andrew Lunn To: Tim Harvey Cc: Lee Jones , Rob Herring , Mark Rutland , Mark Brown , Dmitry Torokhov , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Subject: Re: [RFC 2/4] mfd: add Gateworks System Controller core driver Message-ID: <20180228185302.GD1203@lunn.ch> References: <1519780874-8558-1-git-send-email-tharvey@gateworks.com> <1519780874-8558-3-git-send-email-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519780874-8558-3-git-send-email-tharvey@gateworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + dev_err(&client->dev, ">> 0x%02x %d\n", reg, ret); > + return ret; > + } > + dev_dbg(&client->dev, ">> 0x%02x=0x%02x (%d)\n", reg, val, retry); > + > + return 0; Hi Tim There appears to be a few spaces vs tabs issues in this file. Andrew