Received: by 10.223.185.116 with SMTP id b49csp6567927wrg; Wed, 28 Feb 2018 11:38:10 -0800 (PST) X-Google-Smtp-Source: AH8x225z+3t14WcS+BpcCRJOcqK7tVcb+QHJL8aFtk5MBlxEs9BwdmA9okYeQc2du5bylLR79pvr X-Received: by 10.99.95.15 with SMTP id t15mr14837676pgb.183.1519846690805; Wed, 28 Feb 2018 11:38:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519846690; cv=none; d=google.com; s=arc-20160816; b=t4F5FoUXl5shjIbBPeivAYYDVg2HKF/EdRZxdrbBrfoy8c8gZw6Ej+lnzflX2B6vpl VjYdv3nClTcLB7ikd82i6ij1ITJRqXyjD/koUiVOCpKg+MB0CnyINVjKmrad7hj6HveB oaFa3K5G+q8MQAFrzvjmPGJJDev+R23mec5OrNhQ3cJ7BWPLHkwmU4C+bAFCv+ewNxV7 NiJwIDQQtvJ2iDP89AeboJHTPgsfOFt4crGDje4awmDd0D1eXBxlo1sjXMa+XBKQ/52K 6VnfjgTaATN6q1WtJEReRwTq2sg5sJXoDLPV8TSe4oLR7nriIr7GauYBPBvZYyZFsg2W mvmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=/vcr2P81v07vbJNrFQFO7WVheDJ8L7zyqRilNQKewls=; b=UBi2puS7yjC2uvNyCNJLDDnK8RFsq0ojjgYQPoPaKKeAou8tMohGv7f2vXrOlJ0MLh bAi2i0H6xuzMqRv8YR1Y/igdhguaIxrOs1WNvhzT5W5I5qVfMWGBE5aiBRVmz+iCE8oK S3qCv6nyNQNmrWTNk/SSPAjlyQxrB2xFT+BN4AgTYS8Ssw80jdQ6lispIi06Utlg8rio cpO5m6slj0RPgvnkKWfC9JpqjPaaCFVlcHoYt3qj+0aeszhP7g2tBiyWT5iFJ5jToTWs Q9zZBApCrkhopIkuECJBSF+YPd9RxiXUVlg3hk+mlZ5BG3+xX6LUWh+USsKTgf/IYdJQ vKyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UUoIuJy8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c7si1654854pfi.323.2018.02.28.11.37.55; Wed, 28 Feb 2018 11:38:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UUoIuJy8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933848AbeB1ThM (ORCPT + 99 others); Wed, 28 Feb 2018 14:37:12 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:35449 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933531AbeB1ThK (ORCPT ); Wed, 28 Feb 2018 14:37:10 -0500 Received: by mail-qt0-f196.google.com with SMTP id z14so4506912qti.2; Wed, 28 Feb 2018 11:37:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/vcr2P81v07vbJNrFQFO7WVheDJ8L7zyqRilNQKewls=; b=UUoIuJy8kzbxbfhiGeZwUtZh9WC5HDzuzmI4lLX72lVm9l33G+2qMmzK0+c3HbWYFG 635mIOESGFoVEzhlM8Qjo1VLhGIwy5avJwGnpDAfXV8V95gTuWgQRvsmf+oOqWy+nzjx 4SqcwtdMPVXW1bL449TohysarvllXNzrA01ALZ+B1YduhcT9ovkez4YUYccURXP0ZqEx Ee3TAy5Hsh7xfGLW3DTeoV7KoadGEVX+f9ghxbmoclclQKRh98ronkeZkWXClI9jWTLq YGlooLM6FSRWjedkiDcgdV3I4GLDS3z+HzZ8W/cWz7I2fPzhhkGokEvTydWZpeAq8eHa Ks0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/vcr2P81v07vbJNrFQFO7WVheDJ8L7zyqRilNQKewls=; b=OnWDhwUaak19lhgi2BRPuc2+aDjG5RcTzFTDR2n4kZtMdberr87lYyFY0eCLwDkFif sYuhs4VigiAZcpfD6D48bHI4UAlEmmw32Ryb/fG5OK1TNH0jpFUogt9KdQrZ1asia52z E+T4JpiPoqd5nmJwEoiQw3uYYxDokFAF8b2z3QKrGMpBd0IecmpVTVAc8/JIMEPEDLNt NpG65TnA7m+BvpJqeApjDERFgx3AglBy1FafYpVkt8oScdmRFc1jIMwrQrR3DDBzEiRm UGwBdfEWUrluYknv0bIR0iGVcveuTnA2X8ysGA+jCeyQ5kScGK5qMb5Zl8TqTy0VVVRm zKcA== X-Gm-Message-State: APf1xPCnMZvtUSXcCqT+irEQLLyvm1K0V08V+VWVDlzJBdwlzZXfTIfK OJMTiG0BTYHtHG0iklZuiX94OlFv X-Received: by 10.237.50.37 with SMTP id y34mr32237322qtd.234.1519846628833; Wed, 28 Feb 2018 11:37:08 -0800 (PST) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id k131sm1588790qke.5.2018.02.28.11.37.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Feb 2018 11:37:07 -0800 (PST) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Russell King , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 4/5] net: phy: cortina: Utilize generic functions Date: Wed, 28 Feb 2018 11:36:11 -0800 Message-Id: <20180228193612.29409-5-f.fainelli@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180228193612.29409-1-f.fainelli@gmail.com> References: <20180228193612.29409-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cortina_soft_reset() does the same thing as gen10g_soft_reset(), and cortina_config_aneg() is actually doing what gen10g_config_init() does for 10G capable PHYs. Signed-off-by: Florian Fainelli --- drivers/net/phy/cortina.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/net/phy/cortina.c b/drivers/net/phy/cortina.c index 9442db221834..9afbeb8b3667 100644 --- a/drivers/net/phy/cortina.c +++ b/drivers/net/phy/cortina.c @@ -30,14 +30,6 @@ static int cortina_read_reg(struct phy_device *phydev, u16 regnum) MII_ADDR_C45 | regnum); } -static int cortina_config_aneg(struct phy_device *phydev) -{ - phydev->supported = SUPPORTED_10000baseT_Full; - phydev->advertising = SUPPORTED_10000baseT_Full; - - return 0; -} - static int cortina_read_status(struct phy_device *phydev) { int gpio_int_status, ret = 0; @@ -61,11 +53,6 @@ static int cortina_read_status(struct phy_device *phydev) return ret; } -static int cortina_soft_reset(struct phy_device *phydev) -{ - return 0; -} - static int cortina_probe(struct phy_device *phydev) { u32 phy_id = 0; @@ -101,9 +88,10 @@ static struct phy_driver cortina_driver[] = { .phy_id = PHY_ID_CS4340, .phy_id_mask = 0xffffffff, .name = "Cortina CS4340", - .config_aneg = cortina_config_aneg, + .config_init = gen10g_config_init, + .config_aneg = gen10g_config_aneg, .read_status = cortina_read_status, - .soft_reset = cortina_soft_reset, + .soft_reset = gen10g_soft_reset, .probe = cortina_probe, }, }; -- 2.14.1