Received: by 10.223.185.116 with SMTP id b49csp6664247wrg; Wed, 28 Feb 2018 13:17:53 -0800 (PST) X-Google-Smtp-Source: AH8x226Rouo3NZPEq3EPRvg5mC7RdcQjK+YEWLNUOS5bJxDm5cNIzHLJpEMYmBVzzkep9JwY5WIP X-Received: by 10.99.113.90 with SMTP id b26mr15151293pgn.10.1519852673179; Wed, 28 Feb 2018 13:17:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519852673; cv=none; d=google.com; s=arc-20160816; b=Tkcs0LYbNzlgVJ/CcOuHDF70KqAcXRWMTs0J8EqG+AyxfJylnKxF1mHByxLX2WSX5l jhRGM0Ns9oN6UwaisB9gnpY2kXy8VW45esSgMHnjKxq8Rae5Lu3kaQ9qnYdvT9BHfBnq vivAPOii4n50zU5m1b/FY3nL35rWPNTGxhlMkMepYVa9L9u6FIka/WBygNoICYkiaZQ3 3mB8IZ44hqoKOJVgjOdNq+IGeEYJU/4zPeVyLuuSk/GBXsfB6p1g7ggGDl4q1cu9mvS2 QCe7cPHQl5bT8+jJPkR241W1G7NcfDSmv6dIJjEx0vJgKDqJqsVXp3QOA8ipwvfILAV+ 9B6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Zdcg3AqMMWv24VZ6jY4e8bpBEpb/+an9CEECbn0X1m0=; b=y1xYX5+V7d+8vYLkJSDvLfirfwIN792QUjuwvtSKOOM3hn2X9onaJcVvD9I5wzJBjR Ne3Bm46OkDZUjlWH9a0lKWWX9xkx05EjhmEyeDEF+LUOkTdqTlBjecKrT8Hed2zo8Fo3 tKfixWADc8uEA9dVXA1X1O3rv/8LrZH+7SbgAcvd7MPnSVFPEkaxGuZP/w9VqfAxRWM4 Mvk4WOftiIfsa5+eCIUqQduWZj1OwSc2JveWYavLw8JS5oCfL/3hCURGpS0mQrnH1Y3H TxEHGwY3Azyk9QG8nYTZFt0JFUBXFy2fUlVEaeGekjkmQjkCY+/hzKR67EV4S2xL+sE1 e1Gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gateworks-com.20150623.gappssmtp.com header.s=20150623 header.b=ZnVJBgkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3-v6si1842872plc.317.2018.02.28.13.17.38; Wed, 28 Feb 2018 13:17:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gateworks-com.20150623.gappssmtp.com header.s=20150623 header.b=ZnVJBgkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934911AbeB1VQG (ORCPT + 99 others); Wed, 28 Feb 2018 16:16:06 -0500 Received: from mail-wr0-f181.google.com ([209.85.128.181]:33516 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933018AbeB1VQE (ORCPT ); Wed, 28 Feb 2018 16:16:04 -0500 Received: by mail-wr0-f181.google.com with SMTP id v18so3284326wrv.0 for ; Wed, 28 Feb 2018 13:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Zdcg3AqMMWv24VZ6jY4e8bpBEpb/+an9CEECbn0X1m0=; b=ZnVJBgkFuDyRTA0hHptBcd+PPib+xcc8z2Ad8Gb1lxQqMBU5wFEJcQMk9ON03yPs2T Ra3H8T5yET6Y3tcTpJeJhKNrNFQl7xQzaVjdJbfZB87CSdHRHp+2gpn94oYSURgTbZ9y Gse6SWOumUOe9MTdhhXVnnrJnnrrbHOf4K2j0jXb9FRd11/oqkkg0MLuHtBrRzaRGmyI De1x9CxJysXNEgKjswTG0WjOFI+RV6gk9bXIhqRy1p1l6Frgwn9wzsKlY0d1llqUEDuo Qhpg2Amqs/3b1IcTzwU5bebMUHnvffn9Fv4qb4wP9Xr/9myNZVGYEZdOtEfRtqsfzPtr GYsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Zdcg3AqMMWv24VZ6jY4e8bpBEpb/+an9CEECbn0X1m0=; b=JdKPEuQQ4DRgsbNyP4FaxLSonl5iiE3ffQrP1W+4XVBPYC5HZonY9mpbUEcs6UbKFY 2GDOxGZeIIPFSBYwrfkDEfng7FPbZAN/9N0gFQiZovk+7xZ9Pb99Stxb+FR0pMDyHvjD ooLgcmg9iY37f0ePFa96Z8EJnmOASOODfJ/f/jhUbRWbD9GBFsoUpS1xwyJykD/EOhFi tP9YYFjreyEwNshOqfQ6PbTmDhZDMdXQBhzME2l33ATR5gAptbEwY+iLvHPRXp0tZfJ5 xbNM5AuPdfwas9inA27nCvtDirsB0Zil8ceTYjRZwVVw5Oaa59J/uGfjwtXRKj4yym5B Vycw== X-Gm-Message-State: APf1xPChjDB4MAOtisBkObtace/sD0WM4qKxRSGDmOCUrSrjszZmobcz 37UHut4n+USGLlcXbfNJK75ivTOP6IUHjEjqSLBKvA== X-Received: by 10.223.183.39 with SMTP id l39mr18600960wre.214.1519852563174; Wed, 28 Feb 2018 13:16:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.6.66 with HTTP; Wed, 28 Feb 2018 13:16:02 -0800 (PST) In-Reply-To: <20180228185302.GD1203@lunn.ch> References: <1519780874-8558-1-git-send-email-tharvey@gateworks.com> <1519780874-8558-3-git-send-email-tharvey@gateworks.com> <20180228185302.GD1203@lunn.ch> From: Tim Harvey Date: Wed, 28 Feb 2018 13:16:02 -0800 Message-ID: Subject: Re: [RFC 2/4] mfd: add Gateworks System Controller core driver To: Andrew Lunn Cc: Lee Jones , Rob Herring , Mark Rutland , Mark Brown , Dmitry Torokhov , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 28, 2018 at 10:53 AM, Andrew Lunn wrote: >> + dev_err(&client->dev, ">> 0x%02x %d\n", reg, ret); >> + return ret; >> + } >> + dev_dbg(&client->dev, ">> 0x%02x=0x%02x (%d)\n", reg, val, retry); >> + >> + return 0; > > Hi Tim > > There appears to be a few spaces vs tabs issues in this file. > > Andrew > Thanks. I'll run through checkpatch prior to v2. Tim