Received: by 10.223.185.116 with SMTP id b49csp6960611wrg; Wed, 28 Feb 2018 19:50:57 -0800 (PST) X-Google-Smtp-Source: AG47ELvhry0V4bAVwbTEqR04m5TrCsKquJ2Era95GHS/R2uXVzdNEQMUI0tWPukjzkDvoShVxvdI X-Received: by 2002:a17:902:a705:: with SMTP id w5-v6mr487657plq.299.1519876257699; Wed, 28 Feb 2018 19:50:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519876257; cv=none; d=google.com; s=arc-20160816; b=dKR0HvRihS1LlAT8TCHCXMDx7j0vTo5ve9dDJxLidmp8rDV9vnOsngqqrQlv4CqrDy 3OFcn3jb8ryRrolEWNp0udb+C9YQshCEh5Khoxo6YHL+ia3NsjUYTBVxyemqyhzHjY/L hjae7C3bktFYUulnUOCJ+E+MsG6CUUtPtBe2T3+7ieCFzDLEWs/1QwbccoYEe0SY8sUu UXbmZB6I375V7ohfF7KY/T5YV0ASP6raG4iTumG3OQbeqmp+tbIhUXhfmbv5y7PHfet7 uUI1N0REzQBGRMxKnt7Ghk8vvh+8AOmt/A71grHVaAlXK2OoMjbMMmlZ7qV5gVyDWd7w xvdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id :arc-authentication-results; bh=B8y4xhSo+lL+qizgeSuVUXsLmdMkBIV5XRPjPNdQc+U=; b=AX8gIrMeh6wuGCui7zV8vzh0eu7DcLEKRfgtcWqIW3ksbaOz5f6yUuYbJuLJohIxYz ziL/O23dJvYNJhW1k4kARKByOZnUSbM0E4qjv738WIhzh53LMHutZy+MRVhQ6rczQ0jN 2xLUOHw2pfs+KfdTrGo69em0t53uW2kEhPP5iswmgZTOdKKycJsB9eMnZixBDeoPNMVR QlhnH9x5I9igNwUqCabDSCyL8KM9AI/Ab7fBEdFxLmdDI3YolJvVVYP21GMuMZrc2j4i sPomdD0FbxFoMmKdFbYYv43J3tO+1YCxVqvm2vTv8aHSJWWtlE62L+7oL0o+eEjf90yb cp0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5si1904616pgf.646.2018.02.28.19.50.42; Wed, 28 Feb 2018 19:50:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965796AbeCADsP (ORCPT + 99 others); Wed, 28 Feb 2018 22:48:15 -0500 Received: from mailgw02.mediatek.com ([1.203.163.81]:34227 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S965674AbeCADsN (ORCPT ); Wed, 28 Feb 2018 22:48:13 -0500 X-UUID: 81c265c3520b45b49a5f84a667465b38-20180301 Received: from mtkcas36.mediatek.inc [(172.27.4.250)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1572598677; Thu, 01 Mar 2018 11:47:54 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 1 Mar 2018 11:47:52 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Thu, 1 Mar 2018 11:47:52 +0800 Message-ID: <1519876072.23198.17.camel@mhfsdcap03> Subject: Re: [PATCH v2 4/4] pintcrl: support bias-disable of generic and special pins simultaneously From: Zhiyong Tao To: Sean Wang CC: , , , , , , , , , , , , , , , Date: Thu, 1 Mar 2018 11:47:52 +0800 In-Reply-To: <1519804157.23198.9.camel@mhfsdcap03> References: <1519634042-12063-1-git-send-email-zhiyong.tao@mediatek.com> <1519634042-12063-5-git-send-email-zhiyong.tao@mediatek.com> <1519803217.8089.31.camel@mtkswgap22> <1519804157.23198.9.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-02-28 at 15:49 +0800, Zhiyong Tao wrote: > On Wed, 2018-02-28 at 15:33 +0800, Sean Wang wrote: > > On Mon, 2018-02-26 at 16:34 +0800, Zhiyong Tao wrote: > > > For generic pins, parameter "arg" is 0 or 1. > > > For special pins, bias-disable is set by R0R1, > > > so we need transmited "00" to set bias-disable > > > When we set "bias-disable" as high-z property, > > > the parameter should be "MTK_PUPD_SET_R1R0_00". > > > > > > Signed-off-by: Zhiyong Tao > > > --- > > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 13 +++++++++++-- > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > > index 3cf384f..e88ba04 100644 > > > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c > > > @@ -301,8 +301,17 @@ static int mtk_pconf_set_pull_select(struct mtk_pinctrl *pctl, > > > * resistor bit, so we need this special handle. > > > */ > > > if (pctl->devdata->spec_pull_set) { > > > - ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > > > - pin, pctl->devdata->port_align, isup, arg); > > > + if (enable) { > > > + ret = pctl->devdata->spec_pull_set( > > > + mtk_get_regmap(pctl, pin), pin, > > > + pctl->devdata->port_align, isup, > > > + arg); > > > + } else { > > > + ret = pctl->devdata->spec_pull_set( > > > + mtk_get_regmap(pctl, pin), pin, > > > + pctl->devdata->port_align, isup, > > > + MTK_PUPD_SET_R1R0_00); > > > + } > > > > > > it looks like you can use as following snippet with reusing original > > logic and less effort on maintaining these common code (?) > ==> Thanks for your suggestion very much. It seems better. > I will change it in v3. ==> Hi sean, we try it in our site. we can't change like this. Because we will check "arg" after setting "arg = MTK_PUPD_SET_R1R0_00;". following snippet which check "arg" value is o or 1. If it not, which will print error. so we can't change like this. /* For generic pull config, default arg value should be 0 or 1. */ if (arg != 0 && arg != 1) { dev_err(pctl->dev, "invalid pull-up argument %d on pin %d .\n", arg, pin); return -EINVAL; } Thanks. > > > > > > if (pctl->devdata->spec_pull_set) { > > + if (!enable) > > + arg = MTK_PUPD_SET_R1R0_00; > > > > ret = pctl->devdata->spec_pull_set(mtk_get_regmap(pctl, pin), > > pin, pctl->devdata->port_align, isup, arg); > > > > > > Also, it's better to add more comments to such kind of special path for > > allowing future SoCs to follow and extend more easily. > > ==> Thanks for your suggestion very much. I will add more comments here. > > > > > if (!ret) > > > return 0; > > > } > > > > >