Received: by 10.223.185.116 with SMTP id b49csp7018992wrg; Wed, 28 Feb 2018 21:10:44 -0800 (PST) X-Google-Smtp-Source: AG47ELvjNkV7WRSoZyZgsw5K1wWaTZreOzoMM3eumqQ/rE22xjiLVYy6xOpfat9mgoNizchLUqEo X-Received: by 10.99.114.24 with SMTP id n24mr521970pgc.400.1519881044586; Wed, 28 Feb 2018 21:10:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519881044; cv=none; d=google.com; s=arc-20160816; b=HPaHpTj9baUKQOzuien0gz9fODKH0fsIexMxA94RH1U1odqLXAMEPEWDFMCobdSQv2 mlNNPNAq527zbcNnWmeBgLHLYUOtMVBSGA/MYC7yQTdKQuntuT0/+hmUzRflQgPqb4DM SOHS5SBUVOVqyZw7nKAzFe4NqNA9VSO3KPP7fgHrxyku4RPGUCNuPWLnSK3WT8adWT2E BmlfVPRvy311wjAIOU+wt6wPVCVyqmn5u3kBNeuo9zcqIcPpOYQnGZHDA+sjvw8va3yT JSPL+APOsZFxNIE+p4N2kyJuATlAcV7ZYd0ZBn6mspZkdAJnjO/pNcUg79G4cKfO2fNq OiVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject:arc-authentication-results; bh=w5MhWkIVkhU5qAqX3UYeCkBedn72e6q8FbkSkMuEp/U=; b=cktc464BYuWiYIq2J05jqnz9LIhj+uFirqCNOfJgI/I+sGb/KprFykno0bL7/q+oC0 cfQIHNPHqaXE9CnkBRY2oa3irKchHeoxG4IqbyZKstQY7Jp8bp+io3EeHZd8a8H/accd JwJ/m/vR5bOBcClv37svJln3T+D75L6DSexlBK2zHqf4Gs8F/Ju7PN6COoQC+v/OhupQ rLgDJq5vYbJH1LMlTJT2wAGwzZAC7ra6TXlbAdzdmKQki0aChc3+8w99APueHCrDP+L1 q57yNJg0PmY82UFc1MDH2g2ZraxnxhQ60ZIahBAyou6aV+iZjCEs25TqhPY/7fXWtdCb B/Iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d62si145089pga.631.2018.02.28.21.10.30; Wed, 28 Feb 2018 21:10:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965999AbeCAFJb (ORCPT + 99 others); Thu, 1 Mar 2018 00:09:31 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40820 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965984AbeCAFJa (ORCPT ); Thu, 1 Mar 2018 00:09:30 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2159OZV022247 for ; Thu, 1 Mar 2018 00:09:29 -0500 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 2geaq00twt-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 01 Mar 2018 00:09:28 -0500 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 1 Mar 2018 05:09:24 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 1 Mar 2018 05:09:22 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2159L0x32506092; Thu, 1 Mar 2018 05:09:21 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42F004C04E; Thu, 1 Mar 2018 05:02:50 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EFDC24C046; Thu, 1 Mar 2018 05:02:47 +0000 (GMT) Received: from [9.124.31.169] (unknown [9.124.31.169]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 1 Mar 2018 05:02:47 +0000 (GMT) Subject: Re: [RFC 1/4] Uprobe: Rename map_info to uprobe_map_info To: Srikar Dronamraju Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, mhiramat@kernel.org, ananth@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com, oleg@redhat.com, Ravi Bangoria References: <20180228075345.674-1-ravi.bangoria@linux.vnet.ibm.com> <20180228075345.674-2-ravi.bangoria@linux.vnet.ibm.com> <20180228120929.GB63063@linux.vnet.ibm.com> From: Ravi Bangoria Date: Thu, 1 Mar 2018 10:41:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180228120929.GB63063@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18030105-0040-0000-0000-000004394527 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18030105-0041-0000-0000-000020DC4796 Message-Id: <221509ff-12ae-5348-bb17-6073198717b6@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-01_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803010065 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/28/2018 05:39 PM, Srikar Dronamraju wrote: >> -static inline struct map_info *free_map_info(struct map_info *info) >> +static inline struct uprobe_map_info * >> +free_uprobe_map_info(struct uprobe_map_info *info) >> { >> - struct map_info *next = info->next; >> + struct uprobe_map_info *next = info->next; >> kfree(info); >> return next; >> } >> >> -static struct map_info * >> -build_map_info(struct address_space *mapping, loff_t offset, bool is_register) >> +static struct uprobe_map_info * >> +build_uprobe_map_info(struct address_space *mapping, loff_t offset, >> + bool is_register) > Imho, uprobe_build_map_info may be better than build_uprobe_map_info, > similarly uprobe_free_map_info. Sure, Will change it. Thanks, Ravi