Received: by 10.223.185.116 with SMTP id b49csp7160919wrg; Thu, 1 Mar 2018 00:28:08 -0800 (PST) X-Google-Smtp-Source: AG47ELufNPiTwSrD76Pcsl9YujZOZoDAJBoUwTO/WC7JlBn08/AU19NHeiri9DNMTf9R41tAV14c X-Received: by 2002:a17:902:f44:: with SMTP id 62-v6mr1140728ply.27.1519892888650; Thu, 01 Mar 2018 00:28:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519892888; cv=none; d=google.com; s=arc-20160816; b=eDfwx1WFQJb2yOBJtm5clFdVFOK/iQI0u7+grtX3+/Rku/YwA+sZ5v7Q49LdiNNNdv DzPINA5d+Fx6GloI9P/DHECDck6mpO81pzTxiMREX5kOAGJ2JQJKJDQ6u+E+bmwaJbq/ Ycuw33SbwL6o3f880sq7ad9/7/4alTjX7HhWEdUx8Hd7k7QW3UMHQ9OaIL+AuW4hojjs tqZwIYqB5819rlipQaRV8qdQmYk0m6U3oKivOnvM/KGkoT1MUTDEdrD9dtbGiT32BtzK vQRBJ5CU01gF5xjp6FdTOWwI6csPxEKRux0hZZUZSVwCEmw3e5pfFhjjUKXO3pe37IQo CENw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=EHoWBe3BQxmcXMAtpNRmT8ppqwPa9M/R1rPurTYapOY=; b=FOQEWq8n3kW6hMkUQK/CKHgBtlUsDKWB7Lmv9pS9zIVoSkK6bdHSrTanuX9k7rXprs iew7q+BN31wf8ZCyFduatc122Bo8jRcJXvWzhg5uWhhhHwNXy1mSkthmszwhsvgQXaio nIaX/cjRDZHt/MvtMzA2GWJ/41Tewk4Z1Om8Tnp8eL4mGrIR0Mhj/DLY3URP8zLP6vQ8 sEpjXLQAKPRwDg1tZps+8YLexpGZzlCae2gAGbwrSt9NB9Ze3jNiQurtOzp+dmOjZoHD mK692C4vhetIYgwEpmLTSsa52pxRcnGW67rewERJY0cB/Mv4G95tr7RYsStVduH6JJEA KUpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p20si2654359pfi.13.2018.03.01.00.27.54; Thu, 01 Mar 2018 00:28:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965377AbeCAI0v (ORCPT + 99 others); Thu, 1 Mar 2018 03:26:51 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52834 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964841AbeCAI0u (ORCPT ); Thu, 1 Mar 2018 03:26:50 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9EA0A8182D0C; Thu, 1 Mar 2018 08:26:49 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-147.ams2.redhat.com [10.36.116.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE8D410AF9F3; Thu, 1 Mar 2018 08:26:48 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4557C1751D; Thu, 1 Mar 2018 09:26:48 +0100 (CET) Date: Thu, 1 Mar 2018 09:26:48 +0100 From: Gerd Hoffmann To: Oleksandr Andrushchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, daniel.vetter@intel.com, seanpaul@chromium.org, gustavo@padovan.org, jgross@suse.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, Oleksandr Andrushchenko Subject: Re: [PATCH 0/9] drm/xen-front: Add support for Xen PV display frontend Message-ID: <20180301082648.frnslqyhffj2bkwl@sirius.home.kraxel.org> References: <1519200222-20623-1-git-send-email-andr2000@gmail.com> <4c7e6f65-1787-3815-22b5-f9495e388c06@gmail.com> <7e265c53-db9a-0946-6b1c-b946bcbb4100@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e265c53-db9a-0946-6b1c-b946bcbb4100@gmail.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 01 Mar 2018 08:26:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 01 Mar 2018 08:26:49 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'kraxel@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > 1. Possible security issues - VirtIO devices are PCI bus masters, thus > allowing real device (running, for example, in untrusted driver domain) > to get control over guest's memory by writing to its memory > > 2. VirtIO currently uses GFNs written into the shared ring, without Xen > grants support. This will require generic grant-mapping/sharing layer > to be added to VirtIO. > > 3. VirtIO requires QEMU PCI emulation for setting up a device. Xen PV > (and PVH) domains don't use QEMU for platform emulation in order to > reduce attack surface. (PVH is in the process of gaining PCI config > space emulation though, but it is optional, not a requirement) Well, that is wrong. virtio doesn't require pci. There are other transports (mmio, ccw), and it should be possible to create a xen specific transport which uses grant tables properly. Seems there even was an attempt to implement that in 2011, see https://wiki.xenproject.org/wiki/Virtio_On_Xen > 4. Most of the PV drivers a guest uses at the moment are Xen PV drivers, > e.g. net, > block, console, so only virtio-gpu will require QEMU to run. You are not forced to use qemu, you can certainly create an alternative host side implementation (and still use on the existing virtio guest drivers). Whenever writing a xenbus implementation for both guest and host or writing a virtio implementation for the host only is better -- dunno. The virtio path obviously needs some infrastructure work for virtio support in Xen, which may pay off long term. Your call. cheers, Gerd