Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272827AbTHEPqb (ORCPT ); Tue, 5 Aug 2003 11:46:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272836AbTHEPqa (ORCPT ); Tue, 5 Aug 2003 11:46:30 -0400 Received: from bay-bridge.veritas.com ([143.127.3.10]:7186 "EHLO mtvmime03.VERITAS.COM") by vger.kernel.org with ESMTP id S272827AbTHEPq1 (ORCPT ); Tue, 5 Aug 2003 11:46:27 -0400 Date: Tue, 5 Aug 2003 16:48:02 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@localhost.localdomain To: Linus Torvalds cc: Andrew Morton , Randy Dunlap , Leann Ogasawara , Subject: [PATCH] revert to static = {0} Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 22 Please revert to static zero initialization of a const: when thus initialized it's linked into a readonly cacheline shared between cpus; otherwise it's linked into bss, likely to be in a dirty cacheline bouncing between cpus. --- 2.6.0-test2-bk/mm/shmem.c Tue Aug 5 15:57:31 2003 +++ linux/mm/shmem.c Tue Aug 5 16:16:55 2003 @@ -296,7 +296,7 @@ struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); struct page *page = NULL; swp_entry_t *entry; - static const swp_entry_t unswapped; + static const swp_entry_t unswapped = {0}; if (sgp != SGP_WRITE && ((loff_t) index << PAGE_CACHE_SHIFT) >= i_size_read(inode)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/