Received: by 10.223.185.116 with SMTP id b49csp7348762wrg; Thu, 1 Mar 2018 04:12:34 -0800 (PST) X-Google-Smtp-Source: AG47ELubdBU8uHJMusUYQbU37UPaf4gCaPXKJFGSPtMJozq6uJk3F18a04Q3SyBpeHEobPZUsi/R X-Received: by 10.99.114.18 with SMTP id n18mr1367978pgc.169.1519906354683; Thu, 01 Mar 2018 04:12:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519906354; cv=none; d=google.com; s=arc-20160816; b=WpSQwWmUD8HMWYf5MQmcvPoIvYPuX9j7aB+t1IkouneeZsbcIeevpjpu+0G/Enpdn2 /AUp2nAPigyTUXzdMRVbF15WjsdAhmME70a5i6djzPXFOXVE7VRiKEH/5xDqpSjRd4nR Ds9Zu72avutFdEtSsv8dUPBPafQkcDgUDsXs8796ecRKkX/LS7iJ8dpftkjHPHZCXJHE sxmq+rrBXfq5oEz97gDHsATvyTujJKCaYloJcFh8IiVyQrhwB4gh2a9joUlM4ZxR4Nz3 b4z660iOBfan2xIECQD2wRo6wJPajou0qEn9+z9ecv6KxGfTrxBtuD3WucNTOPYjhHlm I44Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=YfCpBmW1STMAOGcbjMMiTUK4pyZWgZUCkBLxYQnjXSk=; b=wFNGQ1sEGjm8dPUz9cyK6Cf6T4hLcGVH/tBClRWcwHsWvG4LJpbti27Pdiges2CTWo m5pRCk+CTQI8NFQc1W4yHJOTEXSGnHz9TcBc0EoObrWddFOH3HjExsSB4qX8LRBwbjrD TySw1yZ7hZd2/Jr+qguLieAOy7kKu5piNJVc01rFrgCukzgowJqDiDBBehfhCKgZlZQC MKCKGqmU6um1PgzCJ4tUzP/3mgEw10YQuP3OCV2lukR0i7iz81St2qmCnBvf+36dsPB6 ieU5pOG3KOaimSoGXP3/W8tyUE0MiJlQCq7wGUBcaJdm48+fzFNuPhOj7NQlB6ZlsoR3 MLhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Jl7NsPQO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j73si2379438pgc.566.2018.03.01.04.12.19; Thu, 01 Mar 2018 04:12:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Jl7NsPQO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030315AbeCAMLQ (ORCPT + 99 others); Thu, 1 Mar 2018 07:11:16 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:40133 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030253AbeCAMLO (ORCPT ); Thu, 1 Mar 2018 07:11:14 -0500 Received: by mail-io0-f169.google.com with SMTP id v6so6863995iog.7 for ; Thu, 01 Mar 2018 04:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=YfCpBmW1STMAOGcbjMMiTUK4pyZWgZUCkBLxYQnjXSk=; b=Jl7NsPQOacJ1YgeqDxjMS5yVRT2cq5QZX6W3ix5RIbctHihVEDmTzLh9+8OHABVOMk 9xNf0xWqoNmjtPAIwegUUIqY1LfuRx+2jCxqxzbfoRuU29rxszcBufP7Iss1eTNNFnQi 6ec7Q8D9Fhoj92g5d+Zegv1+nqIHQKxpZDWlKxQz66pvApe1iEER70t7g6TwATUJi70A /47Eo21XGcofW1co2j76FzFt+WpBVkqzFM0uM/yHJHnB6gIgVDVAcfrFFm0HOk48zEn+ d3Myv4fnQLC7XBM2ObAZYT6E+2hKx8XLoswr3T6oAS1iJSYeKPxaBGv9ACcPbTl56NVj coAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=YfCpBmW1STMAOGcbjMMiTUK4pyZWgZUCkBLxYQnjXSk=; b=nWjPRfTbaYQCENWB6i9EoDrS5JTBdWLUqYTz62eWbk3raeWtH40fboX4JAbCkR29bu OPZJAH3IimxQ7onH8a+hb6MrN+ALoc41J/XWT0j1V/MhG0zFlIiYQQLL8NKdozwCCAp+ 1JxRCGYp5Nlg5lWSDVRksKti7ArmTD5l3zBIdiWj468wdXG47NcN63E8752gzGVQOhLB G+aV2xr4WtNvpgz2tY/FpUcaFfdx3cgresij8qhVkhgWeXQxqt+knPB84ffTxA2vtaL8 GSfFXmkcCtdrucGKWPUatC/GLeA+bfnGSoqg8QH15NtcOxGDqgJdPnWgeTmTIIDhfhAh zRrw== X-Gm-Message-State: AElRT7FoD1rmfyJSAZlxIFXGdHRoKn0yvyK/vlRobZESsaR2pe5dLMit cprj8WJRdtTDDddxnQ/ts3D3LUWGU18= X-Received: by 10.107.105.2 with SMTP id e2mr1627860ioc.125.1519906274050; Thu, 01 Mar 2018 04:11:14 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id f193sm3251435ita.27.2018.03.01.04.11.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Mar 2018 04:11:13 -0800 (PST) Date: Thu, 1 Mar 2018 04:11:11 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Aaron Lu cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Huang Ying , Dave Hansen , Kemi Wang , Tim Chen , Andi Kleen , Michal Hocko , Vlastimil Babka , Mel Gorman , Matthew Wilcox Subject: Re: [PATCH v4 1/3] mm/free_pcppages_bulk: update pcp->count inside In-Reply-To: <20180301062845.26038-2-aaron.lu@intel.com> Message-ID: References: <20180301062845.26038-1-aaron.lu@intel.com> <20180301062845.26038-2-aaron.lu@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Mar 2018, Aaron Lu wrote: > Matthew Wilcox found that all callers of free_pcppages_bulk() currently > update pcp->count immediately after so it's natural to do it inside > free_pcppages_bulk(). > > No functionality or performance change is expected from this patch. > > Suggested-by: Matthew Wilcox > Signed-off-by: Aaron Lu Acked-by: David Rientjes