Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270449AbTHERDN (ORCPT ); Tue, 5 Aug 2003 13:03:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272854AbTHERDK (ORCPT ); Tue, 5 Aug 2003 13:03:10 -0400 Received: from louise.pinerecords.com ([213.168.176.16]:52387 "EHLO louise.pinerecords.com") by vger.kernel.org with ESMTP id S270449AbTHERBX (ORCPT ); Tue, 5 Aug 2003 13:01:23 -0400 Date: Tue, 5 Aug 2003 19:01:19 +0200 From: Tomas Szepe To: Patrick Mochel Cc: Ducrot Bruno , lkml Subject: Re: [TRIVIAL] sanitize power management config menus, take two Message-ID: <20030805170119.GI18982@louise.pinerecords.com> References: <20030805162604.GF18982@louise.pinerecords.com> <20030805165117.GH18982@louise.pinerecords.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030805165117.GH18982@louise.pinerecords.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7780 Lines: 224 > [szepe@pinerecords.com] > > > > > Yes, but what I do not understand is why cpufreq need power management. > > > > > > CONFIG_PM is a dummy option, it does not link any code into the kernel > > > by itself. > > > > Actually, it does: > > ... > > > > But, I agree with your change anyway. > > Trouble is, the same goes for ACPI -- it doesn't require that CONFIG_PM > code be present. > > I think the correct x86 solution would be to introduce a real dummy > option for the menus, and imply CONFIG_PM if APM or swsusp (the two > options that seem to actually need CONFIG_PM code) is enabled. Patrick, Bruno, what is your opinion on the following replacement patch? -- Tomas Szepe diff -urN a/arch/i386/Kconfig b/arch/i386/Kconfig --- a/arch/i386/Kconfig 2003-08-05 18:39:25.000000000 +0200 +++ b/arch/i386/Kconfig 2003-08-05 18:56:48.000000000 +0200 @@ -797,13 +797,13 @@ endmenu -menu "Power management options (ACPI, APM)" +menu "Power management support" depends on !X86_VOYAGER config PM - bool "Power Management support" + bool "APM and software suspend options" ---help--- - "Power Management" means that parts of your computer are shut + "Power management" provides for parts of your computer to be shut off or put into a power conserving "sleep" mode if they are not being used. There are two competing standards for doing this: APM and ACPI. If you want to use either one, say Y here and then also @@ -820,37 +820,6 @@ will issue the hlt instruction if nothing is to be done, thereby sending the processor to sleep and saving power. -config SOFTWARE_SUSPEND - bool "Software Suspend (EXPERIMENTAL)" - depends on EXPERIMENTAL && PM && SWAP - ---help--- - Enable the possibilty of suspendig machine. It doesn't need APM. - You may suspend your machine by 'swsusp' or 'shutdown -z