Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: memory-hotplug: silence test command echo
To:     Naresh Kamboju <naresh.kamboju@linaro.org>
Cc:     Shuah Khan <shuah@kernel.org>, lyang0 <lei.yang@windriver.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, linux-kernel@vger.kernel.org,
        Dan Rue <dan.rue@linaro.org>,
        Shuah Khan <shuahkh@osg.samsung.com>
References: <20180213214407.21717-1-shuahkh@osg.samsung.com>
 <CA+G9fYsE0w00aeE3jxJU3Q01Yz_C95zn+kguMHqg6M9PRmhemg@mail.gmail.com>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <7475d5ca-3fc6-260b-a1d3-60a3e1263769@osg.samsung.com>
Date:   Thu, 1 Mar 2018 07:41:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CA+G9fYsE0w00aeE3jxJU3Q01Yz_C95zn+kguMHqg6M9PRmhemg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/01/2018 02:11 AM, Naresh Kamboju wrote:
> On 14 February 2018 at 03:14, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> Silence the following command being printed while running test.
>>
>> ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" ||
>> echo "selftests: memory-hotplug [FAIL]"
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  tools/testing/selftests/memory-hotplug/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
>> index 86636d207adf..183b46883875 100644
>> --- a/tools/testing/selftests/memory-hotplug/Makefile
>> +++ b/tools/testing/selftests/memory-hotplug/Makefile
>> @@ -4,7 +4,7 @@ all:
>>  include ../lib.mk
>>
>>  TEST_PROGS := mem-on-off-test.sh
>> -override RUN_TESTS := ./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
>> +override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
>>  override EMIT_TESTS := echo "$(RUN_TESTS)"
>>
>>  run_full_test:
> 
> The test execution broken due to this patch ?

Thanks for reporting this. I will look at this. The change probably
broke the EMIT_TESTS case.

thanks,
-- Shuah