Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272899AbTHEQzc (ORCPT ); Tue, 5 Aug 2003 12:55:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272898AbTHEQxS (ORCPT ); Tue, 5 Aug 2003 12:53:18 -0400 Received: from louise.pinerecords.com ([213.168.176.16]:49827 "EHLO louise.pinerecords.com") by vger.kernel.org with ESMTP id S272869AbTHEQvW (ORCPT ); Tue, 5 Aug 2003 12:51:22 -0400 Date: Tue, 5 Aug 2003 18:51:17 +0200 From: Tomas Szepe To: Patrick Mochel Cc: Ducrot Bruno , lkml Subject: Re: [TRIVIAL] sanitize power management config menus, take two Message-ID: <20030805165117.GH18982@louise.pinerecords.com> References: <20030805162604.GF18982@louise.pinerecords.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 37 > [mochel@osdl.org] > > > > > o only enable cpufreq options if power management is selected > > > > o don't put cpufreq options in a separate submenu > > > > > > Yes, but what I do not understand is why cpufreq need power management. > > > > Because it is a power management option. :) > > > > CONFIG_PM is a dummy option, it does not link any code into the kernel > > by itself. > > Actually, it does: > > ./arch/arm/kernel/Makefile:obj-$(CONFIG_PM) += pm.o > ./arch/arm/mach-pxa/Makefile:obj-$(CONFIG_PM) += pm.o sleep.o > ./arch/arm/mach-sa1100/Makefile:obj-$(CONFIG_PM) += pm.o sleep.o > ./arch/i386/kernel/Makefile:obj-$(CONFIG_PM) += suspend.o > ./drivers/pci/Makefile:obj-$(CONFIG_PM) += power.o > ./kernel/Makefile:obj-$(CONFIG_PM) += pm.o power/ > > But, I agree with your change anyway. Trouble is, the same goes for ACPI -- it doesn't require that CONFIG_PM code be present. I think the correct x86 solution would be to introduce a real dummy option for the menus, and imply CONFIG_PM if APM or swsusp (the two options that seem to actually need CONFIG_PM code) is enabled. -- Tomas Szepe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/