Received: by 10.223.185.116 with SMTP id b49csp7817480wrg; Thu, 1 Mar 2018 11:37:54 -0800 (PST) X-Google-Smtp-Source: AG47ELs43AA0P0or8yPX/Poj0UlS9ZYoQ7eg9FnhsBmM5FP547pIrP+k90Ucmit/YHS/b9kKqkyL X-Received: by 2002:a17:902:146:: with SMTP id 64-v6mr2651908plb.30.1519933074480; Thu, 01 Mar 2018 11:37:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519933074; cv=none; d=google.com; s=arc-20160816; b=Wjw3B3E/7s2XuLlqLIpyQ5l5aYX0s8kJmOO5a5JbD3B5Khv4U+DllLqjOOHmNIeVhQ stfHrblIjIz6mVotd7EkshhoeZaE0lIUO9COM2fnl3Cx+ViKdEmd0KHYhl5Uqzbt0t7x M2hVdT7f8EnRAJwwoEsQOzTuTD6fxVd7Edi0PRmZDlUBvPWuqGFRW1uJGtjS/pnIZba7 O4jPf38LJTEFmgLtoFP8CwQXArWrlvNFkiZ5QtLQmSXYF49Gs4sVv24mVURnnrjwC6TR vA4XoY0Ep35cuAklfTUR4mP6eJxirIEdz2JdjOrpRFizt0P53OAxATkEdkMgA0Yecy5j 0ILg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:arc-authentication-results; bh=9yhr3HCQhSALObD5wluLkZ3Om5IfZ3oAA0f5TKC/Jkk=; b=zjUkYiv04UrGrheHb8Q2IZ3W04ukP+klGzw7Qj3tclZTeCQrJwzpz6OxrJ2S5dBU7K GeUSv99iadJyGcN3hKO9RBT0XAuTYk4ugt+McbWqkclJ2t09yhSWktRUwUeH3+MwlOhx RFJqHu8HRsVuMGLh+d79mteh9KhLJgasvCoZJhEVF+aJEFVTIEhQxFeE6II5DN+vLZKZ gOON4Wr68X5UgGpEdIZ6HaeZkFii01Vpb5OVY5KZ3/UY+9CXaDQl1o+Q33kshltfg1k+ hBL3X6l1RyJkgk69nJ/GSlbVfEDx1uNERd8MHIw4SJG1KCBWXIICjk0Ni2+ul4BBHtJl CP7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6-v6si3484627plf.263.2018.03.01.11.37.39; Thu, 01 Mar 2018 11:37:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161343AbeCATg5 (ORCPT + 99 others); Thu, 1 Mar 2018 14:36:57 -0500 Received: from ale.deltatee.com ([207.54.116.67]:37828 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032987AbeCATgz (ORCPT ); Thu, 1 Mar 2018 14:36:55 -0500 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1erU0R-0000LI-MJ; Thu, 01 Mar 2018 12:36:44 -0700 To: Bjorn Helgaas Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Benjamin Herrenschmidt , Alex Williamson References: <20180228234006.21093-1-logang@deltatee.com> <20180228234006.21093-4-logang@deltatee.com> <20180301174941.GG13722@bhelgaas-glaptop.roam.corp.google.com> From: Logan Gunthorpe Message-ID: <731c648d-5af3-1d5c-7169-07df12b79a41@deltatee.com> Date: Thu, 1 Mar 2018 12:36:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180301174941.GG13722@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: alex.williamson@redhat.com, benh@kernel.crashing.org, jglisse@redhat.com, dan.j.williams@intel.com, maxg@mellanox.com, jgg@mellanox.com, bhelgaas@google.com, sagi@grimberg.me, keith.busch@intel.com, axboe@kernel.dk, hch@lst.de, sbates@raithlin.com, linux-block@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, helgaas@kernel.org X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, GREYLIST_ISWHITE,T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 Subject: Re: [PATCH v2 03/10] PCI/P2PDMA: Add PCI p2pmem dma mappings to adjust the bus offset X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03/18 10:49 AM, Bjorn Helgaas wrote: >> +int pci_p2pdma_map_sg(struct device *dev, struct scatterlist *sg, int nents, >> + enum dma_data_direction dir) > > Same question as before about why the mixture of "pci_*" interfaces > that take "struct device *" parameters. In this case, per the discussion in v1, it was felt the _map_sg() function should take the same arguments as dma_map_sg(). Logan