Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S269685AbTHETgj (ORCPT ); Tue, 5 Aug 2003 15:36:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270013AbTHETgj (ORCPT ); Tue, 5 Aug 2003 15:36:39 -0400 Received: from fw.osdl.org ([65.172.181.6]:23768 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S269685AbTHETgi (ORCPT ); Tue, 5 Aug 2003 15:36:38 -0400 Date: Tue, 5 Aug 2003 12:38:11 -0700 From: Andrew Morton To: Andi Kleen Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Export touch_nmi_watchdog Message-Id: <20030805123811.1fe61585.akpm@osdl.org> In-Reply-To: <20030805192908.GA19867@averell> References: <20030805192908.GA19867@averell> X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 593 Lines: 15 Andi Kleen wrote: > > Sometimes drivers do long things with interrupt off and the NMI watchdog > triggers quickly. This mostly happens in error handling. It would be > better to fix the drivers to sleep in this case, but it's not always > possible or too much work. yup. Do we need an mdelay_while_touching_nmi_watchdog() variant? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/