Date: 5 Aug 2003 22:08:10 +0200
Date: Tue, 5 Aug 2003 22:08:10 +0200
From: Andi Kleen <ak@colin2.muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@muc.de>, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Export touch_nmi_watchdog
Message-ID: <20030805200810.GA31598@colin2.muc.de>
References: <20030805192908.GA19867@averell> <20030805123811.1fe61585.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030805123811.1fe61585.akpm@osdl.org>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1004
Lines: 25

On Tue, Aug 05, 2003 at 12:38:11PM -0700, Andrew Morton wrote:
> Andi Kleen <ak@muc.de> wrote:
> >
> > Sometimes drivers do long things with interrupt off and the NMI watchdog
> >  triggers quickly. This mostly happens in error handling. It would be 
> >  better to fix the drivers to sleep in this case, but it's not always
> >  possible or too much work.
> 
> yup.
> 
> Do we need an mdelay_while_touching_nmi_watchdog() variant?

Maybe that would be too encoraging for broken code. 

Admittedly I did that by hand for the MPT fusion driver (which currently 
triggers the watchdog when it gets into any error handling situation) 
This especially hurts on x86-64 which runs the watchdog by default. 
But it's strictly a bad hack, not a good interface.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/