Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S270682AbTHEUbp (ORCPT ); Tue, 5 Aug 2003 16:31:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S270684AbTHEUbp (ORCPT ); Tue, 5 Aug 2003 16:31:45 -0400 Received: from pix-525-pool.redhat.com ([66.187.233.200]:26338 "EHLO devserv.devel.redhat.com") by vger.kernel.org with ESMTP id S270682AbTHEUbo (ORCPT ); Tue, 5 Aug 2003 16:31:44 -0400 Date: Tue, 5 Aug 2003 20:31:37 +0000 From: Arjan van de Ven To: Linus Torvalds Cc: Arjan van de Ven , Andi Kleen , Andrew Morton , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Export touch_nmi_watchdog Message-ID: <20030805203137.E30256@devserv.devel.redhat.com> References: <1060114808.5308.9.camel@laptop.fenrus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from torvalds@osdl.org on Tue, Aug 05, 2003 at 01:25:09PM -0700 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 25 On Tue, Aug 05, 2003 at 01:25:09PM -0700, Linus Torvalds wrote: > > On 5 Aug 2003, Arjan van de Ven wrote: > > > > having a more generic/portable "trigger_watchdog" function would be > > better then, such that ALL watchdogs, and not just the NMI one can hook > > into this > > Why are we working around broken drivers? > > I say: > - either fix the driver > or > - disable the watchdog entirely. > > I don't see any point at all to touch_xxx_watchdog() from a driver. In principle you are soooo right. Just that it sometimes is HARD to fix such long delays... I remember working on the qla2x00 driver to fix that ;( Ok "it's hard" is no excuse. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/