Received: by 10.223.185.116 with SMTP id b49csp8148683wrg; Thu, 1 Mar 2018 18:37:13 -0800 (PST) X-Google-Smtp-Source: AG47ELsXkzskImwDZSVmZvxx0JPvJqTp5gil7qQV69gb1Q612DHdvMmaqIaGUCWc37S+E4rQaSby X-Received: by 10.98.155.194 with SMTP id e63mr4042194pfk.95.1519958233109; Thu, 01 Mar 2018 18:37:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519958233; cv=none; d=google.com; s=arc-20160816; b=XxsfIUSs0fA+aqlb8q6v996dUFXRPlfTY83iyrGhTw6SFSWcZFLUq6TOpf0Am5R60H lFCj9WDewBEYTBFW8NIyAkzKzVyfk0CojpQxFW4F29h9C2IMLMrdxb1E9YDejc6BKb5D cBLQBvXzE4lRnKcF1uu4Pr7hRfcq1ur+H6xvpbCS0ZHjp/56N/6/WALmvZxyOCtpgw3b nfBFv4nrX+HQlClYhMzTSxui/WNz1CBPqOUZVWcZylIO1hEMv8TkYpEh4VEQMrwmpGks 4VPbq336B1F2T14F8Hx+r+e6cRe2dJQ4SEfSXR8rNC+Yihij1DftfZqZvM1KBq1qt0ph dgSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=8xXtmcPlsmY8weCo4H1kKLxqlILsnpYOzb+SldcSrPc=; b=gT4IsQxPY9sujQevUYIYOCJcBrlrLFuX0mRtzrgxnrQJa7NgTl3jHF6k2ItzEZp4GH XHGuxB5sT9Fm8OC3w/PrHB454iMiKe0MeHUtuJYdhatbwONw7Z+VUzEYbf6hPFL0jES3 TCvzUJJ4MWZEv3NmfpYuJXDY4P9yf0P1yhhUqrnBQ9uMMQYRpHOYgekIBw8oXNiqNlQ2 9Bf83vNdsjHaS8oqo9dkpmZIZwDecKL18ngFThPf6RqIG6uuDjf4jUXuhpPd0L8A6Bse X+UBKG1UADVK/02P1q9xx7dTCq8JfGY0wUr/wRuE3hKldpj2MN3N65E1rbly11+UpGvg 229g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b17-v6si599788plz.703.2018.03.01.18.36.58; Thu, 01 Mar 2018 18:37:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164385AbeCBCcP (ORCPT + 99 others); Thu, 1 Mar 2018 21:32:15 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57360 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1164179AbeCBCcN (ORCPT ); Thu, 1 Mar 2018 21:32:13 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4016C40FB659; Fri, 2 Mar 2018 02:32:13 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-90.pek2.redhat.com [10.72.12.90]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 597A02026E0E; Fri, 2 Mar 2018 02:32:08 +0000 (UTC) Date: Fri, 2 Mar 2018 10:32:04 +0800 From: Dave Young To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, bhe@redhat.com, slp@redhat.com, mst@redhat.com, somlo@cmu.edu, xiaolong.ye@intel.com, Andrew Morton , Hari Bathini , Tony Luck , Vivek Goyal Subject: Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note() Message-ID: <20180302023204.GA2818@dhcp-128-65.nay.redhat.com> References: <20180228150615.17317-1-marcandre.lureau@redhat.com> <20180228150615.17317-10-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180228150615.17317-10-marcandre.lureau@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 02 Mar 2018 02:32:13 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 02 Mar 2018 02:32:13 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dyoung@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 02/28/18 at 04:06pm, Marc-Andr? Lureau wrote: > The following patch is going to use the symbol from the fw_cfg module, > to call the function and write the note location details in the > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. > > CC: Andrew Morton > CC: Baoquan He > CC: Dave Young > CC: Dave Young Above duplicated a CC, btw, I remember both Baoquan and me acked it before, you can find the old email and carry the acked-by. > CC: Hari Bathini > CC: Tony Luck > CC: Vivek Goyal > Signed-off-by: Marc-Andr? Lureau > Acked-by: Gabriel Somlo > --- > kernel/crash_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > index 4f63597c824d..a93590cdd9e1 100644 > --- a/kernel/crash_core.c > +++ b/kernel/crash_core.c > @@ -376,6 +376,7 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > { > return __pa(vmcoreinfo_note); > } > +EXPORT_SYMBOL(paddr_vmcoreinfo_note); > > static int __init crash_save_vmcoreinfo_init(void) > { > -- > 2.16.1.73.g5832b7e9f2 > Thanks Dave