Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Bogdan Purcareata <bogdan.purcareata@nxp.com>
To:     Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
CC:     "stuyoder@gmail.com" <stuyoder@gmail.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        Nipun Gupta <nipun.gupta@nxp.com>,
        Roy Pledge <roy.pledge@nxp.com>,
        =?iso-8859-2?Q?Horia_Geant=E3?= <horia.geanta@nxp.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
Thread-Topic: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
Thread-Index: AQHTsYVts6v1kMgvV0a/7f34+gySWaO8q6SAgAAKSEA=
Date:   Fri, 2 Mar 2018 09:55:43 +0000
Message-ID: <AM0PR0402MB364957B0E5A21228C1D8BD1DEAC50@AM0PR0402MB3649.eurprd04.prod.outlook.com>
References: <20180301174712.2660-1-bogdan.purcareata@nxp.com>
 <20180301174712.2660-3-bogdan.purcareata@nxp.com> <5A9916C0.6090804@nxp.com>
In-Reply-To: <5A9916C0.6090804@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 638cf9d6-5085-4bda-819d-08d58023c3a9
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2018 09:55:43.6732
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3570
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Laurentiu Tudor
> Sent: Friday, March 02, 2018 11:18 AM
> To: Bogdan Purcareata <bogdan.purcareata@nxp.com>; gregkh@linuxfoundation=
.org;
> Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Cc: stuyoder@gmail.com; Ioana Ciornei <ioana.ciornei@nxp.com>; Nipun Gupt=
a
> <nipun.gupta@nxp.com>; Roy Pledge <roy.pledge@nxp.com>; Horia Geant=E3
> <horia.geanta@nxp.com>; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH 2/3] staging: fsl-mc: Move DPBP out of staging
>=20
> Hi Bogdan,
>=20
> On 03/01/2018 07:47 PM, Bogdan Purcareata wrote:
> > Move the source files out of staging into their final locations:
> > - dpbp.c goes to drivers/bus/fsl-mc/, next to the core infrastructure
> > - dpbp-cmd.h gets merged into drivers/bus/fsl-mc/fsl-mc-private.h, next
> >    to the other internally used APIs
> > - dpbp.h gets merged into include/linux/fsl/mc.h, exposing the public
> >    API
> >
> > Update references in the dpaa2-eth staging driver.
> >
> > DPBP stands for Data Path Buffer Pool - you can read more about the
> > object in Documentation/networking/dpaa2/overview.rst
> >
> > Signed-off-by: Bogdan Purcareata <bogdan.purcareata@nxp.com>
> > ---
> >   drivers/bus/fsl-mc/Makefile                       |  1 +
> >   drivers/{staging/fsl-mc/bus =3D> bus/fsl-mc}/dpbp.c |  4 +-
> >   drivers/bus/fsl-mc/fsl-mc-private.h               | 39 ++++++++++++++=
+++
> >   drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h    |  2 +-
> >   drivers/staging/fsl-mc/bus/Makefile               |  3 +-
> >   drivers/staging/fsl-mc/bus/dpbp-cmd.h             | 44 --------------=
-----
> >   drivers/staging/fsl-mc/include/dpbp.h             | 53 --------------=
------
> ---
> >   include/linux/fsl/mc.h                            | 42 ++++++++++++++=
++++
> >   8 files changed, 86 insertions(+), 102 deletions(-)
> >   rename drivers/{staging/fsl-mc/bus =3D> bus/fsl-mc}/dpbp.c (98%)
> >   delete mode 100644 drivers/staging/fsl-mc/bus/dpbp-cmd.h
> >   delete mode 100644 drivers/staging/fsl-mc/include/dpbp.h
> >
> > diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
> > index 6a97f2c..da26e52 100644
> > --- a/drivers/bus/fsl-mc/Makefile
> > +++ b/drivers/bus/fsl-mc/Makefile
> > @@ -9,6 +9,7 @@ obj-$(CONFIG_FSL_MC_BUS) +=3D mc-bus-driver.o
> >   mc-bus-driver-objs :=3D fsl-mc-bus.o \
> >   		      mc-sys.o \
> >   		      mc-io.o \
> > +		      dpbp.o \
> >   		      dprc.o \
> >   		      dprc-driver.o \
> >   		      fsl-mc-allocator.o \
> > diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/bus/fsl-mc/dpb=
p.c
> > similarity index 98%
> > rename from drivers/staging/fsl-mc/bus/dpbp.c
> > rename to drivers/bus/fsl-mc/dpbp.c
> > index 85735bb..31a360b 100644
> > --- a/drivers/staging/fsl-mc/bus/dpbp.c
> > +++ b/drivers/bus/fsl-mc/dpbp.c
> > @@ -5,9 +5,9 @@
> >    */
> >   #include <linux/kernel.h>
> >   #include <linux/fsl/mc.h>
> > -#include "../include/dpbp.h"
> > +#include "linux/fsl/mc.h"
>=20
> I think we can use <> here, same comment for patch 3/3.
>=20
> Other than that, the series looks ok to me so for all the patches:
>=20
> Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Thank you!
I will update the patchset - seeing that the cleanup one has already been a=
pplied - and will send a v2 shortly.

Best regards,
Bogdan