Received: by 10.223.185.116 with SMTP id b49csp8741114wrg; Fri, 2 Mar 2018 07:11:02 -0800 (PST) X-Google-Smtp-Source: AG47ELtCAU/sffhxDmbG6vb3BRR9WQVn2THaWXKYE+JypTBTZxYzGJOWT22NErMWAip/ooZGsWMr X-Received: by 2002:a17:902:780c:: with SMTP id p12-v6mr5637038pll.161.1520003462400; Fri, 02 Mar 2018 07:11:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520003462; cv=none; d=google.com; s=arc-20160816; b=AWV1HDBDmrcig6evSrMTjYe7HXcMAfs+fFOYM/US5goflPSiVVETCebF7nxo4qyUjc VrzJjDVLgAD+dEf9FHWwfXNg2GJ43AAekdZpitY11InMqiBFTWsD63ztap+mvOh1pRFC KWPxy4qIwjW5W3+eNf6jCvHYdXjSAwbWTwxLA3ziz3H5/3fAXVQS6UZ3MeqGRNbY6A3t Zfqc+JzAanvrumM/wFT7Yy8v9PLNicEVhN89kKJcG8l69dYkuwfKB9cMhPmytGFjSeEx GvLJVbfvQr++bZrIXx9oSOioBj2/CYuYpuGpEVO0EC7/2S6dpVPzz4i7UiOimvw66mXC q/6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=w5MmyqeOaNVWMOt4/Ex7hMUIOAlyd7XLuB7XXpYENCk=; b=ZmPF2hnxNLUI/d10srCJkzxdT5EnqbPbReMklPo/5Rod9RJ06A5u/rLSqDhmLMlSH9 /vmy1/iWZmK6k7gYR0HsoR8jpexCqkvD/7bXDIO8c8LwM1Oo9Ridqd6oc8ijBvFbmtWa 9+o6GqEjrj6PN5wC9M0WwjYiY8nKSNgPwkKWB1DACeVBMObC+75QjQsbgEh1AzYS45u+ u1dtgns5DP+lWe+uxQs6V+9IELTeucS2cXTgHn3kninzeCIJ2W7VafMhk4M52pet52VJ Yfvo5y7Uj9Vftpc3kCtf/NJt6E12zTNxyFSriANP51Ljt0y0O6XcWqjeTZFsKaZX/8lx jHQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=G0O2eYMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r62si4150660pgr.77.2018.03.02.07.10.47; Fri, 02 Mar 2018 07:11:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=G0O2eYMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936231AbeCBLmV (ORCPT + 99 others); Fri, 2 Mar 2018 06:42:21 -0500 Received: from mail.micronovasrl.com ([212.103.203.10]:48984 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934881AbeCBLmP (ORCPT ); Fri, 2 Mar 2018 06:42:15 -0500 Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id 49126B00ABC for ; Fri, 2 Mar 2018 12:42:14 +0100 (CET) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:to:subject:subject; s=dkim; t= 1519990933; x=1520854934; bh=hb8t1Kx6NOKwxo/gbd2jac2jg5djFO/YVWs BF7kmlRc=; b=G0O2eYMwTitLEnr3nHlPcWEQNCP0825BOSmrv6b/u/Bx6ioedYy 2yMuLhMeRMNvTxXz16jFx/OarTX+7q7xWqmIl1gVSn2FbAoXOUXsCFL0Ss5UCUc9 f37YucYantPxF/+CPPOx5S+/703quBbWCM6kHHNvQeQ6sdYd6WIZVAfo= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9] autolearn=unavailable autolearn_force=no Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 15xrkmPsVM1b for ; Fri, 2 Mar 2018 12:42:13 +0100 (CET) Received: from [192.168.2.69] (62-11-51-166.dialup.tiscali.it [62.11.51.166]) by mail.micronovasrl.com (Postfix) with ESMTPSA id F0E67B0034C; Fri, 2 Mar 2018 12:42:12 +0100 (CET) Subject: Re: [PATCH 2/2] drm/sun4i: add lvds mode_valid function To: Maxime Ripard Cc: David Airlie , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1519840432-61489-1-git-send-email-giulio.benetti@micronovasrl.com> <1519840432-61489-2-git-send-email-giulio.benetti@micronovasrl.com> <20180301095721.4iga7dcgg566j44m@flea> From: Giulio Benetti Message-ID: Date: Fri, 2 Mar 2018 12:42:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180301095721.4iga7dcgg566j44m@flea> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: it Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Il 01/03/2018 10:57, Maxime Ripard ha scritto: > On Wed, Feb 28, 2018 at 06:53:52PM +0100, Giulio Benetti wrote: >> static struct drm_connector_helper_funcs sun4i_lvds_con_helper_funcs = { >> .get_modes = sun4i_lvds_get_modes, >> + .mode_valid = sun4i_lvds_mode_valid, >> }; > > This should be on the encoder, not the connector. I've seen it is bound to connector in rgb and to encoder in hdmi. Is it correct rgb mode_valid under connector funcs? Otherwise I send a patch also for that one. > > Maxime > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642