Received: by 10.223.185.116 with SMTP id b49csp8776497wrg; Fri, 2 Mar 2018 07:47:37 -0800 (PST) X-Google-Smtp-Source: AG47ELvj3gT/mNxg0ro2J1rGs/NuBdZ3RaSMi0x1HP5bLmIy59beS51XAGgmek+S/Aw+7Rvcy+Fn X-Received: by 10.99.147.91 with SMTP id w27mr4969134pgm.208.1520005657179; Fri, 02 Mar 2018 07:47:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520005657; cv=none; d=google.com; s=arc-20160816; b=B3SQFXFbd13Jag7ML4+901CXfN749jsPSRXLhkvXC2yqIkVC90ubl7sduQ4yz0OexO A50COIo/tZr0p0YTNFnHm+bwuBhicAZXCfxpjTLSYm0YbR59jRtej9h1ArTQpE7Xuw2i iJtacQE9uc2HofX5q+Sd6+jY+Sr8cnva+TRNsd02GIJ5J4eLDIXr4WLeJ1CIKi3W4U1C fbbm+PFW3hBhKzMrt+SkPoAf5aBoufY4nNgHDyw82QWrdK2uQZn2nllO8anounxGhxn9 6WYHBwxnLsvuVUMYCis/WujyCatkzRM69bG6df+jd7mCs9CyB24s5+JSZpRFz98ITzNl J2lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=V+osiN+6ZU1jmhYsCGSRwIj3EFDU3Pi9tS6ZojeSb2g=; b=FsSEGzgPyVMmPvFWCiqRmd/kgTYYRR8O2XjIhauOKVyG0TKF+7W0hlbeck8FXTIcBn EpNpNGm9JlU2hrxKWuUO5PAGkf6pcQxLJnH4iJtP4YRry9kPuo4vyfel3U4Isx4rNd/z XlVmLDC1s4v3M/2c/FfffSYuAlblZnxDqn5s9q9Ph6dkUZIKA7QSDx81dqVfCwuvBOgQ pWanFCzUtL7MdLWJ09VqhVxIB+AJAqIdJ7NQeuJr+a6Bxj8hNgYZmB5j7nWqVwKDh720 z+76cIiGbv3a9OUQtwbNvybdRbG5AoZ0tbNWyWdnOzYBEZ70JeO6gHCvf8Ej1nrqMYo1 W7yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 94-v6si4949682pla.215.2018.03.02.07.47.22; Fri, 02 Mar 2018 07:47:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428427AbeCBOAx (ORCPT + 99 others); Fri, 2 Mar 2018 09:00:53 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:45475 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424382AbeCBOAw (ORCPT ); Fri, 2 Mar 2018 09:00:52 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1erlEw-0004sO-Nv; Fri, 02 Mar 2018 15:00:50 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1erlEw-0003HJ-31; Fri, 02 Mar 2018 15:00:50 +0100 Date: Fri, 2 Mar 2018 15:00:50 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Greg Kroah-Hartman Cc: Gavin Schenk , kernel@pengutronix.de, linux-kernel@vger.kernel.org, dcb314@hotmail.com Subject: Re: [PATCH] siox: fix possible buffer overflow in device_add_store Message-ID: <20180302140050.eawswobo3fpkj52i@pengutronix.de> References: <20180214142502.20787-1-g.schenk@eckelmann.de> <20180214170021.pf2di46t2ggfepim@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180214170021.pf2di46t2ggfepim@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg, On Wed, Feb 14, 2018 at 06:00:21PM +0100, Uwe Kleine-K?nig wrote: > On Wed, Feb 14, 2018 at 03:25:02PM +0100, Gavin Schenk wrote: > > Width 20 given in format string is larger than destination > > buffer 'type[20]', use %19s to prevent overflowing it. > > > > Fixes: bbecb07fa0af ("siox: new driver framework for eckelmann SIOX") > > Reported-by: David Binderman > > Signed-off-by: Gavin Schenk > Reviewed-by: Uwe Kleine-K?nig is this patch still in your patch queue? The patch didn't appear in next yet. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |