Received: by 10.223.185.116 with SMTP id b49csp8880765wrg; Fri, 2 Mar 2018 09:28:12 -0800 (PST) X-Google-Smtp-Source: AG47ELsmsDLjFNMgGSZiwGktFtn4nxgYd3e68+N3vr0+ZX1Q3/2bC1DqEBRMGKvasIuk1ICCa73M X-Received: by 2002:a17:902:407:: with SMTP id 7-v6mr5930439ple.9.1520011692781; Fri, 02 Mar 2018 09:28:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520011692; cv=none; d=google.com; s=arc-20160816; b=rv3KMFC35KPhNU0V+krEU3Sb4wfdZ2DZOvNgOtaAk7WF6JmruXweRcYmbDEFttT0yU TWOv2D3T5hxyZqW+K/4jh3TP/4eTiF8iZlgl//cA3T2Of5jRqtB6D1MIS+We4DZHC+Qx TG0XGugLFuPXjvx505FTnrh+/Lzw0w5BTJTLNeCbUWe+XJp/8Om5nLnLglBNaymLpmSS vnGeqnrxZDcNB37xzGr+f7OWPuZ7Afs1GDN9N5IhZmAW3ETPSkQcVsV4J5UlxnCVWw1q r7RethAUIuEGcozU8EuHyY1CYZos0rOuCz3MlnPeBDsHVKUcWjHbabrabBPoBZIv9EOJ 3ANA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=ra89XFY1t5zwzZttMfACNQvfFf1khcxtTOdZ+3TAk8o=; b=RX1U8GlRyGHcuoiBSsa7MlBVZbJnPIJyRM8FHVJX86zrRdzCTApuCe3KBLxGhDc978 6ejdE1V69UOK7UsdIYCzXf+mKCFZil/98DmImJvgTdkM3lrY2x1Z8HXIeWYAQCb0V3k+ +lEnWMvrgCWnpR+aht7QAT9x+6dwK/scVGv41oenTgXPiLKeoWQ4eDdqvq4JBO9vKMvS iWucrg3vn8FLIsMwRMrRFY4i7rRA/h1e2nbYUv1BL+gYmcLt3li+jtCGTvoSdExG7Mfp 4n5I/yeIW4U5BsfdsXUA7H7a0x1A9I0EYAgdAuTHcGU6dvk3Wnrd0QbE1Lj5RlzhDbUg ttPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f89si5211373pfe.185.2018.03.02.09.27.56; Fri, 02 Mar 2018 09:28:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425951AbeCBJsm (ORCPT + 99 others); Fri, 2 Mar 2018 04:48:42 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:55277 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424764AbeCBJsO (ORCPT ); Fri, 2 Mar 2018 04:48:14 -0500 Received: from tarshish.tkos.co.il (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPSA id 37C88440475; Fri, 2 Mar 2018 11:48:10 +0200 (IST) From: Baruch Siach To: Linus Walleij Cc: Stefan Wahren , Dave Stevenson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Baruch Siach , Arnd Bergmann Subject: [PATCH] gpio: raspberrypi-exp: explain Kconfig dependency Date: Fri, 2 Mar 2018 11:47:01 +0200 Message-Id: <3c3b8755d186b1f762081ee18efb718886814e51.1519984021.git.baruch@tkos.co.il> X-Mailer: git-send-email 2.16.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 7ed915059c3001 (gpio: raspberrypi-ext: fix firmware dependency) fixed the Kconfig dependency to ensure that gpio-raspberrypi-exp is not built-in when the firmware is a module. But the Kconfig syntax for doing so is cryptic. Add a comment to make it a little easier. Cc: Arnd Bergmann Signed-off-by: Baruch Siach --- drivers/gpio/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 52a8b0a6f4e1..1bb25c1ff2d8 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -126,6 +126,8 @@ config GPIO_RASPBERRYPI_EXP tristate "Raspberry Pi 3 GPIO Expander" default RASPBERRYPI_FIRMWARE depends on OF_GPIO + # Make sure not 'y' when RASPBERRYPI_FIRMWARE is 'm'. This can only + # happen when COMPILE_TEST=y, hence the added !RASPBERRYPI_FIRMWARE. depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE) help Turn on GPIO support for the expander on Raspberry Pi 3 boards, using -- 2.16.1