Received: by 10.223.185.116 with SMTP id b49csp8945653wrg; Fri, 2 Mar 2018 10:36:18 -0800 (PST) X-Google-Smtp-Source: AG47ELvsjqy1SVnTZ6T75PnWpCjoze1kvMi+D6dIesoqxJnC1BLghf3O1zZITlhDnOfgFIRWU7H7 X-Received: by 10.98.133.86 with SMTP id u83mr6590610pfd.172.1520015778193; Fri, 02 Mar 2018 10:36:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520015778; cv=none; d=google.com; s=arc-20160816; b=UkB4m19UhZc8z6VaeLG54qrA3GzpjGPPB80mIiCXCruibURBX8NtBVQLZDu9THiS+h NUE3ywygqskKkoxOLsqQ8oanfNs99FoOvRsrYoF1iRnFcoBdzj8jLI9+EYV9+bi3E4DF HM36aJnYbVbPuly0MXNCTq7rAtjugkCaqtIS2J0X2DSmGrDJoe12ubxoVAbTaM4uZFyk pyln5rxG4zTfU6kr8/D2mCHtl7dt4xLnm7G1UGsw+4z2MaLvZ29ruw4KDrh+tz8ABuEg zaex2Oe5Ue49CrzDMd14fA+dlP3uhAZA7OeICEb3MO0b3fm58tdLLfSjPNXk8ZhJYyFo DAdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=9QD1RyfcwmWMrJnfDUBN/xtbxb7WORAFjlxPmwNEWWA=; b=CoXsUkY1moxNGznXuGtBCWX8TieMcgvKQNS69yx2D7BL/URz0rv/BZSTc8ebPskIRo F30pFqkMxH271tWfP+b2aKDTccHfi/D928DmcGYLRmktvUpOcatOmBY/O/xBx9R5D2fm 5nnlPS2VAKJZR8B/npC8vMW+f8RjzoRaSNnWHE7HlqQrAKmCpsifDUmDUUj+wOpn+17Z WqLxb850S5NIiZz+pswAG5NfD1x16nRFxVck8gPOhPrw8qDxuTKl/FkACc8D8I0g3r7O S309Fp+QRySfp97ULOGCyG4sAuUGViLbDuam7Up4VmXHqjqwTf5VSC9KaT7eGZT107sD 7axA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f34-v6si5210451ple.330.2018.03.02.10.36.02; Fri, 02 Mar 2018 10:36:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936291AbeCBL6S (ORCPT + 99 others); Fri, 2 Mar 2018 06:58:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:44310 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934881AbeCBL6P (ORCPT ); Fri, 2 Mar 2018 06:58:15 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0EAF1B427; Fri, 2 Mar 2018 11:58:14 +0000 (UTC) Date: Fri, 2 Mar 2018 12:58:13 +0100 From: Petr Mladek To: Joe Lawrence Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Jiri Kosina , Miroslav Benes , Jason Baron , Evgenii Shatokhin Subject: Re: [PATCH v0 3/3] livepatch: update documentation for shadow variables Message-ID: <20180302115813.gjn7k67dkfe4szzj@pathway.suse.cz> References: <1519421630-12025-1-git-send-email-joe.lawrence@redhat.com> <1519421630-12025-4-git-send-email-joe.lawrence@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1519421630-12025-4-git-send-email-joe.lawrence@redhat.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2018-02-23 16:33:50, Joe Lawrence wrote: > Update livepatch shadow variable documentation with respect to new > atomic replace / cumulative patch functionality. > > Signed-off-by: Joe Lawrence > --- > Documentation/livepatch/shadow-vars.txt | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/livepatch/shadow-vars.txt b/Documentation/livepatch/shadow-vars.txt > index 89c66634d600..9a2754cf551c 100644 > --- a/Documentation/livepatch/shadow-vars.txt > +++ b/Documentation/livepatch/shadow-vars.txt > @@ -179,6 +179,30 @@ doesn't matter what data value the shadow variable holds, its existence > suggests how to handle the parent object. > > > +Use in cumulative patches > +------------------------- > + > +Cumulative livepatches provide a "one-stop" module containing all active > +livepatch code. I would remove the above sentence. I had troubles to parse and understand it. I think that the sentence below is better descriptive and enough :-) + A cumulative patch disables and replaces any previously > +loaded livepatch. Shadow variable lifetimes should be carefully > +considered when loading cumulative livepatches: > + > +- If shadow variables lifetimes are specific to livepatch module > + versions, it may make sense to free them when the corresponding > + livepatch module is unloaded. > + > +- If shadow variable instances may be safely handled across cumulative > + livepatch module versions, then it may make sense to free them from > + unpatch callbacks. When a cumulative patch replaces an existing > + livepatch, only the cumulative patch's callbacks will be executed. > + This means that new cumulative livepatches may be loaded while > + deprecated / disabled livepatches may be unloaded without clearing > + existing shadow variables. > + > +See Documentation/livepatch/callbacks.txt and cumulative.txt for more s/cumulative.txt/cumulative-patches.txt/ Best Regards, Petr