Received: by 10.223.185.116 with SMTP id b49csp22607wrg; Fri, 2 Mar 2018 12:54:02 -0800 (PST) X-Google-Smtp-Source: AG47ELsACCoSxWTZmGJKtepT5TeUvQRcng99QPRPO9lcIotmIjsyh+oGsweZoHlmWDBqTkoHqzV0 X-Received: by 10.99.125.29 with SMTP id y29mr5518733pgc.277.1520024042157; Fri, 02 Mar 2018 12:54:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520024042; cv=none; d=google.com; s=arc-20160816; b=pQdOBr2dzvm/9y0pw6e4HejnK6qjF1KkUIr+anHsg/y2H+t3/dQi1OlM2IRSxDtyqS T7jDaA7HBghpOtHY+agKDXKT1oUqUb+yFcKy9MFAE90aZ5DkBOpcS77+7yKdGKtcSAU7 MumAJNRi61aeesJEnf1R+4gRolNxo4siyKRR8DM/s154LznYJ+Q3CxJ3HHvL5CK2zy5e X77ewZz7Hmxfu83P+QJZK3iwWCIaR4X4kpSItX/i5f29IVSwQZZ68fJaOuuMvgvsu1BQ 8eCbfT2NUx7Ka8zYRYchAuwQB+/EIfj7n687spbAkV4r+ikNCvFe/2h3fbpBtjAPU4cL MphQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=+d/IUOS5ncnQ9RcK03ysGUp60aEjg2tuKPoEM5qelqU=; b=tDCfF8A30ONaVCuZG1AUs+k5pSwwsi7VUpKMiftAL7ukGwKkRfxgS+gynomwvsuSZN hwSX5FV3n7R/LYXsgyY5NYYLYGdkFunzOH3l84gRhj3kUmvIhfi2tr53FFwxCIBJ4BUs TMUz3Z/19nIoQ3irPpQBLgRCQOO5id1/7YiFqEwHGHNbwBrHIcz3H6HHx0JvcNT6wMlH mMHSSRv7qyf0lnjfgCicsT8jcFC2dtTeYRaVdgE6HUFUel9GRQjfYjqvQpG1MoNAVcvp QBOXxHsKXbDiuI2MMhvAiNh34OJ+HRXeNSA4ARm772sPH0Zh96y4M34X0+wnGSUFU6xX 8yrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b14si4452752pgu.764.2018.03.02.12.53.47; Fri, 02 Mar 2018 12:54:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428307AbeCBSDi (ORCPT + 99 others); Fri, 2 Mar 2018 13:03:38 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:51880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1426543AbeCBSDf (ORCPT ); Fri, 2 Mar 2018 13:03:35 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 644884022909; Fri, 2 Mar 2018 18:03:35 +0000 (UTC) Received: from redhat.com (ovpn-126-204.rdu2.redhat.com [10.10.126.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8FC810A85AC; Fri, 2 Mar 2018 18:03:28 +0000 (UTC) Date: Fri, 2 Mar 2018 20:03:18 +0200 From: "Michael S. Tsirkin" To: Dave Young Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , linux-kernel@vger.kernel.org, arnd@arndb.de, bhe@redhat.com, slp@redhat.com, somlo@cmu.edu, xiaolong.ye@intel.com, Andrew Morton , Hari Bathini , Tony Luck , Vivek Goyal Subject: Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note() Message-ID: <20180302200241-mutt-send-email-mst@kernel.org> References: <20180228150615.17317-1-marcandre.lureau@redhat.com> <20180228150615.17317-10-marcandre.lureau@redhat.com> <20180302023204.GA2818@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180302023204.GA2818@dhcp-128-65.nay.redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 02 Mar 2018 18:03:35 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 02 Mar 2018 18:03:35 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 02, 2018 at 10:32:04AM +0800, Dave Young wrote: > Hi > > On 02/28/18 at 04:06pm, Marc-Andr? Lureau wrote: > > The following patch is going to use the symbol from the fw_cfg module, > > to call the function and write the note location details in the > > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. > > > > CC: Andrew Morton > > CC: Baoquan He > > CC: Dave Young > > CC: Dave Young > > Above duplicated a CC, btw, I remember both Baoquan and me acked it > before, you can find the old email and carry the acked-by. I fixed it but all this is submitter's job really. > > CC: Hari Bathini > > CC: Tony Luck > > CC: Vivek Goyal > > Signed-off-by: Marc-Andr? Lureau > > Acked-by: Gabriel Somlo > > --- > > kernel/crash_core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > index 4f63597c824d..a93590cdd9e1 100644 > > --- a/kernel/crash_core.c > > +++ b/kernel/crash_core.c > > @@ -376,6 +376,7 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void) > > { > > return __pa(vmcoreinfo_note); > > } > > +EXPORT_SYMBOL(paddr_vmcoreinfo_note); > > > > static int __init crash_save_vmcoreinfo_init(void) > > { > > -- > > 2.16.1.73.g5832b7e9f2 > > > > Thanks > Dave