Received: by 10.223.185.116 with SMTP id b49csp86986wrg; Fri, 2 Mar 2018 14:11:42 -0800 (PST) X-Google-Smtp-Source: AG47ELu9G21Jh9jwP03DinTMvI7HPEI5qjIdr3x0lx18dzi4UeUZWUR1/SSlaLd/XhgquYxD518G X-Received: by 10.98.204.69 with SMTP id a66mr7066957pfg.33.1520028702462; Fri, 02 Mar 2018 14:11:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520028702; cv=none; d=google.com; s=arc-20160816; b=rYi5v6Xm6SJrdfTI/G1tLzZT0rR2SQ7cB+XjuihLN5dRKl+QvHUkYfKhHmk90TdjbZ 6ZwVXV2vYU9D9ebI6oqxzRQ2dmMvchC5J1Ca9sKDnFxV8I1Rjp0Ivaifd0y/4Iw14vCj 4T/dWrlkm8LvcXK/0VfZgEGntbB55ZIRa/ijwYoWLmHCFmh9qkckIwb0su6fCPMBMJJY KteCNwg5Rx3MKiMRMrsVnY9DCCHDms9oFfKqJflbc37V7X5kJsKt5ClapUWM+He6cs6m eAr7zHtpIs5AoP31ZttXJL49BU6Jt1TMF7zt2+0nKo4Uha6I8+XnfrmFrLvVYAdgMWWD AgFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=9seRztCCfsHeYER0JCTtIDKZxipylzFoppjxiXn4vxE=; b=1Lf2hWZ4KZoINv6beeqouUG2OaC6svGlkzfnXK6weYJ4KKmw8ZL3HwVVB8SasLMZfW nJ/laWPOwFUDqAD0WYYjT5pgeWiWkBZOQWxIgvx9pFHnOyvcrqslnLHv+8EN/vpRv0CC CIBpxwEM8C6CpO8Z5X3QC83xh2fn5XL39xa8HZM5O9ukuwho3y9u+y2Pdhu58HH3TkxU pOiRLR2ZmQq23u7bsvF+QkEEL3TZOd0PIVoo3XKpacfx5OkUVuv8cgjGPsA6LuV+bgfp +FQHhVzm9L2ICjUasqIOzgc1V+qqTJGta50hojhr0feQt4Kn5f0jXZlFDpn9bkH3Z9uD 9jXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14si4518421pgu.341.2018.03.02.14.11.27; Fri, 02 Mar 2018 14:11:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbeCBWIH (ORCPT + 99 others); Fri, 2 Mar 2018 17:08:07 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751605AbeCBWIG (ORCPT ); Fri, 2 Mar 2018 17:08:06 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BAEC68D6EF; Fri, 2 Mar 2018 22:08:05 +0000 (UTC) Received: from jlaw-desktop.bos.csb (dhcp-17-208.bos.redhat.com [10.18.17.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 708191006EA1; Fri, 2 Mar 2018 22:08:05 +0000 (UTC) Subject: Re: [PATCH v0 2/3] livepatch: update documentation/samples for callbacks To: Petr Mladek Cc: Miroslav Benes , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Josh Poimboeuf , Jessica Yu , Jiri Kosina , Jason Baron , Evgenii Shatokhin References: <1519421630-12025-1-git-send-email-joe.lawrence@redhat.com> <1519421630-12025-3-git-send-email-joe.lawrence@redhat.com> <20180302111111.f6tt2rnwa4nnbswh@pathway.suse.cz> From: Joe Lawrence Organization: Red Hat Message-ID: <069122bb-15e6-61f6-e98c-07b356a12942@redhat.com> Date: Fri, 2 Mar 2018 17:08:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180302111111.f6tt2rnwa4nnbswh@pathway.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 02 Mar 2018 22:08:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 02 Mar 2018 22:08:05 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'joe.lawrence@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2018 06:11 AM, Petr Mladek wrote: > On Tue 2018-02-27 09:58:40, Joe Lawrence wrote: >> In my mind, atomic replace is the mechanism that forces patching to be >> cumulative. Perhaps this is too strict? Are there other use-cases for >> atomic-replace? > > Jason talked about using the atomic replace to get rid of any > existing livepatches and adding another changes instead. The changes > in the old and the new patch might be unrelated. They simply do > not want to mind what was there before. The term "atomic replace" > fits perfectly for this usecase. > > My understanding is that cumulative patches do similar thing. > But the old and new patches should be related. In particular, > any new patch should include most changes from the older one. > The only exception is when an old change was wrong and we do > not want it anymore. Yes, I can see the semantic difference between these cases. In my mind, I am tainted by an understanding of the implementation... so I lazily optimized both cases under a common terminology. That said, you're right about potential confusion, so I'll update the example and docs to remove references to "cumulative" and just call it "atomic-replace" :) > PS: I did not added these patches to v9 of the atomic replace > patchset. It was already big enough. And I hope that v9 might > be final. In addition, there are no conflicts on the touched > files side. I can continue to update as a separate patchset if that helps the the other patchset reach a quicker conclusion. As far as licensing, I don't mind modifying for SPDX tags if that's the way we want to go. Thanks, -- Joe