Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180302200241-mutt-send-email-mst@kernel.org>
References: <20180228150615.17317-1-marcandre.lureau@redhat.com>
 <20180228150615.17317-10-marcandre.lureau@redhat.com> <20180302023204.GA2818@dhcp-128-65.nay.redhat.com>
 <20180302200241-mutt-send-email-mst@kernel.org>
From:   =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@redhat.com>
Date:   Fri, 2 Mar 2018 19:09:48 +0100
Message-ID: <CAMxuvax-g_FUT+7g=+D6CC+XNKftgmeas9JR_bPAUDG9wuqUEA@mail.gmail.com>
Subject: Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Dave Young <dyoung@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Baoquan He <bhe@redhat.com>,
        Sergio Lopez Pascual <slp@redhat.com>,
        "Somlo, Gabriel" <somlo@cmu.edu>, xiaolong.ye@intel.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Hari Bathini <hbathini@linux.vnet.ibm.com>,
        Tony Luck <tony.luck@intel.com>,
        Vivek Goyal <vgoyal@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi

On Fri, Mar 2, 2018 at 7:03 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Fri, Mar 02, 2018 at 10:32:04AM +0800, Dave Young wrote:
>> Hi
>>
>> On 02/28/18 at 04:06pm, Marc-André Lureau wrote:
>> > The following patch is going to use the symbol from the fw_cfg module,
>> > to call the function and write the note location details in the
>> > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
>> >
>> > CC: Andrew Morton <akpm@linux-foundation.org>
>> > CC: Baoquan He <bhe@redhat.com>
>> > CC: Dave Young <dyoung@redhat.com>
>> > CC: Dave Young <dyoung@redhat.com>
>>
>> Above duplicated a CC, btw, I remember both Baoquan and me acked it
>> before, you can find the old email and carry the acked-by.
>
> I fixed it but all this is submitter's job really.

Thanks, my bad, I missed it from v6.

>
>> > CC: Hari Bathini <hbathini@linux.vnet.ibm.com>
>> > CC: Tony Luck <tony.luck@intel.com>
>> > CC: Vivek Goyal <vgoyal@redhat.com>
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> > Acked-by: Gabriel Somlo <somlo@cmu.edu>
>> > ---
>> >  kernel/crash_core.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
>> > index 4f63597c824d..a93590cdd9e1 100644
>> > --- a/kernel/crash_core.c
>> > +++ b/kernel/crash_core.c
>> > @@ -376,6 +376,7 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void)
>> >  {
>> >     return __pa(vmcoreinfo_note);
>> >  }
>> > +EXPORT_SYMBOL(paddr_vmcoreinfo_note);
>> >
>> >  static int __init crash_save_vmcoreinfo_init(void)
>> >  {
>> > --
>> > 2.16.1.73.g5832b7e9f2
>> >
>>
>> Thanks
>> Dave