Date: Wed, 6 Aug 2003 11:08:07 +0530
From: Maneesh Soni <maneesh@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: jeremy@goop.org, dick.streefland@xs4all.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] autofs4 doesn't expire
Message-ID: <20030806053807.GC1298@in.ibm.com>
Reply-To: maneesh@in.ibm.com
References: <4b0c.3f302ca5.93873@altium.nl> <20030805164904.36b5d2cc.akpm@osdl.org> <20030806042853.GA1298@in.ibm.com> <1060144454.18625.5.camel@ixodes.goop.org> <20030806050003.GB1298@in.ibm.com> <20030805220848.3ee1111a.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030805220848.3ee1111a.akpm@osdl.org>
User-Agent: Mutt/1.4i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1210
Lines: 37

On Tue, Aug 05, 2003 at 10:08:48PM -0700, Andrew Morton wrote:
> Maneesh Soni <maneesh@in.ibm.com> wrote:
> >
> >  +	if (vfs) {
> >  +		if (is_vfsmnt_tree_busy(vfs))
> >  +			ret--;
> >  +		/* just to reduce ref count taken in lookup_mnt
> >  +	 	 * cannot call mntput() here
> >  +	 	 */
> >  +		atomic_dec(&vfs->mnt_count);
> >  +	}
> 
> Doesn't work, does it?  If someone else does a mntput() just beforehand,
> __mntput() never gets run.
> 

no.. it will not work. looks like we have to unlock and lock dcache_lock and
use mntput as I did earlier. But I think, it will be really nice if Jermey
can revisit is_tree_busy() code.

There can be other problems like the checking d_count for dentries under
dcache_lock(). As users can do dget() or dput() manipulating d_count without
dcache_lock(). 

Maneesh

-- 
Maneesh Soni
IBM Linux Technology Center, 
IBM India Software Lab, Bangalore.
Phone: +91-80-5044999 email: maneesh@in.ibm.com
http://lse.sourceforge.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/