Received: by 10.223.185.116 with SMTP id b49csp297190wrg; Fri, 2 Mar 2018 19:35:40 -0800 (PST) X-Google-Smtp-Source: AG47ELvL7un8VbjKnz+ZTwoT9MT+JAHMz5H7o4laDy5Nx8IhMqfXoLcxTs5L7boYzgLjDcIKXh39 X-Received: by 10.99.121.131 with SMTP id u125mr6302618pgc.263.1520048140590; Fri, 02 Mar 2018 19:35:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520048140; cv=none; d=google.com; s=arc-20160816; b=qzPtu2LP5REC+aUz/FegUfkX5annw3fNGDs1hupdHHt1NtYBV4gV1fa9E63HkiC/p1 wpUcyUYgE8+ZroonrHJ9ttSnOwU07rlgM7Q5GeL+OBOo8uocbFqQI9uxZGyfXaA7MVZF bOXUTAMN/xSYnRaTSgpRXMUlmOCW0uin0Qda4AJcqLhaRdlo+0/X4XmhjT4DkqK6LLRE F4oFA3Q2YHFXbLhqMpR0trftCJQtzM4poQN8UykdhjgDUYND1hvhYL+5sUzXCFV0293w +mrsBCsCUIbYT+se3kF8NfUDVd9EI4A2qtwQEDSNR5UKiJBmEykKtXkWDu3JLuTOsuEP wxJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=Ooox3zXQQtvgPTLXRZHB4KA32tzTto9NKKKo+rstla0=; b=WaXi93dB59d/YmlyIh1w2dQDoXWCxlz5P1Jtba+8lk7xRPEnRKWtjUqyG23KHsO+eV HcjSc6bXSPXQA38r8nyjVjxEHI4jeqPjG4vaK+6yYTnmRIGecDQtm/bgjFQBcBo+NrPh fyi3Q4GhMyAZmU1x+HKJemOyEDPFkwlNexoorPikn6WjPq3tyOjJ/k+go8o+xdRzcqvJ eCMfXuunqZn5AG0UztA8L+qjIrDT+95pa+agMBex3HIK0uEANL0QsNsbp4c9RNoSGwPs TPqJETw6zJi9tsZd6/MeS72woioXe7USoXnPD/4CyWMcuJItNnpqdd7dgxASitavVYNX ecDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si2983037pfm.223.2018.03.02.19.35.26; Fri, 02 Mar 2018 19:35:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933397AbeCBWDN (ORCPT + 99 others); Fri, 2 Mar 2018 17:03:13 -0500 Received: from out02.mta.xmission.com ([166.70.13.232]:50206 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932655AbeCBWAg (ORCPT ); Fri, 2 Mar 2018 17:00:36 -0500 Received: from in02.mta.xmission.com ([166.70.13.52]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1ersjD-0005Ai-EV; Fri, 02 Mar 2018 15:00:35 -0700 Received: from 174-19-85-160.omah.qwest.net ([174.19.85.160] helo=x220.int.ebiederm.org) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1ersjA-0000ts-G4; Fri, 02 Mar 2018 15:00:35 -0700 From: "Eric W. Biederman" To: Miklos Szeredi Cc: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, Alban Crequy , Seth Forshee , Sargun Dhillon , Dongsu Park , "Serge E. Hallyn" , Linus Torvalds , "Eric W. Biederman" Date: Fri, 2 Mar 2018 15:59:16 -0600 Message-Id: <20180302215919.27207-3-ebiederm@xmission.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <87r2p287i8.fsf_-_@xmission.com> References: <87r2p287i8.fsf_-_@xmission.com> X-XM-SPF: eid=1ersjA-0000ts-G4;;;mid=<20180302215919.27207-3-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=174.19.85.160;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/7P+/zx7VTkfjwjKl4gm1MkgZVoSdxPVk= X-SA-Exim-Connect-IP: 174.19.85.160 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on sa03.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,TVD_RCVD_IP,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, XMGappySubj_01,XMSubLong autolearn=disabled version=3.4.0 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.7 XMSubLong Long Subject * 0.5 XMGappySubj_01 Very gappy subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; Body=1 Fuz1=1 Fuz2=171] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=171 X-Spam-Combo: *;Miklos Szeredi X-Spam-Relay-Country: X-Spam-Timing: total 2570 ms - load_scoreonly_sql: 0.10 (0.0%), signal_user_changed: 3.5 (0.1%), b_tie_ro: 2.3 (0.1%), parse: 1.29 (0.1%), extract_message_metadata: 79 (3.1%), get_uri_detail_list: 2.8 (0.1%), tests_pri_-1000: 43 (1.7%), tests_pri_-950: 2.4 (0.1%), tests_pri_-900: 1.97 (0.1%), tests_pri_-400: 113 (4.4%), check_bayes: 94 (3.7%), b_tokenize: 36 (1.4%), b_tok_get_all: 32 (1.3%), b_comp_prob: 4.3 (0.2%), b_tok_touch_all: 7 (0.3%), b_finish: 0.95 (0.0%), tests_pri_0: 2302 (89.6%), check_dkim_signature: 1.00 (0.0%), check_dkim_adsp: 29 (1.1%), tests_pri_500: 17 (0.7%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH v8 3/6] fuse: Remove the buggy retranslation of pids in fuse_dev_do_read X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At the point of fuse_dev_do_read the user space process that initiated the action on the fuse filesystem may no longer exist. The process have been killed or may have fired an asynchronous request and exited. If the initial process has exited the code "pid_vnr(find_pid_ns(in->h.pid, fc->pid_ns)" will either return a pid of 0, or in the unlikely event that the pid has been reallocated it can return practically any pid. Any pid is possible as the pid allocator allocates pid numbers in different pid namespaces independently. The only way to make translation in fuse_dev_do_read reliable is to call get_pid in fuse_req_init_context, and pid_vnr followed by put_pid in fuse_dev_do_read. That reference counting in other contexts has been shown to bounce cache lines between processors and in general be slow. So that is not desirable. The only known user of running the fuse server in a different pid namespace from the filesystem does not care what the pids are in the fuse messages so removing this code should not matter. Getting the translation to a server running outside of the pid namespace of a container can still be achieved by playing setns games at mount time. It is also possible to add an option to pass a pid namespace into the fuse filesystem at mount time. Fixes: 5d6d3a301c4e ("fuse: allow server to run in different pid_ns") Signed-off-by: "Eric W. Biederman" --- fs/fuse/dev.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 5d06384c2cae..0fb58f364fa6 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -1260,12 +1260,6 @@ static ssize_t fuse_dev_do_read(struct fuse_dev *fud, struct file *file, in = &req->in; reqsize = in->h.len; - if (task_active_pid_ns(current) != fc->pid_ns) { - rcu_read_lock(); - in->h.pid = pid_vnr(find_pid_ns(in->h.pid, fc->pid_ns)); - rcu_read_unlock(); - } - /* If request is too large, reply with an error and restart the read */ if (nbytes < reqsize) { req->out.h.error = -EIO; -- 2.14.1