Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1520036364.2786.39.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 64/67] usb: uas: unconditionally bring back host
 after reset
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Oliver Neukum <oneukum@suse.com>,
        Hans de Goede <hdegoede@redhat.com>
Cc:     stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Sat, 03 Mar 2018 00:19:24 +0000
In-Reply-To: <20180202140822.268335379@linuxfoundation.org>
References: <20180202140815.091718203@linuxfoundation.org>
         <20180202140822.268335379@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-02-02 at 17:58 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Oliver Neukum <oneukum@suse.com>
> 
> commit cbeef22fd611c4f47c494b821b2b105b8af970bb upstream.
[...]
> --- a/drivers/usb/storage/uas.c
> +++ b/drivers/usb/storage/uas.c
> @@ -1052,20 +1052,19 @@ static int uas_post_reset(struct usb_int
>  		return 0;
>  
> 	err = uas_configure_endpoints(devinfo);
> -	if (err) {
> +	if (err && err != ENODEV)
>  		shost_printk(KERN_ERR, shost,
>  			     "%s: alloc streams error %d after reset",
>  			     __func__, err);
[...]

This should be checking for -ENODEV, shouldn't it?

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.