Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180301083950.esonqqg2m5noofdp@linutronix.de>
References: <20180301032754.146788-1-dbasehore@chromium.org> <20180301083950.esonqqg2m5noofdp@linutronix.de>
From:   "dbasehore ." <dbasehore@chromium.org>
Date:   Fri, 2 Mar 2018 17:23:13 -0800
Message-ID: <CAGAzgso6ZOKWEWPJP3FD8si39S+WUhZEB3RgWrUigo4tSC079w@mail.gmail.com>
Subject: Re: [PATCH] cpu_pm: add syscore_suspend error handling
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        alex.shi@linaro.org, Brian Norris <briannorris@chromium.org>,
        Marc Zyngier <marc.zyngier@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 1, 2018 at 12:39 AM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> On 2018-02-28 19:27:54 [-0800], Derek Basehore wrote:
>> If cpu_cluster_pm_enter() fails, cpu_pm_exit() should be called. This
>> will put the CPU in the correct state to resume from the failure.
>
> Was this triggered or found on review? Either way it was introduced in
>   6f3eaec87b6b ("cpu_pm: call notifiers during suspend")
> and I might need a stable tag.

It was found during review. I was able to verify that this is a bug,
though. The Rockchip RK3399 doesn't use cluster idle except during
suspend. If I just return an error for cpu_cluster_pm_enter, the
machine wedges. Including this patch makes it error out of suspend
gracefully.

>
>> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
>
> Sebastian