Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.4 64/67] usb: uas: unconditionally bring back host after
 reset
To:     Ben Hutchings <ben.hutchings@codethink.co.uk>,
        Oliver Neukum <oneukum@suse.com>
Cc:     stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20180202140815.091718203@linuxfoundation.org>
 <20180202140822.268335379@linuxfoundation.org>
 <1520036364.2786.39.camel@codethink.co.uk>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <5ed38173-5fd6-eaa2-b838-632829471aec@redhat.com>
Date:   Sat, 3 Mar 2018 10:14:42 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1520036364.2786.39.camel@codethink.co.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 03-03-18 01:19, Ben Hutchings wrote:
> On Fri, 2018-02-02 at 17:58 +0100, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Oliver Neukum <oneukum@suse.com>
>>
>> commit cbeef22fd611c4f47c494b821b2b105b8af970bb upstream.
> [...]
>> --- a/drivers/usb/storage/uas.c
>> +++ b/drivers/usb/storage/uas.c
>> @@ -1052,20 +1052,19 @@ static int uas_post_reset(struct usb_int
>>   		return 0;
>>   
>>   	err = uas_configure_endpoints(devinfo);
>> -	if (err) {
>> +	if (err && err != ENODEV)
>>   		shost_printk(KERN_ERR, shost,
>>   			     "%s: alloc streams error %d after reset",
>>   			     __func__, err);
> [...]
> 
> This should be checking for -ENODEV, shouldn't it?

Yes you're right, the check should be != -ENODEV.

Oliver can you do a follow-up patch fixing this please?

Regards,

Hans