Received: by 10.223.185.116 with SMTP id b49csp1068609wrg; Sat, 3 Mar 2018 14:39:46 -0800 (PST) X-Google-Smtp-Source: AG47ELu2HBvyMmlIon8L3b1eaB8rZ0odfQJ0Os54qP2assYEDY2wJCO0d5zo6deDM/m8IGf2feZD X-Received: by 10.99.141.200 with SMTP id z191mr8172363pgd.418.1520116786267; Sat, 03 Mar 2018 14:39:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520116786; cv=none; d=google.com; s=arc-20160816; b=e5w2TOevPAud7nkpdbs9M96gzoCzctseiRcDS801ewVat/QGvupGca2WBqycskYU2/ xzKHMxKzPpOot+fyzlzMsJn/hrpGlVLiK0hXiw/QsQv9CDobkgr4ZqfmeVeLoFZkZvJx vcsrZ30FH8ZphlBYx0TDG1yQVq3l6NRp2wFN7gKJSkwTuni39rTENt5StuBeabD4nCWL stmYUZzgQ+Jgr2/c1+epMQMexVRC5TDL4hSyDi3tEdf86wn2KG1Z+gyfThtBAHyJkP/E 4ZpEEwjE3fD9afvkGsSuLSFAqC6VcZPOpnQ7nq7o0DQCUiy9ex1paVB3JU3wGa2pRw5C P1vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=hUGu5cLTk2n9Md2d/F8DBM0bTSfdmF+pWeXIE2vU97o=; b=XS14CMXtDtyEETkmvtVgc3DOn1R8IoIqWvzTK125wGj5iMki1sKtv6sQId9wv/17c+ o8oVXQqhQ6e2kKCHbBduL91WL2lNGrVSA9qEYCO3bogWSEbGHl7BIy8NAsdbQFlXt+n6 iCnHqdbGQWQolTHeq4WkC0d1RSCvu7hJaDCKjfvdIl1s+C+pPbkuPjLa4KX4URCwYmqL 0fLJCFhh7jL5XSiSltMWcDf8EmL23XhN4LGc3iS2vVq0daC2lDfB71uA+HMNECZctGOu 0xTXFuPQohHiW2CJqolu41VZkoO/WgmXppOhdIF7oaOQCST1PRNOaOjxlQPW23EvQqHw 3hNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Kcsqrm6B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b189si6080487pgc.798.2018.03.03.14.39.32; Sat, 03 Mar 2018 14:39:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Kcsqrm6B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934686AbeCCWiq (ORCPT + 99 others); Sat, 3 Mar 2018 17:38:46 -0500 Received: from mail-cys01nam02on0109.outbound.protection.outlook.com ([104.47.37.109]:20871 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933968AbeCCWin (ORCPT ); Sat, 3 Mar 2018 17:38:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hUGu5cLTk2n9Md2d/F8DBM0bTSfdmF+pWeXIE2vU97o=; b=Kcsqrm6Be7MU+AquYsXOi75F61e4+v0tR3anaMak51E0FKx4duejQHw5oBkV1/eD2FIk0H/PxKfpaBeBOrw6JT8iqm5l82fK8yd94TQl4i1/0scF1J8TAHl4J5nM1OVC/kbyd9Cf4m8Ln3yE1EDg+KBan9ufGvO3BLnTGowJP+k= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1067.namprd21.prod.outlook.com (52.132.149.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Sat, 3 Mar 2018 22:38:41 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:38:41 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Kuninori Morimoto , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 031/115] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT Thread-Topic: [PATCH AUTOSEL for 4.4 031/115] ASoC: rcar: ssi: don't set SSICR.CKDV = 000 with SSIWSR.CONT Thread-Index: AQHTsz9ShCeVo0rW/0ax776wjTje/Q== Date: Sat, 3 Mar 2018 22:31:06 +0000 Message-ID: <20180303223010.27106-31-alexander.levin@microsoft.com> References: <20180303223010.27106-1-alexander.levin@microsoft.com> In-Reply-To: <20180303223010.27106-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1067;7:Ps6zU9XnHi845gxWHaVgB1sKf4A9o1r2PebVlTh+Mzc5aurNZFrPD0pd7olhqhccIZXjWGmj4MBlnLje2NaOsIfw7nO+3c4mEPoZq69MsFqDrsycyQ9Tp9DGvRvh3tyO4wyj3FrOW8UPWVWJjwt2GPiFwcLL4zMiRyWC2BTWu6ThREUCtWpHCXvbIeYueqIQlRt27y5TNjDPSNfv1PTHuDVu2ZN+nWXDFc0AcawdV1EHCQskutUMi3AjxB/XtlWP x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: deb20c75-a692-4c44-b729-08d5815783ce x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1067; x-ms-traffictypediagnostic: MW2PR2101MB1067: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(3231220)(944501244)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1067;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1067; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(39860400002)(39380400002)(346002)(199004)(189003)(4326008)(5250100002)(86362001)(1076002)(2501003)(110136005)(6666003)(81156014)(2906002)(8936002)(305945005)(81166006)(2950100002)(7736002)(10290500003)(26005)(186003)(3660700001)(478600001)(72206003)(107886003)(8676002)(3280700002)(2900100001)(76176011)(6116002)(25786009)(3846002)(102836004)(6506007)(5660300001)(97736004)(10090500001)(86612001)(106356001)(99286004)(6512007)(66066001)(316002)(53936002)(14454004)(105586002)(36756003)(6486002)(54906003)(6436002)(68736007)(22452003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1067;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: wgvqT/GMRu0PQaOwsp19K6nDyuJKQA9Sx7ozTAI6Fk5uQcNEx4i9LBuZ15XKY97EUKGJXh2NRRv3Hp3FE4zUBQTr3n9Tg0KLlPKjbghysC6oyA2/f9dQ15fSiAugpKHwINfRjqwGPoTzjt4rnCGS9hAVPMS7v6j49yxbpTVqzOg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: deb20c75-a692-4c44-b729-08d5815783ce X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:31:06.8853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1067 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuninori Morimoto [ Upstream commit 6b8530cc056efd4a11b034ca5b1e9f7e9563f553 ] R-Car Datasheet is indicating "SSICR.CKDV =3D 000 is invalid when SSIWSR.WS_MODE =3D 1 or SSIWSR.CONT =3D 1". Current driver will set CONT, thus, we shouldn't use CKDV =3D 000. This patch fixup it. Reported-by: Hiroyuki Yokoyama Signed-off-by: Kuninori Morimoto Tested-by: Hiroyuki Yokoyama Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/sh/rcar/ssi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index 38aae96267c9..a001331a53c1 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -142,6 +142,15 @@ static int rsnd_ssi_master_clk_start(struct rsnd_ssi *= ssi, */ for (j =3D 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) { =20 + /* + * It will set SSIWSR.CONT here, but SSICR.CKDV =3D 000 + * with it is not allowed. (SSIWSR.WS_MODE with + * SSICR.CKDV =3D 000 is not allowed either). + * Skip it. See SSICR.CKDV + */ + if (j =3D=3D 0) + continue; + /* * this driver is assuming that * system word is 64fs (=3D 2 x 32bit) --=20 2.14.1