Received: by 10.223.185.116 with SMTP id b49csp1076529wrg; Sat, 3 Mar 2018 14:54:43 -0800 (PST) X-Google-Smtp-Source: AG47ELv5M99ylWFqldb/KAnmECffbXr0XVkEs7M4SsTfOmBT5IPekMULkgnWonBViIkOL7BPbllP X-Received: by 10.98.155.93 with SMTP id r90mr10391550pfd.132.1520117683356; Sat, 03 Mar 2018 14:54:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520117683; cv=none; d=google.com; s=arc-20160816; b=FmvFZwrvyaX4jQ46rQ2RhQnELMoRTf3JIE5qPaAPsXsWkNBlOBKHEz72rQXcP34Zx/ NRcl7Cz2Jp8Dp1yspIJDtWKAMy2vtmiOVt838LZlvwMrSnve7g3GBcZzXU/KUHSZWWaF ugoDeSysMqHoIO+I3wTikblf7KyyRjtm+eD0gn+ia8M+Z5haHC9EqbIxMmLtn4VcR6IE RBQRq87lrg3Ux/J6fft+Trc0sg4LtYD1WdTXY6r/Ia7gwb05Op19j89a3LwtPEu9njWU Ejdqzn1rnUiGlE4I29qy+7ki6yKVcfv2ULLbK92UNSp9AA9Yrt6umSgelLpOFaORSImx PD5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=X++CwRDZMiAhfXf4iA2f5KdCx3XUxGsctj2+UW1LRrU=; b=VPiMGi72s+EvbX9+mGA6ZCOlLzkEw6QRv3XcspN+is8A0u1S/IwFU9fqo93YU1AoI5 oTtsFiOvDsx+12TlYVSFBTVj8dghhJr+gAjfbvoYGyczXZq7H4yTf7SU4/it0wWJG2iw +dSpj4vco6D9SogjBt9HI2Cf5e02mbTvRBMI/ubGyDI6laK+RIlQey8fU3xIXYNFrZYO UQcXBtoWQZhNyl5gCE0bIb5P/dTIQCIFDS8r7RCEhJD9RNVufMebfmLfd2lgmE5Tzv8x pG9l1sqlMXyh34L8sDBaq+kHCBHipKhWSbTwMzKf1ukbF30PlK/KPyjw46He4DmmsMST BJ/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=m3k/bfxY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6-v6si467526plm.448.2018.03.03.14.54.29; Sat, 03 Mar 2018 14:54:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=m3k/bfxY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935297AbeCCWxc (ORCPT + 99 others); Sat, 3 Mar 2018 17:53:32 -0500 Received: from mail-by2nam01on0095.outbound.protection.outlook.com ([104.47.34.95]:48488 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935408AbeCCWlF (ORCPT ); Sat, 3 Mar 2018 17:41:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=X++CwRDZMiAhfXf4iA2f5KdCx3XUxGsctj2+UW1LRrU=; b=m3k/bfxYCasiVNGAqjZ6MLi7xhsnEKn23RbTqAj9dqzogKnGRG+UKjzVfmXLtc6FCLKTNN22XnaPkKzc4LtlztTRpGwgr+q3ung4vsCnLEwIv/NIFybZa3qKb5Vq2q9kqHenH05vB9ayMAT1u1aimj4BUc9pcrFAOFcIjj8bQPs= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB0940.namprd21.prod.outlook.com (52.132.146.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.5; Sat, 3 Mar 2018 22:41:03 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:41:03 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Janusz Krzysztofik , Guennadi Liakhovetski , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH AUTOSEL for 3.18 16/63] [media] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock Thread-Topic: [PATCH AUTOSEL for 3.18 16/63] [media] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock Thread-Index: AQHTsz+glN6ak9So2EGOzDLJiLasxw== Date: Sat, 3 Mar 2018 22:33:18 +0000 Message-ID: <20180303223228.27323-16-alexander.levin@microsoft.com> References: <20180303223228.27323-1-alexander.levin@microsoft.com> In-Reply-To: <20180303223228.27323-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB0940;7:T8JmlJZbn3qwCe9kLDoeBna4t2GNWtu9kpF28RejkqRT8RjmGgPAAs/hukHHdObiuMsFq0jntm8dCNcpQMYS55eeub5xws4VTVwrc0dVy863PceNoH2vL742vACs2HJnOskeW2mKRNu6FNCNPz7q/3j9v6CGzrZcxME3Xm7LiRBgRFtcg52wcRt4rKLgTNTW9TE9BjM0fvh/0KgaloXBak/83yN5WZ8n1Mr7a9mhzegXcwsbpXDGzBHqCFKmGuGg x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 26e8960c-4dee-4b7a-5344-08d58157d89d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7193020);SRVR:MW2PR2101MB0940; x-ms-traffictypediagnostic: MW2PR2101MB0940: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(26323138287068)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231220)(944501244)(52105095)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:MW2PR2101MB0940;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB0940; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(39380400002)(346002)(366004)(39860400002)(396003)(199004)(189003)(106356001)(68736007)(6486002)(25786009)(22452003)(6436002)(186003)(2906002)(81156014)(81166006)(10090500001)(66066001)(8676002)(36756003)(6512007)(39060400002)(2900100001)(8666007)(316002)(97736004)(59450400001)(102836004)(53936002)(6506007)(3280700002)(26005)(4326008)(5250100002)(305945005)(2501003)(76176011)(2950100002)(86362001)(99286004)(3846002)(72206003)(14454004)(3660700001)(478600001)(1076002)(5660300001)(10290500003)(6666003)(6116002)(7736002)(86612001)(107886003)(110136005)(54906003)(105586002)(8936002)(575784001)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB0940;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8Je60NOVuTyAAViC8sq7xVx/DjC/lprlifX7rEuXfx1lHffhkMlpOn2KSUix1fvtflL7M1Rgntk73mfCqt1ZwvQwrGu3tHvbj7tYbmDWPGt3F1P3JxIYBABbOsA5a85/4CKdODzblyIGH10ycf9OVptJS9IrLtm+UOmRYeeZDM4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26e8960c-4dee-4b7a-5344-08d58157d89d X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:33:18.5753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0940 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Janusz Krzysztofik [ Upstream commit 54449af0e0b2ea43a8166611c95b730c850c3184 ] After changes to v4l2_clk API introduced in v4.1 by commits a37462b919 '[media] V4L: remove clock name from v4l2_clk API' and 4f528afcfb '[media] V4L: add CCF support to the v4l2_clk API', ov6650 sensor stopped responding because v4l2_clk_get(), still called with depreciated V4L2 clock name "mclk", started to return respective CCF clock instead of the V4l2 one registered by soc_camera. Fix it by calling v4l2_clk_get() with NULL clock name. Created and tested on Amstrad Delta against Linux-4.7-rc3 with omap1_camera fixes. Signed-off-by: Janusz Krzysztofik Signed-off-by: Guennadi Liakhovetski Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/soc_camera/ov6650.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/soc_camera/ov6650.c b/drivers/media/i2c/soc_= camera/ov6650.c index ab01598ec83f..d8be90cd6e56 100644 --- a/drivers/media/i2c/soc_camera/ov6650.c +++ b/drivers/media/i2c/soc_camera/ov6650.c @@ -1016,7 +1016,7 @@ static int ov6650_probe(struct i2c_client *client, priv->code =3D V4L2_MBUS_FMT_YUYV8_2X8; priv->colorspace =3D V4L2_COLORSPACE_JPEG; =20 - priv->clk =3D v4l2_clk_get(&client->dev, "mclk"); + priv->clk =3D v4l2_clk_get(&client->dev, NULL); if (IS_ERR(priv->clk)) { ret =3D PTR_ERR(priv->clk); goto eclkget; --=20 2.14.1