Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sasha Levin <Alexander.Levin@microsoft.com>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
CC:     Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>,
        "Guilherme G . Piccoli" <gpiccoli@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Sasha Levin <Alexander.Levin@microsoft.com>
Subject: [PATCH AUTOSEL for 4.4 035/115] powerpc/xmon: Fix an unexpected xmon
 on/off state change
Thread-Topic: [PATCH AUTOSEL for 4.4 035/115] powerpc/xmon: Fix an unexpected
 xmon on/off state change
Thread-Index: AQHTsz9TEheLrRm5P0i0OvMLjOUnhw==
Date:   Sat, 3 Mar 2018 22:31:09 +0000
Message-ID: <20180303223010.27106-35-alexander.levin@microsoft.com>
References: <20180303223010.27106-1-alexander.levin@microsoft.com>
In-Reply-To: <20180303223010.27106-1-alexander.levin@microsoft.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 58daf864-1877-495f-0845-08d58157890d
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:31:09.1665
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB0938
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>

[ Upstream commit 3b5bf42b81d56085fd58692b5117f69aa77fdff7 ]

Once xmon is triggered by sysrq-x, it is enabled always afterwards even
if it is disabled during boot. This will cause a system reset interrupt
fail to dump. So keep xmon in its original state after exit.

We have several ways to set xmon on or off.
1) by a build config CONFIG_XMON_DEFAULT.
2) by a boot cmdline with xmon or xmon=3Dearly or xmon=3Don to enable xmon
and xmon=3Doff to disable xmon. This value will override that in step 1.
3) by a debugfs interface, as proposed in this patchset.
And this value can override those in step 1 and 2.

Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
---
 arch/powerpc/xmon/xmon.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 786bf01691c9..9f08064324ce 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -71,6 +71,7 @@ static int xmon_gate;
 #endif /* CONFIG_SMP */
=20
 static unsigned long in_xmon __read_mostly =3D 0;
+static int xmon_on =3D IS_ENABLED(CONFIG_XMON_DEFAULT);
=20
 static unsigned long adrs;
 static int size =3D 1;
@@ -3041,6 +3042,8 @@ static void sysrq_handle_xmon(int key)
 	/* ensure xmon is enabled */
 	xmon_init(1);
 	debugger(get_irq_regs());
+	if (!xmon_on)
+		xmon_init(0);
 }
=20
 static struct sysrq_key_op sysrq_xmon_op =3D {
@@ -3057,7 +3060,7 @@ static int __init setup_xmon_sysrq(void)
 __initcall(setup_xmon_sysrq);
 #endif /* CONFIG_MAGIC_SYSRQ */
=20
-static int __initdata xmon_early, xmon_off;
+static int __initdata xmon_early;
=20
 static int __init early_parse_xmon(char *p)
 {
@@ -3065,10 +3068,12 @@ static int __init early_parse_xmon(char *p)
 		/* just "xmon" is equivalent to "xmon=3Dearly" */
 		xmon_init(1);
 		xmon_early =3D 1;
-	} else if (strncmp(p, "on", 2) =3D=3D 0)
+		xmon_on =3D 1;
+	} else if (strncmp(p, "on", 2) =3D=3D 0) {
 		xmon_init(1);
-	else if (strncmp(p, "off", 3) =3D=3D 0)
-		xmon_off =3D 1;
+		xmon_on =3D 1;
+	} else if (strncmp(p, "off", 3) =3D=3D 0)
+		xmon_on =3D 0;
 	else if (strncmp(p, "nobt", 4) =3D=3D 0)
 		xmon_no_auto_backtrace =3D 1;
 	else
@@ -3080,10 +3085,8 @@ early_param("xmon", early_parse_xmon);
=20
 void __init xmon_setup(void)
 {
-#ifdef CONFIG_XMON_DEFAULT
-	if (!xmon_off)
+	if (xmon_on)
 		xmon_init(1);
-#endif
 	if (xmon_early)
 		debugger(NULL);
 }
--=20
2.14.1