Received: by 10.223.185.116 with SMTP id b49csp1089786wrg; Sat, 3 Mar 2018 15:16:40 -0800 (PST) X-Google-Smtp-Source: AG47ELsKVjnHTtkvd/DxBIxGNX5IqzO7EmRGogaWl0H4IppH4mCrVBxCRV5xy7wRARGo2AjI4ZAN X-Received: by 10.98.10.65 with SMTP id s62mr10343485pfi.234.1520119000408; Sat, 03 Mar 2018 15:16:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520119000; cv=none; d=google.com; s=arc-20160816; b=K8g8O3IVWDS2tSOI0fYFi1LNZbZDpd1McfeeIO0UpMMJ+tTUygV8wumaWZLdi3wSE7 6t//Lh8QXorMG7XbGqtYTCK03DGJh8W5A/nSuqsTKulqLzzs4vEtXuZejLROSHIq+k8Y ZBZjx39gpJk6sQv8j2vVIVh99zb8nzDnO1TTvYLnIb+fwd9LqX2rUNElbDm3033N1IEP rntPiMA1cowmT1l8tirwBmobJtlRJE/XdwsIRwHjRYM0onO0pN0M+0cBqtGC1mb7cy2+ ofSaR02JsnQMo5je04nfHJ1ZFC1ofQUHlIksy7ZFNwdv+RYJvLloaWsDHAwQ8m4KPDuv zLQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=1tpqu9IBS86diAUrOpxPz2N7A9smARC0T9Dlcf/0QjA=; b=T+XuChx2In1bxea/bSuMmWiK2xGB01MjYt59JnlTYJUu53E1sccydSeVElNqvFNQQ4 AvZu15DtzHr7DWDdya5RHYLFiDK3wq8VnCA80T4q2R6pxuPcMnuj8b1eywwlU9iVEBQA fVG1PQqawXXA76TZ3oqvgIw7PrfjP8fiL9TjqUIDFe1i5U7sbaDROZHdUUHxrbCKzVZE MJ2/eh/17Mm4kEVePLSIULwirdoZ2jrlcIjgJlhS/czkotRgKBNbxVuuxySYdG6R7MWJ 1eWcyrGjCmGlAAedFDIYYvls1h8xlWD5X6LM9uy95dUvZzaoxrc+cfClZCc22Pp+dIqU iFhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ZGK5RKLG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si3351455pfd.201.2018.03.03.15.16.26; Sat, 03 Mar 2018 15:16:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=ZGK5RKLG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932904AbeCCXPu (ORCPT + 99 others); Sat, 3 Mar 2018 18:15:50 -0500 Received: from mail-cys01nam02on0114.outbound.protection.outlook.com ([104.47.37.114]:41081 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934922AbeCCWiQ (ORCPT ); Sat, 3 Mar 2018 17:38:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1tpqu9IBS86diAUrOpxPz2N7A9smARC0T9Dlcf/0QjA=; b=ZGK5RKLG1zSEaFYOFZqEs5pVZguafUcwEGj5pQ010LxPrO18/OEYbm740VXfcw2Wlg7coj9xZqCv/NVnOCYc7gpheaYrlnq0qBfZBa1jcquzf4ErXVIBoYLcx8G7oGDqVKSyuyvXjtinrlaJN7bRUcUcmzpQBjBudp2mou5uFPY= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1067.namprd21.prod.outlook.com (52.132.149.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Sat, 3 Mar 2018 22:38:10 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:38:10 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Javier Martinez Canillas , Dmitry Torokhov , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 029/115] Input: qt1070 - add OF device ID table Thread-Topic: [PATCH AUTOSEL for 4.4 029/115] Input: qt1070 - add OF device ID table Thread-Index: AQHTsz9RboijMz8TyE2Zf6407Zjx7A== Date: Sat, 3 Mar 2018 22:31:05 +0000 Message-ID: <20180303223010.27106-29-alexander.levin@microsoft.com> References: <20180303223010.27106-1-alexander.levin@microsoft.com> In-Reply-To: <20180303223010.27106-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1067;7:+NjU6E/AeCyvmNjjg1kA0nxL74qTDe7bHBKDmQs/lrDBcCMPchjCq1jBcBU4gdV8vTAUqUd1ulWV/kbILAymkXsHn7Ijkzua9zBIr/eUDk3+YzCxcqbDU2ASCTNSHPXHd2bOoGajZvHeKOk+dArGbQtsR6KCBJsG/COLKC1clEazb9idq4gQ5Ce4s2uHkuyU28TWzk5i6CDbdD2wajAIuJJxhBMXJBjfXy09uegSwjQLC9xTjJBqa/nDG51dSa98 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 207e674e-808d-4977-079c-08d581577171 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1067; x-ms-traffictypediagnostic: MW2PR2101MB1067: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158)(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(3231220)(944501244)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1067;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1067; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(39860400002)(39380400002)(346002)(199004)(189003)(4326008)(5250100002)(86362001)(1076002)(2501003)(110136005)(6666003)(81156014)(2906002)(8936002)(305945005)(81166006)(2950100002)(7736002)(10290500003)(26005)(186003)(3660700001)(478600001)(72206003)(107886003)(8676002)(3280700002)(2900100001)(39060400002)(76176011)(6116002)(25786009)(3846002)(102836004)(6506007)(5660300001)(97736004)(10090500001)(86612001)(106356001)(99286004)(6512007)(66066001)(316002)(53936002)(14454004)(105586002)(36756003)(6486002)(54906003)(6436002)(68736007)(22452003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1067;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: M9gjFUtbUv7EX8fmdllcsEUpsiIacovS9ZbQj5VD7eKo4id7YIZ+FEZ7wrkizDGfcqz3ddJdcDa4aqd7wDfxKzqixQ6Di0/3k+bcQDkAYUaO8TwUPH9tuL5GwzJ7bsGPgLybIGU7p2HIXtFYmC7EUcZNvhi5rkugthN5Jgu79IQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 207e674e-808d-4977-079c-08d581577171 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:31:05.6352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1067 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Javier Martinez Canillas [ Upstream commit cf5cd9d4480a87da78768718cac194a71079b5cb ] The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. The compatible strings don't have a vendor prefix because that's how it's used currently, and changing this will be a Device Tree ABI break. Signed-off-by: Javier Martinez Canillas Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/keyboard/qt1070.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt107= 0.c index 5a5778729e37..76bb51309a78 100644 --- a/drivers/input/keyboard/qt1070.c +++ b/drivers/input/keyboard/qt1070.c @@ -274,9 +274,18 @@ static const struct i2c_device_id qt1070_id[] =3D { }; MODULE_DEVICE_TABLE(i2c, qt1070_id); =20 +#ifdef CONFIG_OF +static const struct of_device_id qt1070_of_match[] =3D { + { .compatible =3D "qt1070", }, + { }, +}; +MODULE_DEVICE_TABLE(of, qt1070_of_match); +#endif + static struct i2c_driver qt1070_driver =3D { .driver =3D { .name =3D "qt1070", + .of_match_table =3D of_match_ptr(qt1070_of_match), .pm =3D &qt1070_pm_ops, }, .id_table =3D qt1070_id, --=20 2.14.1