Received: by 10.223.185.116 with SMTP id b49csp1090179wrg; Sat, 3 Mar 2018 15:17:20 -0800 (PST) X-Google-Smtp-Source: AG47ELtcc++h5mUtHSULLRHJyhU7hEhkVzTvJkTcIJzZbV4wva+dEsqvTL5C6jpp7m0BGFktf4Ez X-Received: by 10.99.116.67 with SMTP id e3mr8210239pgn.265.1520119040192; Sat, 03 Mar 2018 15:17:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520119040; cv=none; d=google.com; s=arc-20160816; b=Co8ynk6JEDqzjRu5WknF6yWqVvEPYUHQNA8fX3VcaCuKrm9aqRxc3dOPFoyL/wgvBu e19S3qPpzo2mjq8RKKiM49wLjpue8crrFGxS4vmcDX6tdvYL2W9yw25wIPX3h1s3uR+D kMh9ERKV5PkdnJce2KLMUdEtNOtjkJWuNzbWGeU+y9hEwZCe3LP5U8j2B4RyDMlHxAFR uIPwLGtAWWkQRIT2mda5t8yjJmRCCPsNTcWLzD9lA0gmzmVDYvElwXsjRg8I4k6FI6NI FiRb/QJVm9wlMNSnqQc1vX/jY0v+V5ITwSKVeBePcyuuVgmgtTJNUy/bfh6g/PJxY3XM N2VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=kct5s1GMMF6rcCx3aTzrn4VLpsyBjbn+0Mk8NeZa3Zk=; b=EX0SyoLe4wpGr3JQIQkox8q97ygsyne5pZaHkGgQ0GmTgEyOFILYKPbuVtlac/zrYe KBLzzdHFqjS3nMSWQNEp6gBqzI6n/zSMCcIBI85Cf7+nLm8G2TerobHDWODZMfuvLz0G 1SGC2fC6d7+zTr71IyN4cG8V7hidfBQJb6bWTNdXsbWrS8nXI+XGhRTviw+fwHNxKntp 9FPXIGbQR+oukjBzz8k9tiz87NiutqbnPL9DnTD76QsJoHjwS4P96eZH+V7smvK4shWJ 7h5hFG53QAEAaWHbNGkgZ1qxACfFEt6X+FLmetlI/wXDSS+H4NIYdCN2TVeVew/YhlM7 VoCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Ak3+Xulw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7si6131155pgp.660.2018.03.03.15.17.05; Sat, 03 Mar 2018 15:17:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Ak3+Xulw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933220AbeCCXQI (ORCPT + 99 others); Sat, 3 Mar 2018 18:16:08 -0500 Received: from mail-cys01nam02on0114.outbound.protection.outlook.com ([104.47.37.114]:41081 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934905AbeCCWiO (ORCPT ); Sat, 3 Mar 2018 17:38:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kct5s1GMMF6rcCx3aTzrn4VLpsyBjbn+0Mk8NeZa3Zk=; b=Ak3+XulwNOU7Yqw9yOynsJKhPtSsDMvQJh1G6s5hx0vnzR44e3rcAirMpYdbUDw9ROaI1eJ0+coXZE0cLEmJ8PFiInFevHxxjRpd9/TR702vDQQL/gLYeVBXkBnSH66kMxFX51rvoS35DYSfWqkXm0Q2Jw7duMqOAk5NUHpd1f8= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1067.namprd21.prod.outlook.com (52.132.149.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Sat, 3 Mar 2018 22:38:09 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:38:09 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Janusz Krzysztofik , Guennadi Liakhovetski , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 026/115] [media] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock Thread-Topic: [PATCH AUTOSEL for 4.4 026/115] [media] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock Thread-Index: AQHTsz9QOTglGdrwSEGpfsGsgVGMsA== Date: Sat, 3 Mar 2018 22:31:03 +0000 Message-ID: <20180303223010.27106-26-alexander.levin@microsoft.com> References: <20180303223010.27106-1-alexander.levin@microsoft.com> In-Reply-To: <20180303223010.27106-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1067;7:MFiFHgT3QhxPPWfijsMQODXWHydmEJfaOYW5p79HR9OsAqxdNqC2lx0rUKeCTMlByEkh227YE+lfrRk5zYQtcF9Z7299Bk/7RBmrHMT5ar+FOPn3519y/dDeKLQkFDWQ8r7LVfQyvlIrHI4Vc9Aryz56Y7+zkZy1lg1jPV6YR6puy4RUm8I87ovjAwZ3mQRjwOjZ0y0uF/wS3afChWC1yiR+VlzVDUL0rKWtDZtsSdmZrbEvVeV9/iS2z9taDfrR x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 103019b9-de6c-491e-8756-08d58157708e x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1067; x-ms-traffictypediagnostic: MW2PR2101MB1067: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(26323138287068)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(3231220)(944501244)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1067;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1067; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(39860400002)(39380400002)(346002)(199004)(189003)(4326008)(5250100002)(86362001)(1076002)(2501003)(110136005)(6666003)(81156014)(2906002)(8936002)(305945005)(81166006)(2950100002)(7736002)(10290500003)(26005)(186003)(3660700001)(478600001)(72206003)(107886003)(8676002)(3280700002)(59450400001)(2900100001)(39060400002)(76176011)(6116002)(25786009)(3846002)(102836004)(575784001)(6506007)(5660300001)(97736004)(10090500001)(86612001)(106356001)(99286004)(6512007)(66066001)(316002)(53936002)(14454004)(105586002)(36756003)(6486002)(8666007)(54906003)(6436002)(68736007)(22452003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1067;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: enGlDa0gcMm1j84GwrDdyrrloNnv4Y04Pkn+y7GmWNA4LXEv8QTV8j7N/FHfJAmJ6dI7biD/G28KzEQEIce0VHpuQvlxKuy+KnNE7tnqw76AU4az7A+uQXRn8H1qs1hbCwDsKf78OIkIV1D9dr76NowrRYesEUjWC4R+zyC6fao= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 103019b9-de6c-491e-8756-08d58157708e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:31:03.8852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1067 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Janusz Krzysztofik [ Upstream commit 54449af0e0b2ea43a8166611c95b730c850c3184 ] After changes to v4l2_clk API introduced in v4.1 by commits a37462b919 '[media] V4L: remove clock name from v4l2_clk API' and 4f528afcfb '[media] V4L: add CCF support to the v4l2_clk API', ov6650 sensor stopped responding because v4l2_clk_get(), still called with depreciated V4L2 clock name "mclk", started to return respective CCF clock instead of the V4l2 one registered by soc_camera. Fix it by calling v4l2_clk_get() with NULL clock name. Created and tested on Amstrad Delta against Linux-4.7-rc3 with omap1_camera fixes. Signed-off-by: Janusz Krzysztofik Signed-off-by: Guennadi Liakhovetski Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/soc_camera/ov6650.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/soc_camera/ov6650.c b/drivers/media/i2c/soc_= camera/ov6650.c index 1f8af1ee8352..1e4783b51a35 100644 --- a/drivers/media/i2c/soc_camera/ov6650.c +++ b/drivers/media/i2c/soc_camera/ov6650.c @@ -1033,7 +1033,7 @@ static int ov6650_probe(struct i2c_client *client, priv->code =3D MEDIA_BUS_FMT_YUYV8_2X8; priv->colorspace =3D V4L2_COLORSPACE_JPEG; =20 - priv->clk =3D v4l2_clk_get(&client->dev, "mclk"); + priv->clk =3D v4l2_clk_get(&client->dev, NULL); if (IS_ERR(priv->clk)) { ret =3D PTR_ERR(priv->clk); goto eclkget; --=20 2.14.1