Received: by 10.223.185.116 with SMTP id b49csp1107002wrg; Sat, 3 Mar 2018 15:46:04 -0800 (PST) X-Google-Smtp-Source: AG47ELv3dBeEhSMs3O/x8Xh40GShK2imE6xgyy4coDk/q7sQKvtF8EysrBsfuiSKX9OBuEW20aRX X-Received: by 10.99.124.91 with SMTP id l27mr8210726pgn.298.1520120764024; Sat, 03 Mar 2018 15:46:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520120763; cv=none; d=google.com; s=arc-20160816; b=ZIUDXPH2St4QlWKGmB3jMaIWQ38hb/LDB0nXI/5kyGq2nhnYJ1nFY/DspkXoucdp7q ayPbUhYnnt20A9tsCtQEWpYzZlInDzDRZq65JYxjU6kDctrURcULRg8hGcI1/kQ7zgir fOb8+WJc8ovlMAS1iUaxTGsTnlFNj/6bKQ1Fs3rmK16V2FDEtI/SOoa8b9Q3NM1TbRqD ViI8TW+4jZrf6KK4bMCv0HwRs6eJKuNRZbZSUgV9bVnIQIImqWjSIOQ3Rsdi3bdAQL+X WcmiJ3dosA7WLQ6dm3SvFUY7xLEN2uT4CsQcjxHHxZSsBR3GdJcdbWt0NlbFrW5dzu+5 9yfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=v/25BujwtcFkgNIwluYsEfXEEaAaDhYZG1cchk4qAmQ=; b=nHJ0/WkSfjkL6rIup/QdWVfgxrFEdC1N4HeN0MuPb91NJPNUjqkhjPtVOsTdd62u6j 1Xs8ZDGNJ1qED+/gmaFJZ6SHmiwXn9/zzERCqvw/XB+vgvv6teZWDX1nSxF4mH5+z72+ soFRe3No7I98RtitxX09v05kkmP+k8ZZpHuCY/mRSJ/ZY8gBeBj5Wdt4Ny4qBO4+fqso KwvbcSXFA2CSaUrtdbmreSCLxQ68Cf/i5iL0c9jtidmHdh5IITGpBmh8a1Rp+IFGShbg J9HKdHqe4OTir6m+SOxGZ+apX83wKsTKhexEy+lLvn0ydNK/yHlQwpbnE8zojDao3XdC z8jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Y4vYKWy0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f30-v6si6934118plf.654.2018.03.03.15.45.49; Sat, 03 Mar 2018 15:46:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=Y4vYKWy0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934361AbeCCXpJ (ORCPT + 99 others); Sat, 3 Mar 2018 18:45:09 -0500 Received: from mail-by2nam03on0113.outbound.protection.outlook.com ([104.47.42.113]:51939 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934164AbeCCWeK (ORCPT ); Sat, 3 Mar 2018 17:34:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=v/25BujwtcFkgNIwluYsEfXEEaAaDhYZG1cchk4qAmQ=; b=Y4vYKWy0Q4aYvkYXMvsalCr55ru4Ic7BsduU75wnSCcYJJPUEUZNwBO7TgO72KrdMMO7hwN0EHTvw7xet+E1UYwXAnFOHQ42+OI2QNLS6jcTLuywD0IRlyYh69Xqd6NNvNXtWwynu56GAcctEHW9IR5f2opMlKtzSUeuICsvZrw= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1068.namprd21.prod.outlook.com (52.132.149.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.3; Sat, 3 Mar 2018 22:34:07 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:34:07 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Javier Martinez Canillas , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 113/219] ASoC: wm8978: Add OF device ID table Thread-Topic: [PATCH AUTOSEL for 4.9 113/219] ASoC: wm8978: Add OF device ID table Thread-Index: AQHTsz8HrfFCP8u9iEyowp4o08NqLw== Date: Sat, 3 Mar 2018 22:29:01 +0000 Message-ID: <20180303222716.26640-113-alexander.levin@microsoft.com> References: <20180303222716.26640-1-alexander.levin@microsoft.com> In-Reply-To: <20180303222716.26640-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1068;7:eX3JE4uiWfPt3xBA/7gS2kc1u8AouYYnSjZNNN3FWKPGjYqEXqIfu06RgS1Ipd5k8sm1wtWMgffa0Pm1as+7LSTNsdnCUYKgDgcDdUwGfBD7jTC9RjmUF1yLEV0Hhum1k4BTPPPkFns/vzHmKLqEQxqViUbIkL2fqUYlTem/Ws8kGtW5wHaJaWj3FgTbgXFdgsG74Xe9BzfrVueBQdzknI7Dc4Ld3PgKv3j1cpK9QPCR/kdG1GjFXKh4S2gTQ1YO x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e2062871-9adb-4361-2e99-08d58156e060 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1068; x-ms-traffictypediagnostic: MW2PR2101MB1068: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231220)(944501244)(52105095)(10201501046)(6055026)(61426038)(61427038)(6041288)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:MW2PR2101MB1068;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1068; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(396003)(39380400002)(366004)(376002)(39860400002)(346002)(199004)(189003)(102836004)(6506007)(26005)(66066001)(4326008)(1076002)(105586002)(10290500003)(478600001)(72206003)(86612001)(14454004)(186003)(2906002)(2501003)(305945005)(7736002)(36756003)(3660700001)(5250100002)(25786009)(2950100002)(5660300001)(3846002)(2900100001)(3280700002)(6116002)(106356001)(22452003)(97736004)(316002)(575784001)(81166006)(10090500001)(81156014)(8936002)(8676002)(76176011)(6436002)(110136005)(53936002)(6486002)(54906003)(6512007)(86362001)(107886003)(68736007)(99286004)(6666003)(22906009)(217873001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1068;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4h/gIt49GA+/G4oZJqK9y7nr6yqPb+JHsyDwGWrtaRhSLQtWvEj4iZkUa019jwWF/AUERUt062AaGjBt9mP6kcgFPrmhKDVyVyMNOasDwF2q/Lwb0rIL90Q5ymBq0jByj1bRy4m7FvfFfwgY77pdTOBc2J5G4oznDqO/PQ7xqKM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2062871-9adb-4361-2e99-08d58156e060 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:29:01.6976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1068 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Javier Martinez Canillas [ Upstream commit 5cf015d9cb02c360582b624497b0a1716881cf28 ] The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Before this patch: $ modinfo sound/soc/codecs/snd-soc-wm8978.ko | grep alias alias: i2c:wm8978 After this patch: $ modinfo sound/soc/codecs/snd-soc-wm8978.ko | grep alias alias: i2c:wm8978 alias: of:N*T*Cwlf,wm8978C* alias: of:N*T*Cwlf,wm8978 Signed-off-by: Javier Martinez Canillas Acked-by: Charles Keepax Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/wm8978.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/codecs/wm8978.c b/sound/soc/codecs/wm8978.c index 90b2d418ef60..cf761e2d7546 100644 --- a/sound/soc/codecs/wm8978.c +++ b/sound/soc/codecs/wm8978.c @@ -1071,9 +1071,16 @@ static const struct i2c_device_id wm8978_i2c_id[] = =3D { }; MODULE_DEVICE_TABLE(i2c, wm8978_i2c_id); =20 +static const struct of_device_id wm8978_of_match[] =3D { + { .compatible =3D "wlf,wm8978", }, + { } +}; +MODULE_DEVICE_TABLE(of, wm8978_of_match); + static struct i2c_driver wm8978_i2c_driver =3D { .driver =3D { .name =3D "wm8978", + .of_match_table =3D wm8978_of_match, }, .probe =3D wm8978_i2c_probe, .remove =3D wm8978_i2c_remove, --=20 2.14.1