Received: by 10.223.185.116 with SMTP id b49csp1112735wrg; Sat, 3 Mar 2018 15:57:51 -0800 (PST) X-Google-Smtp-Source: AG47ELtK8I6J8ELH1rLmqi/HeOig7VKRi6Lb8ZbpvxAX96EEh6zjeowiIh7KEbaDqeRdHmirrBCH X-Received: by 10.98.149.90 with SMTP id p87mr10391121pfd.28.1520121471027; Sat, 03 Mar 2018 15:57:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520121470; cv=none; d=google.com; s=arc-20160816; b=SPHEg8MzY0WZXxWR31Y14o/5OID3Oirb4uPCn3BnYvV6DP/urRxmA0TZMOElTP6Gw5 6OEWBTMXxDrXqb/EUqN35DVPZlXi9baLhoF36l1ZdiUSaODNb1CN7l9wKEFU3YQq42Q/ fZ05F7D/m0vJPZXgixUmGuF6DyJG9ice49Bu4shs3Jw5S5ErFVDFGbifnZNsnlhq71jQ I6Jt5F0R7E+QMTSf0mzDt4DLKgU82wmQupryPJC7W/br60ifoB47zrakkIyvUFw/5lQJ mwHMw5edaBAh+gcv2nPO8yWnQ8PL8m+5WtsvScZweThxcP3b99c2E+zELKLfqkxRoDs9 ssDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=C5OOlerbsEcREgAOVI1QlfJZvF3flj7GL8OWdHCToqI=; b=fzXbjp/lWwmOGeobdUpjrozyc7+l8oNMxN/qEP+ttwXtH6tBKPsM7nPriXPa1elSxC mj35HQdpqnFr5fT4RBGFr01tQJrhXPQE/+I7PV3c8yC7GJyBAL98eXfbSWDcwIgZuYgi fb7e1hnVSwimS4hzLCb0asWKU7y4vEm+fcnmVFx/p67lFJAYVqV+q+cdLefjxcrj8rE7 WlKrrIhud2KlZtUyRL8qXkjyC530mXuGbTL/YzaRf8AxQFFNHSFWBJP+19qtFlY4RzvE q5VyD4ahSUcvdhHPSpCJ5Td9xKxXRADlw2AsFT4ZlTxNdnrWI2vY+rbIqqDy0iX2EpVF y+NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=jvv25zRa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4-v6si6915902plp.253.2018.03.03.15.57.37; Sat, 03 Mar 2018 15:57:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=jvv25zRa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933241AbeCCX5H (ORCPT + 99 others); Sat, 3 Mar 2018 18:57:07 -0500 Received: from mail-by2nam03on0115.outbound.protection.outlook.com ([104.47.42.115]:54496 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933819AbeCCWc0 (ORCPT ); Sat, 3 Mar 2018 17:32:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C5OOlerbsEcREgAOVI1QlfJZvF3flj7GL8OWdHCToqI=; b=jvv25zRapB/lFAUscIQNV2Sg5as1mKgrmku2cOuJcRbsOy0KwujzBeZnghxYqDS2ur7ZcrBgDPbVpOm0mu+kEzGGfiOLeoz5YYNW5haEwww9xbyCCmmzVJsI0YhbfdL+as/08fNIMgp1+opVrcDgMrRuiM43ToIiSgEWNfxlxzo= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1036.namprd21.prod.outlook.com (52.132.149.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.3; Sat, 3 Mar 2018 22:32:17 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:32:17 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Janusz Krzysztofik , Guennadi Liakhovetski , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 057/219] [media] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock Thread-Topic: [PATCH AUTOSEL for 4.9 057/219] [media] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock Thread-Index: AQHTsz70/3XDuDz0Yke45diVhBwoVQ== Date: Sat, 3 Mar 2018 22:28:29 +0000 Message-ID: <20180303222716.26640-57-alexander.levin@microsoft.com> References: <20180303222716.26640-1-alexander.levin@microsoft.com> In-Reply-To: <20180303222716.26640-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1036;7:5yOgNPSNLt1GGMo9ttdCnqJuzV6MZgy9paNbcRh5pmZ1qWPqlqMbHoCL9PKSLbbJIoIaGtOzjBpVWmkHeQxzVNAVdTwaCmdGUbgFAeYjDHK2oM/TTKwatX+3xE0wF+IQiYhhvqB4DqVi8NOiCHYTLS7gSK9LAUcn4CJnLzWH9yNVAH3VwgUXC3Amc1nALmonKydtgGsBomTZDt0ZAHSsG4u7tQ9Ubc63fHm5y+S2IASjF+cSdpC0kEF95i/wQUeY x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d87efe23-1732-4516-fcf4-08d581569e9c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1036; x-ms-traffictypediagnostic: MW2PR2101MB1036: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(26323138287068)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231220)(944501244)(52105095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041288)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:MW2PR2101MB1036;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1036; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(39380400002)(346002)(376002)(39860400002)(199004)(189003)(10290500003)(81166006)(5660300001)(107886003)(8936002)(39060400002)(81156014)(3846002)(6506007)(2906002)(8676002)(3280700002)(59450400001)(72206003)(76176011)(4326008)(478600001)(6116002)(6486002)(53936002)(1076002)(68736007)(6512007)(102836004)(8666007)(2501003)(66066001)(3660700001)(5250100002)(6436002)(105586002)(86612001)(36756003)(316002)(7736002)(97736004)(26005)(186003)(110136005)(305945005)(22452003)(575784001)(86362001)(99286004)(6666003)(25786009)(106356001)(2900100001)(14454004)(54906003)(10090500001)(2950100002)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1036;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: CuYm/tn18sbKolnDDiVgD+SgiLGMAbmUdmOkUjR4pkpJWvWZ+rHHRB/TcTP22ZzQDNoWNTKylCRS0c8NgZBfS9/CmnuUaben+pJAs09xFZl9A23B8l7I8Bl6Yc+AdvsIElaST/kY9hgdjmDa+eCb46pLjhHl1RC6/4kt9f/pZyE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: d87efe23-1732-4516-fcf4-08d581569e9c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:28:29.4006 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1036 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Janusz Krzysztofik [ Upstream commit 54449af0e0b2ea43a8166611c95b730c850c3184 ] After changes to v4l2_clk API introduced in v4.1 by commits a37462b919 '[media] V4L: remove clock name from v4l2_clk API' and 4f528afcfb '[media] V4L: add CCF support to the v4l2_clk API', ov6650 sensor stopped responding because v4l2_clk_get(), still called with depreciated V4L2 clock name "mclk", started to return respective CCF clock instead of the V4l2 one registered by soc_camera. Fix it by calling v4l2_clk_get() with NULL clock name. Created and tested on Amstrad Delta against Linux-4.7-rc3 with omap1_camera fixes. Signed-off-by: Janusz Krzysztofik Signed-off-by: Guennadi Liakhovetski Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/soc_camera/ov6650.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/soc_camera/ov6650.c b/drivers/media/i2c/soc_= camera/ov6650.c index 4bf2995e1cb8..8f85910eda5d 100644 --- a/drivers/media/i2c/soc_camera/ov6650.c +++ b/drivers/media/i2c/soc_camera/ov6650.c @@ -1033,7 +1033,7 @@ static int ov6650_probe(struct i2c_client *client, priv->code =3D MEDIA_BUS_FMT_YUYV8_2X8; priv->colorspace =3D V4L2_COLORSPACE_JPEG; =20 - priv->clk =3D v4l2_clk_get(&client->dev, "mclk"); + priv->clk =3D v4l2_clk_get(&client->dev, NULL); if (IS_ERR(priv->clk)) { ret =3D PTR_ERR(priv->clk); goto eclkget; --=20 2.14.1