Received: by 10.223.185.116 with SMTP id b49csp1113281wrg; Sat, 3 Mar 2018 15:59:06 -0800 (PST) X-Google-Smtp-Source: AG47ELtftx+mtNCbviKpT5i6L/plCHoGq6Q+kqEtydRp8wag5Kbte9wIVYyRs6eOUj+ObtXoo7AJ X-Received: by 10.98.9.5 with SMTP id e5mr10530168pfd.189.1520121545990; Sat, 03 Mar 2018 15:59:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520121545; cv=none; d=google.com; s=arc-20160816; b=eXrdhkUoxKQLK6Bd3ElKSOOZHBYpyELy2+h9OqaRELcoNIokCF8A1dmc6fJsuNPiHQ A8AUd5Y9dehe8ZBIAHh25eahaPRPBVCj69GIHLUrWmS3pY6RHCPbhnnv5crNS/te4S3f /dKyoOy7y2NY0OJTLDFMnhHC7MTv5rFQGBMzfsNoa2O8k973Ul8h4j6ZWzn+E3F1ui9n bvY3GjjDR1F3aFmzqanFo+N9hrb4NeOaouzGUizHJYU8SzEeVU0r7n7odzy8SNGSYLUJ ID8wUot+J3BLCBmjDXtCpuq/nVzHxGPyv43pfKQSkH9PyykQcvtNP5TYlDtMfqpABP+C PiTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=1tpqu9IBS86diAUrOpxPz2N7A9smARC0T9Dlcf/0QjA=; b=WPTZWWLoUOiNrwgviryciapR5I4sxUwr+O0XdrySq+cfbyZlJQLkJtGKt19ae3I9cY f7iCPj0rHyKiMeTzvyJC5h0DgYxvPx2NUhplZ8JlXd0LW28OJbaiZ6h2JXeGqU4dQeyS HPu6Fm+PQr+gpZEM4454Y8E4JFfaCZfDqymSfYRHOhodk6RB7u28p6qPyCL3B0oq8/NU EUPQ7goJ3xCeewv0wWWO+1aIWGJ7HO95UfbF3xuy6Gqq78Tf1Ef8GoQVtX0/qk2Phhec /+fbUWzIhlRg15t9fpaIXCLn4VB9WeaQuGyF9IQDgVJixD8z7+P6+1zKsFk1OnswTP0s 3Srw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=MNAQj8rq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 62-v6si6950957ple.491.2018.03.03.15.58.52; Sat, 03 Mar 2018 15:59:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=MNAQj8rq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933290AbeCCX6T (ORCPT + 99 others); Sat, 3 Mar 2018 18:58:19 -0500 Received: from mail-by2nam01on0111.outbound.protection.outlook.com ([104.47.34.111]:2176 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933820AbeCCWcW (ORCPT ); Sat, 3 Mar 2018 17:32:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1tpqu9IBS86diAUrOpxPz2N7A9smARC0T9Dlcf/0QjA=; b=MNAQj8rqJTx7YH8rslaSTPuocHLShG56BpoD9gyKWhhj2G+8Awq0CHTdaD5VPme15K3T6iU0004BafPaPaqUoj7tceBT9DSXIWI3lH/t2/b9Lg+dhc0ZL/IsjM4EFu06MVqXEQUBiwWkV5mazF0KGfoRh/b4Kuv5sA/8dibJgFY= Received: from MW2PR2101MB1034.namprd21.prod.outlook.com (52.132.149.10) by MW2PR2101MB1097.namprd21.prod.outlook.com (52.132.149.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Sat, 3 Mar 2018 22:32:18 +0000 Received: from MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0]) by MW2PR2101MB1034.namprd21.prod.outlook.com ([fe80::1d56:338f:e2b:cec0%3]) with mapi id 15.20.0567.006; Sat, 3 Mar 2018 22:32:18 +0000 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Javier Martinez Canillas , Dmitry Torokhov , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 060/219] Input: qt1070 - add OF device ID table Thread-Topic: [PATCH AUTOSEL for 4.9 060/219] Input: qt1070 - add OF device ID table Thread-Index: AQHTsz71t984mB14S0yS1zyLTEJv+g== Date: Sat, 3 Mar 2018 22:28:31 +0000 Message-ID: <20180303222716.26640-60-alexander.levin@microsoft.com> References: <20180303222716.26640-1-alexander.levin@microsoft.com> In-Reply-To: <20180303222716.26640-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1097;7:nuuW7sVxKvOYWv9fuCm/yVbBuf0U8lS3cyr4Sq+oJ1m45XHUTZHntvoRw4NJtcEdWs0oViOTaB3c5uq3rlmiSpY98apHzmWuLr/+iyfqOqAeMoXGrAxqWLT12j7VGZNeLZysDA7YdirvjZ+3rimpYF+tQlQ6EZet+6VZJcgxKGNYcZ+xV/iWfKm7g6v0gyHt1hycjGXyWTJRVMsnzeeEMfA1SvoWnoygiNFVgXX7C69vW+62z8UVMshsdPwLPryZ x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 363b1de2-32ff-497f-b663-08d581569f99 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1097; x-ms-traffictypediagnostic: MW2PR2101MB1097: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158)(7411616537696); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011);SRVR:MW2PR2101MB1097;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1097; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(376002)(366004)(39380400002)(396003)(39860400002)(346002)(189003)(199004)(305945005)(105586002)(36756003)(3660700001)(86362001)(6666003)(66066001)(2900100001)(5660300001)(8676002)(10090500001)(81166006)(81156014)(8936002)(22452003)(10290500003)(2950100002)(39060400002)(4326008)(25786009)(5250100002)(2501003)(68736007)(7736002)(72206003)(14454004)(478600001)(186003)(110136005)(26005)(316002)(2906002)(97736004)(6512007)(99286004)(107886003)(54906003)(1076002)(6506007)(106356001)(53936002)(6116002)(3846002)(102836004)(6486002)(86612001)(3280700002)(6436002)(76176011)(22906009)(217873001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1097;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: KDT0K4CBYtuhFP0oYH4nPmzShV/vmKY3IFuNqPdGFx+vfXIXdjSapoOUkZKVkUSRA8bbO6b5dlvG8DKofhhlVR4PNkQ/EHRT7bsXd/Aox7nUyeufDrmnMaCaaoF+hEWZ/4Db90gkjlt9F4ZZ6nzzPk9QYLAjPyxlwVcBf6npTG4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 363b1de2-32ff-497f-b663-08d581569f99 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:28:31.1350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1097 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Javier Martinez Canillas [ Upstream commit cf5cd9d4480a87da78768718cac194a71079b5cb ] The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. The compatible strings don't have a vendor prefix because that's how it's used currently, and changing this will be a Device Tree ABI break. Signed-off-by: Javier Martinez Canillas Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/keyboard/qt1070.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt107= 0.c index 5a5778729e37..76bb51309a78 100644 --- a/drivers/input/keyboard/qt1070.c +++ b/drivers/input/keyboard/qt1070.c @@ -274,9 +274,18 @@ static const struct i2c_device_id qt1070_id[] =3D { }; MODULE_DEVICE_TABLE(i2c, qt1070_id); =20 +#ifdef CONFIG_OF +static const struct of_device_id qt1070_of_match[] =3D { + { .compatible =3D "qt1070", }, + { }, +}; +MODULE_DEVICE_TABLE(of, qt1070_of_match); +#endif + static struct i2c_driver qt1070_driver =3D { .driver =3D { .name =3D "qt1070", + .of_match_table =3D of_match_ptr(qt1070_of_match), .pm =3D &qt1070_pm_ops, }, .id_table =3D qt1070_id, --=20 2.14.1