Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S274859AbTHFMT1 (ORCPT ); Wed, 6 Aug 2003 08:19:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S274997AbTHFMT0 (ORCPT ); Wed, 6 Aug 2003 08:19:26 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:10689 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S274859AbTHFMT0 (ORCPT ); Wed, 6 Aug 2003 08:19:26 -0400 Message-ID: <3F30F237.5070502@pobox.com> Date: Wed, 06 Aug 2003 08:19:03 -0400 From: Jeff Garzik Organization: none User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk X-Accept-Language: en MIME-Version: 1.0 To: Andries.Brouwer@cwi.nl CC: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org, torvalds@osdl.org Subject: Re: Add identify decoding 4/4 References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 514 Lines: 18 Andries.Brouwer@cwi.nl wrote: > Here a somewhat uneven commented ide_identify.h. > This is part of a larger patch, but suffices for now. Do you really want to stick that long function in a header? Stick it in ide-lib.c, that's a better place for it, IMO... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/