Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 4 Mar 2018 08:20:41 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Frank Rowand <frowand.list@gmail.com>
cc:     Rob Herring <robh+dt@kernel.org>, pantelis.antoniou@konsulko.com,
        Pantelis Antoniou <panto@antoniou-consulting.com>,
        Ivan Gorinov <ivan.gorinov@intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, geert@linux-m68k.org,
        laurent.pinchart+renesas@ideasonboard.com
Subject: Re: [PATCH v7 1/5] x86: devicetree: fix config option around
 x86_flattree_get_config()
In-Reply-To: <822454a2-19f1-48d2-0ef6-e2d86f0c5406@gmail.com>
Message-ID: <alpine.DEB.2.21.1803040820130.1654@nanos.tec.linutronix.de>
References: <1520122673-11003-1-git-send-email-frowand.list@gmail.com> <1520122673-11003-2-git-send-email-frowand.list@gmail.com> <822454a2-19f1-48d2-0ef6-e2d86f0c5406@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 3 Mar 2018, Frank Rowand wrote:

> On 03/03/18 16:17, frowand.list@gmail.com wrote:
> > From: Frank Rowand <frank.rowand@sony.com>
> > 
> > x86_flattree_get_config() is incorrectly protected by
> > ifdef CONFIG_OF_FLATTREE.  It uses of_get_flat_dt_size(), which
> > only exists if CONFIG_OF_EARLY_FLATTREE.  This issue has not
> > been exposed previously because OF_FLATTREE did not occur unless
> > it was selected by OF_EARLY_FLATTREE.  A devicetree overlay change
> > is selecting OF_FLATTREE directly instead of indirectly enabling
> > it by selecting OF_EARLY_FLATTREE.
> > 
> > This problem was exposed by a randconfig generated by the kbuild
> > test robot, where Platform OLPC was enabled.  OLPC selects
> > OF_PROMTREE instead of OF_EARLY_FLATREE.  The only other x86
> > platform that selects OF is X86_INTEL_CE, which does select
> > OF_EARLY_FLATTREE.
> > 
> > Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> > ---
> > 
> > x86 Maintainers, please ack this patch for Rob to accept

Acked-by: Thomas Gleixner <tglx@linutronix.de>