Received: by 10.223.185.116 with SMTP id b49csp1564901wrg; Sun, 4 Mar 2018 05:00:34 -0800 (PST) X-Google-Smtp-Source: AG47ELuwq28OIMwXH98W/GjtVhyzhvWqlhtWHdoh4gx1kiZ0Kmfomx/Bgi7iS/pdY8Tv1CvIWyHR X-Received: by 2002:a17:902:f81:: with SMTP id 1-v6mr9888494plz.265.1520168434124; Sun, 04 Mar 2018 05:00:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520168434; cv=none; d=google.com; s=arc-20160816; b=TzILLKIQjAcMNlc2+T1e+tamCdzk0BrmFZQ7C0IQNmoI6adrd6XyntTgDv1e41kQAS oUwLfiw2lZmGrZFkvJf1wzDF30aP6YgJvaiOSc2HbAmC2Vx6jA+GK9UxSqbn13oo1ysp f5t32SekEpATAJSZ6WNqZRmzMTNYvQheTq25kQDyQhWOIRcvNJl3FGADVX9UP4ydue3B /P4grLCXelFE13W6rAS/yqFEb8L2lkynzso1/REdi/Me7CEFA2NvshZHXfD+eltbrzEQ qKRgSyOTq9LPHsSYwUW6VtpCCwB8BpcwH2PxQwGYo9lnVJ2Xl8ai6N6NLsXjUZO7PCjF LBVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=7yzEjTnYnYE89xvQ0bSjvq95gwmEvcvdL4xSvwoTayg=; b=q0NegUW/PXj+4joSp5wkZ2S13+GmUb7UEHEqBchGIAweoi3LjIpa3b2Bl3l0Bw8AW4 UddYsrYZDnKFBbIXlSZ3ETTIch+2iJFREp5NMZgUn/uP02GlsdovLbjpxAB4kLNf2YUE Ij4/GYh80+pGWlB9xcPv/XOErJDTBD+wkx8v/2nNBJLAfXX+qwOQjJO/KiEcIiBUw8o+ CD9/kJeA6YAowBS+MBAeynTlHsKeKsyWLSXh4JE1mFAxqYLnrQTK2Flm0iST8fxx9xbr ClSWa6XuIzqUWclr4EicbYVceC+Hw0mQc+QXKkETEti/QwnRUXVp7tjqjYYMKLyy6fzd ZFJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si7785445ply.22.2018.03.04.05.00.20; Sun, 04 Mar 2018 05:00:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbeCDM4Z (ORCPT + 99 others); Sun, 4 Mar 2018 07:56:25 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:40082 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752566AbeCDM4T (ORCPT ); Sun, 4 Mar 2018 07:56:19 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.84_2 #2 (Debian)) id 1esTBR-0001bG-UX; Sun, 04 Mar 2018 20:56:10 +0800 Received: from herbert by gondobar with local (Exim 4.84_2) (envelope-from ) id 1esTBK-0006OR-GN; Sun, 04 Mar 2018 20:56:02 +0800 Date: Sun, 4 Mar 2018 20:56:02 +0800 From: Herbert Xu To: "Maciej S. Szmigiero" Cc: "David S. Miller" , David Howells , Tom Lendacky , Gary Hook , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] crypto: ccp - return an actual key size from RSA max_size callback Message-ID: <20180304125602.GA24397@gondor.apana.org.au> References: <51c265e4-6153-3e5e-316a-ebef059ac36a@maciej.szmigiero.name> <20180302164451.GJ21579@gondor.apana.org.au> <087e7b27-f839-8d4b-8da8-5d0fa2f8caf1@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <087e7b27-f839-8d4b-8da8-5d0fa2f8caf1@maciej.szmigiero.name> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 03, 2018 at 12:15:20AM +0100, Maciej S. Szmigiero wrote: > > However, what about the first patch from this series? > Without it, while it no longer should cause a buffer overflow, in-kernel > X.509 certificate verification will still fail with CCP driver loaded > (since CCP RSA implementation has a higher priority than the software > RSA implementation). That normally goes through the security tree. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt