Received: by 10.223.185.116 with SMTP id b49csp2208611wrg; Sun, 4 Mar 2018 21:34:24 -0800 (PST) X-Google-Smtp-Source: AG47ELtFSD3JR5gYBCjc690cpBkceHJjPIIO+06wfhTmvFwD39337VR9TtIMHfcJEhhKlhhd/FBT X-Received: by 10.98.31.79 with SMTP id f76mr14212515pff.60.1520228064118; Sun, 04 Mar 2018 21:34:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520228064; cv=none; d=google.com; s=arc-20160816; b=J8bbG3AHUWbQP/JZx8oyX8eshLh4FJjkELHVYqI69k1Crq1Sk+Ti25Ryny5GNVBqoO N+OYAH0gU6LtqKw/9quzCBurHM/RyASmzihsQqz7zu3D4ILXC+mscyclmzqnCfa0fRw0 pZZ2G71AErJYd2PQLDSJUWzQZo2AA+HvDIcZEvXOTdM0dkj4AO2Ksjw3CfEMHbn4ELcW KPTEb1h9NHMg2a7aeMiOgcEOnwvBpk9GkyIC/N4q9jZTgYwTDsSKwy/eFNQdl53xovpg JyySJabVAT3a6PCQE2kQ/WCwAqTHEKDJvC0PiHDxWonGj46pi9DLo5UnGjPcbNI52sgE 6cwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=+90Zp8nhc+/F1tUrqS9CuofQThO4w+JwNXxF4Wr0TeQ=; b=Q2TJzeO73afK69BJisHDVwG/WWreOlMTXe3MisWJJaotRRnkjAQnjMYUskeAwmMDsB p0ra0m4kI5/uk8izZVhPzb2s7Xvvq4JhDvFjKVZM20cGmarjEyPSqk0/I5NqA6YGcA7r WZRDxWhbVD3+eYBarZzRuD6fmZP2e7m/GtuVZzlZaxVw7HsEQmyGkSVaQRX57M6qxLNC sI/x2y5pov1Si8fmzu36GQMcFH5rCRTPXLKBISrQPx1PdoDNRA/fQsGti1jQflCLPser +oQw7AsWf/xH+A0T0Ppvb9gi5r8m598HHSN8xXfzo6eULghHEIPpP84+5ihHMEJ7Xm+Z 1MEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o86si9682014pfi.253.2018.03.04.21.34.10; Sun, 04 Mar 2018 21:34:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932811AbeCEFcr (ORCPT + 99 others); Mon, 5 Mar 2018 00:32:47 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:60495 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932476AbeCEFcm (ORCPT ); Mon, 5 Mar 2018 00:32:42 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R281e4;CH=green;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04455;MF=zhang.jia@linux.alibaba.com;NM=1;PH=DS;RN=2;SR=0;TI=SMTPD_---0Syvy3pu_1520227930; Received: from ali-6c96cfd98fb5.local(mailfrom:zhang.jia@linux.alibaba.com fp:106.11.34.13) by smtp.aliyun-inc.com(127.0.0.1); Mon, 05 Mar 2018 13:32:10 +0800 Subject: Re: [PATCH 1/4] module: Do not access sig_enforce directly To: jeyu@kernel.org Cc: linux-kernel@vger.kernel.org References: <1519895346-7961-1-git-send-email-zhang.jia@linux.alibaba.com> From: Jia Zhang Message-ID: Date: Mon, 5 Mar 2018 13:32:10 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519895346-7961-1-git-send-email-zhang.jia@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jessica, Could you review this patch series? Thanks, Jia On 2018/3/1 下午5:09, Jia Zhang wrote: > Call is_module_sig_enforced() instead. > > Signed-off-by: Jia Zhang > --- > kernel/module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/module.c b/kernel/module.c > index ad2d420..003d0ab 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -2789,7 +2789,7 @@ static int module_sig_check(struct load_info *info, int flags) > } > > /* Not having a signature is only an error if we're strict. */ > - if (err == -ENOKEY && !sig_enforce) > + if (err == -ENOKEY && !is_module_sig_enforced()) > err = 0; > > return err; >